Re: [PATCH]: fix lro_gen_skb() alignment

2007-11-30 Thread Herbert Xu
~(mac_hdr_len - 1) 3 Bonus points for putting this in a macro alongside NET_IP_ALIGN :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-11-30 Thread Herbert Xu
On Thu, Nov 29, 2007 at 10:31:58PM -0500, John W. Linville wrote: Dave/Herbert, Here is another clutch of patches intended for 2.6.24. Let me know if there are any problems! Pulled. Thanks John! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [GIT PULL] SCTP bug fixes for net-2.6

2007-11-30 Thread Herbert Xu
/scm/linux/kernel/git/vxy/lksctp-dev.git pending Pulled. Thanks Vlad! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: [Bugme-new] [Bug 9440] New: Problem in joinning a socket to ipv6 multicast address in specific scenario

2007-11-30 Thread Herbert Xu
to recreate idev if it isn't there and the MTU is big enough. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: [PATCH]: fix lro_gen_skb() alignment

2007-11-30 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-11-30 Thread Herbert Xu
) | Is it not the other way round ?? :- I agree. Wang Chen, please change this and other appropriate BH calls to USER. Basically recvmsg should always be USER while rcv is BH. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: net-2.6.25 rebased

2007-11-30 Thread Herbert Xu
On Fri, Nov 30, 2007 at 01:32:19AM +1100, Herbert Xu wrote: Just to let you all know that I've just rebased net-2.6.25 so that it now contains all of net-2.6 as it currently stands. I've rebased it again. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-30 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:35:43PM +, Steven Whitehouse wrote: Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by: Steven Whitehouse [EMAIL PROTECTED] Patch applied. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home

Re: ZD1211RW unaligned accesses...

2007-11-30 Thread Herbert Xu
assured we will be working on that. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] AF_RXRPC: Configure crypto correctly for AF_RXRPC

2007-11-30 Thread Herbert Xu
On Wed, Nov 28, 2007 at 02:37:53PM +, David Howells wrote: AF_RXRPC uses the crypto services, so should depend on or select CRYPTO. Signed-off-by: David Howells [EMAIL PROTECTED] Patch applied to net-2.6. Thanks. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [Bugme-new] [Bug 9440] New: Problem in joinning a socket to ipv6 multicast address in specific scenario

2007-11-30 Thread Herbert Xu
On Fri, Nov 30, 2007 at 03:25:16PM +0300, Evgeniy Polyakov wrote: Ok, added netdev_up too. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] Applied to net-2.6. Thanks Evgeniy! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [PATCH 0/4] Sysctl namespace support

2007-11-30 Thread Herbert Xu
with Andrew's fixes included. Thanks Eric. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] AF_RXRPC: Configure crypto correctly for AF_RXRPC

2007-11-30 Thread Herbert Xu
Ingo Molnar [EMAIL PROTECTED] wrote: Patch applied to net-2.6. Thanks. aimed at 2.6.24 merging, right? Yep. net-2.6 is for 2.6.24 while net-2.6.25 is for 2.6.25. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
-archive.com/netdev@vger.kernel.org/msg13817.html Excellent. They now do a recvmsg first with no buffer to get meta-information, which just happens to increment the counters. Could you please resubmit the patch then? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
in the patches that aren't clean-ups. Signed-off-by: Andi Kleen [EMAIL PROTECTED] Signed-off-by: Wang Chen [EMAIL PROTECTED] Who's the author? Andi or you? Please make this obvious with a From header when you resubmit. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: [PATCH 2/2] Eliminate unused argument from sk_stream_alloc_pskb

2007-11-29 Thread Herbert Xu
this question :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread Herbert Xu
at line 269 $ There seems to be a line missing at the end. Please fix the white space errors and resend. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH] XFRM: SPD auditing fix to include the netmask/prefix-length

2007-11-29 Thread Herbert Xu
the netmask/prefix-length is less than the address length, i.e. the SPD entry applies to a network address and not a host address. Any reason why we don't just always include them? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] sungem: fix napi regression with reset work

2007-11-29 Thread Herbert Xu
a superfluous test of gp-running in the same function. Signed-off-by: Johannes Berg [EMAIL PROTECTED] Patch applied to net-2.6. Thanks Johannes! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 07:54:59PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: I've fixed up those errors. OK, patch applied to net-2.6.25. Thanks everyone! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-29 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
drop the mention of UDP completely: The total number of datagrams delivered to applications. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH][UNIX] EOF on non-blocking SOCK_SEQPACKET

2007-11-29 Thread Herbert Xu
an existing application seems to be minimal, I've applied your patch to net-2.6. However, I had to reformat it so that it fits with the Linux coding style. Please take this into account for future patches. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [PATCH] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
the correct RCU primitives for this to work. Synchronisation is like tango, it always takes two to make it work :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [PATCH][BRIDGE] Lost call to br_fdb_fini() in br_init() error path

2007-11-29 Thread Herbert Xu
to net-2.6. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
, perhaps we could even build this logic into rcu_assign_pointer. Then again, who still uses an Alpha? Mine died years ago :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
to have. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
applied to net-2.6. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] Nicer WARN_ON in netstat_show

2007-11-29 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Herbert Xu
/xfrm_policy.c:1449: warning: 'dst' may be used uninitialized in this function by checking for impossible values in the switch(). Thanks Andrew. I've added the following patch to net-2.6. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: [PATCH net-2.6.25 (v2)] [TCP]: Two fixes to new sacktag code

2007-11-29 Thread Herbert Xu
head case. Thanks Ilpo, patch applied to net-2.6.25. BTW, how's the RB-tree stuff coming along? David wanted it to be in as early as possible so that it gets the maximum amount of testing before the next merge window. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH] tcp-illinois: incorrect beta usage

2007-11-29 Thread Herbert Xu
Hemminger [EMAIL PROTECTED] Applied to net-2.6. Thanks Stephen! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

net-2.6.25 rebased

2007-11-29 Thread Herbert Xu
Hi: Just to let you all know that I've just rebased net-2.6.25 so that it now contains all of net-2.6 as it currently stands. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [NET 00/02]: Remove NET_ACT_NAT dependency on NETFILTER

2007-11-29 Thread Herbert Xu
suggests something better. Looks good to me. I've applied both to net-2.6.25. Thanks Patrick! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
boxes according to rumor, ...). Good point! Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Herbert Xu
pretty quickly when packets don't flow anymore :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

Re: ZD1211RW unaligned accesses...

2007-11-29 Thread Herbert Xu
discussing. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
are the norm for violating alignment :) So I'd prefer something that only penalised them rather than everybody else. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
(); \ (p) = (v); \ }) Yes that's what I was thinking. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: DST_NOHASH flag and IPsec transformers routing tables - need some clarification

2007-11-28 Thread Herbert Xu
not in the routing cache because IPsec lookups are done through the flow cache. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: [PATCH 1/2] Uninline the sk_stream_alloc_pskb

2007-11-28 Thread Herbert Xu
! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Herbert Xu
of sense. OK, short of making IPv4 a module (which would be a worthy task :) do you have an example where a symbol is used by more than one module but needs to be put into a namespace? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Herbert Xu
module chances are we want it to be exported for all. Although I admit I haven't examined your examples elsewhere. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH] add compare_ether_addr_unaligned

2007-11-26 Thread Herbert Xu
On Fri, Nov 23, 2007 at 09:26:31PM +0800, Herbert Xu wrote: On Fri, Nov 23, 2007 at 12:09:22AM +, Daniel Drake wrote: David Miller found a problem in a wireless driver where I was using compare_ether_addr() on potentially unaligned data. Document that compare_ether_addr() is not safe

Re: [PATCH 6/7] [IPSEC]: Lock state when copying non-atomic fields to user-space

2007-11-26 Thread Herbert Xu
On Mon, Nov 26, 2007 at 11:18:45AM +0800, Herbert Xu wrote: I'm just going to revert this patch for 2.6.24 since we've lived with this race for so long anyway. Actually, instead of reverting it completely I'm just going to remove the newly added locks which should be just as effective

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Herbert Xu
set_flag would do that. Yes, AF_PACKET would do that. So you should check both. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe

Re: [PATCH net-2.6.25] Name magic constants in sock_wake_async()

2007-11-26 Thread Herbert Xu
admit I'm no good with names either :) Patch applied to net-2.6.25. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe

Re: [PATCH net-2.6.25] Make macro to specify the ptype_base size

2007-11-26 Thread Herbert Xu
names are read better than magic constants. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied to net-2.6.25. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH] Fix memory leak in inet_hashtables.h when NUMA is on

2007-11-26 Thread Herbert Xu
. Thanks. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH 2/10] [SKBUFF]: Add skb_morph

2007-11-26 Thread Herbert Xu
-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/include/linux/skbuff.h b/include/linux

Re: [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess

2007-11-26 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/4] xfrm_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Herbert Xu
to avoid memset entirely. Patch applied. Thanks everyone! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [PATCH 2/4] fib_semantics: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Herbert Xu
On Mon, Nov 26, 2007 at 10:24:03AM +, Joonwoo Park wrote: fib_semantics: kmalloc + memset conversion to kzalloc fix to avoid memset entirely. Also applied. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [PATCH 3/4] fib_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Herbert Xu
On Mon, Nov 26, 2007 at 10:24:03AM +, Joonwoo Park wrote: fib_hash: kmalloc + memset conversion to kzalloc fix to avoid memset entirely. Patch applied. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert

Re: [PATCH net-2.6.25] Fix pcounter build error without CONFIG_SMP

2007-11-26 Thread Herbert Xu
:-). Thank you! UP is for sissies anyway :-P Acked-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Ilpo, you need a new machine :) Thanks for fixing this! Patch applied to net-2.6.25. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [XFRM]: Fix leak of expired xfrm_states

2007-11-26 Thread Herbert Xu
though the ref count on x may now drop to zero, it won't be freed until del_timer_sync returns which should be sufficient, no? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [XFRM]: Fix leak of expired xfrm_states

2007-11-26 Thread Herbert Xu
when looking at the xfrm[46]_mode_{tunnel,transport} module reference counts, they climb higher and higher over time. Oh I see. How about just removing those double underscores then? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: [XFRM]: Fix leak of expired xfrm_states

2007-11-26 Thread Herbert Xu
deletes the SA while the timer is running it'll go up in smoke too. If you look in the history you'll find that the same patch that removed the ref count on the timer introduced the call to del_timer_sync :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: DST_NOHASH flag and IPsec transformers routing tables - need some clarification

2007-11-26 Thread Herbert Xu
, there is no cache at all for IPv6). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 1/1][ATM]: [he] initialize lock and tasklet earlier

2007-11-26 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/1][ATM]: [he] initialize lock and tasklet earlier

2007-11-26 Thread Herbert Xu
On Tue, Nov 27, 2007 at 11:03:41AM +0800, Herbert Xu wrote: On Mon, Nov 26, 2007 at 04:33:31PM +, chas williams - CONTRACTOR wrote: if you are lucky (unlucky?) enough to have shared interrupts, the interrupt handler can be called before the tasklet and lock are ready for use. Patch

Re: [XFRM]: Fix leak of expired xfrm_states

2007-11-26 Thread Herbert Xu
. Thanks a lot Patrick! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Herbert Xu
. That is, if (veth-h_vlan_proto != htons(ETH_P_8021Q) || VLAN_DEV_INFO(dev)-flags VLAN_FLAG_REORDER_HDR) { Otherwise you'll miss AF_PACKET packets when REORDER is off. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: wireless vs. alignment requirements

2007-11-25 Thread Herbert Xu
would be minimised. Since I know next to nothing about the wireless transport layer, one of you experts will need to tell me whether such a prediction could work :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: wireless vs. alignment requirements

2007-11-25 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: wireless vs. alignment requirements

2007-11-25 Thread Herbert Xu
have all packets from stations come in aligned and all response packets from wherever come in as WPS. OK, sounds like you'll just have to fix them up after DMA. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: wireless vs. alignment requirements

2007-11-25 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-25 Thread Herbert Xu
the send checksum, but the receive checksum. He knows that he does not need it. You must be in some other thread because this one started with a patch to disable sender checksums. Oh and please do keep CCs on this list. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: DST_NOHASH flag and IPsec transformers routing tables - need some clarification

2007-11-25 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 6/7] [IPSEC]: Lock state when copying non-atomic fields to user-space

2007-11-25 Thread Herbert Xu
my plate's pretty full already. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
On Sat, Nov 24, 2007 at 09:33:36AM +0100, Johannes Berg wrote: We still require four-byte alignment, no? Not at all. If NET_IP_ALIGN is zero then it won't be four-byte aligned (since the Ethernet header is 14 bytes long). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: ZD1211RW unaligned accesses...

2007-11-24 Thread Herbert Xu
are now bigger (0x394/0x39c/0x3a8 vs. 0x2** earlier). So please try the following patch (instead of the original one) which should fix all the unailgned accesses in do_rx. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
alignment. Luckily all sky2 users have been on x86 so far :) Here's an idea. Put the data of the packet into the page frags where alignment is not an issue but copy the header so that it is aligned. Would that work? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: wireless vs. alignment requirements

2007-11-24 Thread Herbert Xu
to get (e.g., based on what mode you're in) then do the skb_reserve accordingly. It's a good thing these things aren't running at 10Gb :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH][UNIX] Move the unix sock iterators in to proper place

2007-11-23 Thread Herbert Xu
place as my net-2.6.25 tree. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

2007-11-23 Thread Herbert Xu
Järvinen [EMAIL PROTECTED] Hmm, why don't we just get rid of tcp_advance_send_head? Or are you planning to start using it again? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH][IPv6] Correct the comment concerning inetsw6 table

2007-11-23 Thread Herbert Xu
:) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH][UNIX] Move the unix sock iterators in to proper place

2007-11-23 Thread Herbert Xu
they really belong, i.e. closer to proc code under the #ifdef CONFIG_PROC_FS option. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Patch applied. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-23 Thread Herbert Xu
so the high-level needs to protect it by checksumming the pseudo-header. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

2007-11-23 Thread Herbert Xu
functions in tcp.h as well which currently have only a single caller. Please don't undo that work while DaveM is away for a short while :-). Thanks for the explanation! I'll apply this patch. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: wireless vs. alignment requirements

2007-11-23 Thread Herbert Xu
should they show up. Daniel, what's the specific case that you had in mind with this patch? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] add compare_ether_addr_unaligned

2007-11-23 Thread Herbert Xu
regardless of alignment. Signed-off-by: Daniel Drake [EMAIL PROTECTED] Patch applied to net-2.6. Thanks. I presume there will be some follow-on work to use this function? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window data available checks fixed

2007-11-22 Thread Herbert Xu
that be Tcprexmtthresh segments at the current MTU or the probed MTU? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

Re: [PATCH][IRDA] Compilation for CONFIG_INET=n case

2007-11-22 Thread Herbert Xu
Emelyanov [EMAIL PROTECTED] Not too pedantic yet, please keep trying :) Applied to net-2.6. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check (no need to loop)

2007-11-22 Thread Herbert Xu
the other patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [patch 1/4] pfkey: sending an SADB_GET responds with an SADB_GET

2007-11-22 Thread Herbert Xu
PROTECTED] Applied to net-2.6. Thanks Andrew. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [patch 2/4] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static

2007-11-22 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [patch 4/4] Net: sunrpc, remove SPIN_LOCK_UNLOCKED

2007-11-22 Thread Herbert Xu
-off-by: Andrew Morton [EMAIL PROTECTED] Applied. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [patch 3/4] tlan list is subscribers-only

2007-11-22 Thread Herbert Xu
by non-member to a members-only list Signed-off-by: Gabriel Craciunescu [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: [README] away until Dec 3rd

2007-11-22 Thread Herbert Xu
/linux/kernel/git/herbert/net-2.6.25.git/ while Dave is away. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window data available checks fixed

2007-11-22 Thread Herbert Xu
be. Thanks for the explanation! I'll apply both patches to net-2.6. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

Re: RE: is it useful testing __LINK_STATE_RX_SCHED in dev_close()?

2007-11-21 Thread Herbert Xu
. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread Herbert Xu
. Disagree. UDP checksum is mandatory in IPv6. Right, IPv6 doesn't have a header checksum so the UDP checksum must be there. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH 1/2] [LIB]: Introduce struct pcounter

2007-11-21 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread Herbert Xu
is fine, as long as its free. No matter how strong your underlying checksumming is it's not going to protect the IPv6 header is it :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [README] away until Dec 3rd

2007-11-21 Thread Herbert Xu
On Tue, Nov 20, 2007 at 08:29:21PM -0800, David Miller wrote: During this time Herbert Xu (CC:'d) will take care of both the net-2.6 stable tree and the net-2.6.25 devel tree. For this duration please use the net-2.6.25 tree at this location for basing your patches: git://git.kernel.org/pub

Re: Async crypto support in IPsec

2007-11-20 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

<    4   5   6   7   8   9   10   11   12   13   >