On Wed, 5 Aug 2015 15:01:53 +0400
Ivan Mikhaylov wrote:
ping
> * do the redefinition of emac_regs struct from driver structure
> perspective and passing size from actual struct size, not from memory
> area variable which set in dts file.
>
> * passing variable from dts opt
On Wed, 23 Sep 2015 11:05:49 -0700 (PDT)
"David Miller" wrote:
> From: Ivan Mikhaylov
> Date: Wed, 23 Sep 2015 14:42:22 +0400
>
> > Register dump out work preventing with
> > old ethtool + new driver and new ethtool + old driver.
>
> First of al
.
* this commit fixing problem with output of MII sections for new driver
versions.
Signed-off-by: Ivan Mikhaylov
---
ibm_emac.c | 161 ++--
1 file changed, 125 insertions(+), 36 deletions(-)
diff --git a/ibm_emac.c b/ibm_emac.c
index e128e48
On Thu, 24 Sep 2015 22:53:03 -0700 (PDT)
"David Miller" wrote:
> From: Ivan Mikhaylov
> Date: Fri, 25 Sep 2015 08:07:52 +0400
>
> > Ben proposed one, is it eligible?
> > Need I resubmit patch with sign and detailed description?
>
> If I genuinely need to a
tree didn't match the size it assumed.
Using the new version numbers indicates unambiguously that the size of
the MAC register dump is dependent only on the MAC type.
Fixes: 5369c71f7ca2 ("net/ibm/emac: fix size of emac dump memory areas")
Signed-off-by: Ivan Mikhaylov
---
drive
On Fri, 25 Sep 2015 08:15:45 +0400
"Ivan Mikhaylov" wrote:
ping
> * add new version of emac_regs struct from driver structure
> perspective and passing size from actual struct size, not from memory
> area variable which set in dts file.
> * add three types of networ
h this and 5369c71 commit in kernel.
Signed-off-by: Ivan Mikhaylov
---
ibm_emac.c | 101 +++-
1 file changed, 73 insertions(+), 28 deletions(-)
diff --git a/ibm_emac.c b/ibm_emac.c
index e128e48..da6c28e 100644
--- a/ibm_emac.c
+++ b/
* add three types of network chips : emac, emac4, emac4sync
* add emac4sync processing in print_emac_regs
Signed-off-by: Ivan Mikhaylov
---
ibm_emac.c | 56 +---
1 file changed, 45 insertions(+), 11 deletions(-)
diff --git a/ibm_emac.c b
On Wed, 9 Aug 2015 15:10:00 +0400
Ivan Mikhaylov wrote:
>On Wed, 2015-08-05 at 15:01 +0400, Ivan Mikhaylov wrote:
>> * do the redefinition of emac_regs struct from driver structure
>> perspective and passing size from actual struct size, not from memory
>> area variable
On Wed, 9 Aug 2015 15:10:00 +0400
Ivan Mikhaylov wrote:
>On Wed, 2015-08-05 at 15:01 +0400, Ivan Mikhaylov wrote:
>> * do the redefinition of emac_regs struct from driver structure
>> perspective and passing size from actual struct size, not from memory
>> area variable
Register dump out work preventing with
old ethtool + new driver and new ethtool + old driver.
---
drivers/net/ethernet/ibm/emac/core.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/core.h
b/drivers/net/ethernet/ibm/emac/core.h
index 2
* add new version of emac_regs struct from driver structure perspective
and passing size from actual struct size, not from memory area variable
which set in dts file.
* add three types of network chips for new struct : emac, emac4, emac4sync.
* add emac4sync processing in print_emac_regs.
* thi
On Wed, 3 Jun 2015 18:28:37 +0400
Ivan Mikhaylov wrote:
> On Mon, 1 Jun 2015 22:11:00 +0400
> Ben Hutchings wrote:
>
> >On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote:
> >> On Mon, 1 June 2015 12:57 +0400
> >> Ben Hutchings wrote:
> >>
>
Fix in send of emac regs dump to ethtool which
causing in wrong data interpretation on ethtool
layer for MII and EMAC.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/core.c | 16 ++--
drivers/net/ethernet/ibm/emac/core.h |7 ++-
2 files changed, 8
In ibm_emac.c in ethtool size of emac structure which passing through to driver
is nailed down and not correlating with current emac_regs structure.
Signed-off-by: Ivan Mikhaylov
---
ibm_emac.c | 143 +---
1 file changed, 107 insertions
On Mon, 1 June 2015 12:57 +0400
Ben Hutchings wrote:
>On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote:
>> In ibm_emac.c in ethtool size of emac structure which passing through
>> to driver is nailed down and not correlating with current emac_regs
>> structure.
>&
On Mon, 1 Jun 2015 22:11:00 +0400
Ben Hutchings wrote:
>On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote:
>> On Mon, 1 June 2015 12:57 +0400
>> Ben Hutchings wrote:
>>
>> >On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote:
>> >> In ib
/MDIO mode
with 19 bit and write operation is set into 18 bit which is mode selection,
not a write operation. To correlate write with read we set it into 20 bit.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/emac.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
di
emac4syn chips has availability to use 8192 rx/tx fifo buffer sizes,
in current state if we set it up in dts 8192 as example, we will get
only 2048 which may impact on network speed.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/core.c |6 ++
drivers/net/ethernet/ibm
>Something looks wrong here?! The commit message talks about bit 18, 19 and 20.
>However, 0x0800, 0x1000, 0x2000 and are like bit 11, 12 and 13? Furthermore,
>what about the EMAC_STACR_STAC_MASK? shouldn't it be 0x1800 now (or delete it
>since it doesn't look like it's used anywhere?).
Christian, n
/MDIO mode
with 19 bit and write operation is set into 18 bit which is mode selection,
not a write operation. To correlate write with read we set it into 20 bit.
All those bit operations are MSB 0 based.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/emac.h |2 +-
1 files
> So if someone tries to #define EMAC_STACR_STAC_WRITE BIT(18) it would be
> 0x4 instead. This is where the confusion is coming from. Can you please
> at least mention this somewhere that all the bits in the commit message are
> in "MSB 0" format? It's confusing enough as it is ;).
Yeap, sure,
emac4syn chips has availability to use 8192 rx/tx fifo buffer sizes,
in current state if we set it up in dts 8192 as example, we will get
only 2048 which may impact on network speed.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/core.c |6 ++
drivers/net/ethernet/ibm
/MDIO mode
with 19 bit and write operation is set into 18 bit which is mode selection,
not a write operation. To correlate write with read we set it into 20 bit.
All those bit operations are MSB 0 based.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/emac.h |2 +-
1 files
add realization for mac address set and remove dummy callback.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/core.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/core.c
b/drivers/net/ethernet
for preventing race conditions within ioctl calls.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/ibm/emac/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/ibm/emac/core.c
b/drivers/net/ethernet/ibm/emac/core.c
index 2dfc603..7af09cb 100644
--- a
e properly?
Ivan Mikhaylov (2):
net: phy: micrel: add LED control on KSZ9131
dt-bindings: net: phy: micrel: add LED mode behavior and select
properties
.../devicetree/bindings/net/micrel.txt| 7 ++
drivers/net/phy/micrel.c | 69 ++-
2 files c
Add the possibility to read the LED configuration via DTS properties from
KSZ9131 PHY node. Add the new proprties and handle for them:
micrel,led-mode-behavior
micrel,led-mode-select
Signed-off-by: Ivan Mikhaylov
---
drivers/net/phy/micrel.c | 69 +++-
1 file
Add LED mode behavior and LED mode select properties which can be used
in KSZ9131 PHY.
Signed-off-by: Ivan Mikhaylov
---
Documentation/devicetree/bindings/net/micrel.txt | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/micrel.txt
b/Documentation
#address-cells = <1>;
#size-cells = <0>;
phy: ethernet-phy@0 {
compatible = "ethernet-phy-id.";
reg = <0>;
};
};
};
The patch fixes it and gets possible PHYs a
phy-handle can't be handled well for ast2400/2500 which has an embedded
MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
PHYs from mdio child node with of_mdiobus_register.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c
On Wed, 2020-10-14 at 05:23 +, Joel Stanley wrote:
> Hi Ivan,
>
> On Tue, 13 Oct 2020 at 12:38, Ivan Mikhaylov wrote:
> > phy-handle can't be handled well for ast2400/2500 which has an embedded
> > MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and ini
#address-cells = <1>;
#size-cells = <0>;
phy: ethernet-phy@0 {
compatible = "ethernet-phy-id.";
reg = <0>;
};
};
};
The patch fixes it and gets possible PHYs a
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and
ftgmac100_mii_probe.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c | 92
1 file changed, 47 insertions(+), 45 deletions(-)
diff --git a/drivers/net/ethernet/faraday
phy-handle can't be handled well for ast2400/2500 which has an embedded
MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
PHYs from mdio child node with of_mdiobus_register.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c
phy-handle can't be handled well for ast2400/2500 which has an embedded
MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
PHYs from mdio child node with of_mdiobus_register.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and
ftgmac100_mii_probe.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c | 104 ---
1 file changed, 54 insertions(+), 50 deletions(-)
diff --git a/drivers/net/ethernet/faraday
unneeded mdio_np checks.
Changes from v1:
1. split one patch into two.
Ivan Mikhaylov (2):
net: ftgmac100: move phy connect out from ftgmac100_setup_mdio
net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500
drivers/net/ethernet/faraday/ftgmac100.c | 122 +--
On Tue, 2020-10-27 at 19:23 +0100, Andrew Lunn wrote:
> On Tue, Oct 27, 2020 at 05:49:24PM +0300, Ivan Mikhaylov wrote:
> > phy-handle can't be handled well for ast2400/2500 which has an embedded
> > MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
>
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and
ftgmac100_mii_probe.
Reviewed-by: Andrew Lunn
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c | 104 ---
1 file changed, 54 insertions(+), 50 deletions(-)
diff --git a/drivers
t label.
3. split ftgmac100_destroy_mdio into ftgmac100_phy_disconnect and
ftgmac100_destroy_mdio.
4. remove unneeded mdio_np checks.
Changes from v1:
1. split one patch into two.
Ivan Mikhaylov (3):
net: ftgmac100: move phy connect out from ftgmac100_setup_mdio
net: ftgmac100: add handling of md
Add the phy-handle and MDIO description and add the example with
PHY and MDIO nodes.
Signed-off-by: Ivan Mikhaylov
---
.../devicetree/bindings/net/ftgmac100.txt | 25 +++
1 file changed, 25 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt
b
phy-handle can't be handled well for ast2400/2500 which has an embedded
MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
PHYs from mdio child node with of_mdiobus_register.
Signed-off-by: Ivan Mikhaylov
---
drivers/net/ethernet/faraday/ftgmac100.c
43 matches
Mail list logo
