Re: [PATCH] Fix infinite loop on dev_mc_unsync()

On Fri, 2007-11-09 at 13:51 -0500, Luis R. Rodriguez wrote: > While reviewing net/core/dev_mcast.c I found what I think is an > infinite loop on dev_mc_unsync(). This fixes it. We make use of > this guy on mac80211 in ieee80211_stop(). This is untested. > > Signed-off-by: Luis R. Rodriguez <[EMAI

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

On Sat, 2007-11-10 at 00:12 +0100, Patrick McHardy wrote: > This may cause a use-after-free since __dev_addr_delete frees the address > when all references are gone. How about a comment then? Perhaps: diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c index ae35405..63576aa 100644 --- a/ne

[PATCH] - in.h - IP4_ADDR

Add inline functions to in.h that make the IP4 address tests a bit easier to read and also add some type safety. gcc optimizes IP4_ADDR to a constant (O2 or Os) Signed-off-by: Joe Perches <[EMAIL PROTECTED] --- include/linux/in.h | 75 ---

[PATCH] - drivers/net/ppp_* - remove ptr comparisons to 0

fix sparse warnings "Using plain integer as NULL pointer" Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/ppp_async.c | 34 ++-- drivers/net/ppp_generic.c | 126 ++-- drivers/net/ppp_synctty.c | 27 +++

Re: [PATCH] - in.h - IP4_ADDR

On Mon, 2007-11-12 at 21:28 -0800, David Miller wrote: > I have no problems with this, but I'd like to add it along > with subsequent patches that use the new routines and > also I'd like to defer this to net-2.6.25 so please resubmit > this later. I've since changed the functions in my tree to:

[PATCH] - [2/15] - remove defconfig ptr comparisons to 0 - drivers/net

Remove defconfig ptr comparison to 0 Remove sparse warning: Using plain integer as NULL pointer Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index da767d3..cec3cb4 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -

[PATCH] - [15/15] - remove defconfig ptr comparisons to 0 - net/sunrpc

Remove defconfig ptr comparison to 0 Remove sparse warning: Using plain integer as NULL pointer Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 76be83e..1600df2 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -157,7

[PATCH net-2.6.25 3/4] net/ipv4 - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and maybe some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/arp.c |2 +- ne

[PATCH net-2.6.25 4/4] net/netfilter - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and maybe some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/netfilter/xt_pkttype.c |2 +- 1

[PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and maybe some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/in.h

[PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and maybe some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> - To unsubscribe from this list: send th

[PATCH net-2.6.25 2/4] net/core - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and maybe some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/core/netpoll.c |2 +- net/core/pk

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

On Wed, 2007-11-14 at 08:53 -0800, David Stevens wrote: > Maybe I'm more used to hex, but I personally don't think those are > more readable. It replaces 1-line macroes with 4-line functions, and > I think more vgrepping to pick out the relevant constant data. The rfcs generally use decimal octet

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

Sorry, evolution died sending my mail and I didn't fully read the "recovered" mail before hitting send. Here's a more readable one. - On Wed, 2007-11-14 at 08:53 -0800, David Stevens wrote: > Maybe I'm more used to hex, but I personally don't think those are > more readable. It replaces

Re: [PATCH 2/7] CAN: Add PF_CAN core module

On Thu, 2007-11-15 at 08:40 +0100, Oliver Hartkopp wrote: > Stephen Hemminger wrote: > >> +#ifdef CONFIG_CAN_DEBUG_CORE > >> +extern void can_debug_skb(struct sk_buff *skb); > >> +extern void can_debug_cframe(const char *msg, struct can_frame *cframe); > >> +#define DBG(fmt, args...) (DBG_VAR & 1

[PATCH 36/59] drivers/net: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/3c507.c |4 ++-- drivers/net/amd8111e.c |4 ++-- drivers/net/at1700.c|2 +- drivers/net/pppol2tp.c |2 +- drivers/net/qla3xxx.c |2 +- drivers/net/rrunner.c |2 +- drivers/net/s2io.c

[PATCH 34/59] drivers/net/wan: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/wan/wanxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index 8e320b7..ad8c865 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/w

[PATCH 35/59] drivers/net/wireless: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/wireless/b43/phy.c |2 +- drivers/net/wireless/b43legacy/phy.c |2 +- drivers/net/wireless/bcm43xx/bcm43xx_phy.c |2 +- drivers/net/wireless/libertas/wext.c |2 +- drivers/net/wi

[PATCH 31/59] drivers/net/ixgb: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe_common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c index 512e3b2..b7e50bc 100644 --- a/drivers/net/ixgbe/ixgbe_co

[PATCH 29/59] drivers/net/chelsio: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c index 2dbf8dc..3eca4e3 100644 --- a/drivers/net/chelsio/cxgb2.c +++ b/drive

[PATCH 30/59] drivers/net/cxgb3: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_offload.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_offload.c b/drivers/net/cxgb3/cxgb3_offload.c index bd25421..7086f76 100644 --- a/drivers/net

[PATCH 32/59] drivers/net/netxen: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_hw.c |2 +- drivers/net/netxen/netxen_nic_init.c |4 ++-- drivers/net/netxen/netxen_nic_main.c |6 +++--- drivers/net/netxen/netxen_nic_niu.c |4 ++-- 4 files changed, 8 insertions(+), 8 del

[PATCH 33/59] drivers/net/sk98lin: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skgepnmi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sk98lin/skgepnmi.c b/drivers/net/sk98lin/skgepnmi.c index b36dd9a..678659f 100644 --- a/drivers/net/sk98lin/skgepnmi.c

[PATCH 50/59] net/bridge: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/bridge/netfilter/ebt_among.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/netfilter/ebt_among.c b/net/bridge/netfilter/ebt_among.c index 392d877..6436d30 100644 --- a/net/bridge/netfilter/ebt_a

[PATCH 51/59] net/dccp: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/dccp/ccids/lib/loss_interval.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dccp/ccids/lib/loss_interval.c b/net/dccp/ccids/lib/loss_interval.c index 40ad428..d26b88d 100644 --- a/net/dccp/cci

[PATCH 53/59] net/ipv6: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 1bd8d81..567664e 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -967,7 +967,7

[PATCH 55/59] net/sctp: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/sctp/sm_statefuns.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 5ebbe80..b8bbb96 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_state

[PATCH 56/59] net/sunrpc: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/sunrpc/auth_gss/auth_gss.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 53995af..22906b8 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++

[PATCH 54/59] net/irda: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/irda/iriap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/iriap.c b/net/irda/iriap.c index dc5e34a..a86a5d8 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c @@ -928,7 +928,7 @

[PATCH 52/59] net/ipv4: Add missing "space"

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/ipvs/ip_vs_core.c |2 +- net/ipv4/netfilter/iptable_raw.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c index 20c884a..8fba202 100644

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

On Mon, 2007-11-19 at 21:46 -0800, David Miller wrote: > I would also change the names, it's a better idea to prefix the > names with a namespace for the stuff being operated on, therefore > I'd prefer names like "ipv4_is_loopback()" etc. I used: +static inline bool is_ip4_loopback(__be32 addr)

[PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> - To unsubscribe from this list: send th

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: > On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: > > Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET > > macros to inline functions ipv4_is_(__be32 addr) > > Adds some type safety and arguably so

[PATCH net-2.6.25 4/4] net/netfilter - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/netfilter/xt_pkttype.c |2

[PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/in.h

[PATCH net-2.6.25 2/4] net/core - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/core/netpoll.c |2 +- net/core/pk

[PATCH net-2.6.25 3/4] net/ipv4 - Convert IP4 address class macros to inline functions

Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/arp.c |2 +- ne

Re: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller

On Tue, 2007-11-27 at 22:09 -0800, Stephen Hemminger wrote: > ERROR: Macros with multiple statements should be enclosed in a do - while loop > #21846: FILE: drivers/net/sfc/net_driver.h:1096: > + for (_channel = &_efx->channel[0]; \ > + _channel < &_efx->ch

Re: [NETLINK]: af_netlink.c checkpatch cleanups

On Tue, 2007-12-04 at 09:07 +0100, Patrick McHardy wrote: > [NETLINK]: af_netlink.c checkpatch cleanups > -static __inline__ void > +static inline void > netlink_lock_table(void) > { > /* read_lock() synchronizes us to netlink_table_grab */ > @@ -208,14 +208,15 @@ netlink_lock_table(void) >

Re: Pull request for 'ipg' branch

On Tue, 2007-12-04 at 22:45 +0100, Francois Romieu wrote: > diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c > index dbd23bb..f736c35 100644 > --- a/drivers/net/ipg.c > +++ b/drivers/net/ipg.c > -MODULE_DESCRIPTION("IC Plus IP1000 Gigabit Ethernet Adapter Linux Driver " > -DrvVer)

Re: TCP event tracking via netlink...

> it occurred to me that we might want to do something > like a state change event generator. This could be a basis for an interesting TCP performance tester. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] Reduce stack used by lib/hexdump.c

hex filename 1142 0 01142 476 lib/hexdump.o size after: textdata bss dec hex filename 823 0 0 823 337 lib/hexdump.o Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/kernel.h | 13 +-

Re: net-2.6.25 being rebased...

On Tue, 2007-12-11 at 11:56 -0800, David Miller wrote: > The rebase of net-2.6.25 is complete I have an earlier unmodified git repository of net-2.6.25. Does anyone know the appropriate git commands to resync to the rebased content? $ git branch * master $ git-pull [...] Automatic merge failed; f

Re: net-2.6.25 being rebased...

On Tue, 2007-12-11 at 19:09 -0200, Arnaldo Carvalho de Melo wrote: > git-clone --reference linux-2.6 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25 That works well. Just ~3MB in objects downloaded. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

[PATCH net-2.6.25 7/8] drivers/infiniband: Use ipv4_is_

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/infiniband/core/addr.c |4 ++-- drivers/infiniband/core/cma.c |5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 5381c80..0802b79

[PATCH net-2.6.25 4/8] net/ipv4: Use ipv4_is_

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/arp.c |2 +- net/ipv4/datagram.c |2 +- net/ipv4/devinet.c |4 +- net/ipv4/fib_frontend.c |6 ++-- net/ipv4/igmp.c | 12 +- net/ipv4/ip_gre.c | 23 +++

[PATCH net-2.6.25 6/8] sctp: Use ipv4_is_

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/net/sctp/constants.h | 36 ++-- net/sctp/protocol.c | 12 +++- 2 files changed, 13 insertions(+), 35 deletions(-) diff --git a/include/net/sctp/constants.h b/include/ne

[PATCH net-2.6.25 2/8] include/net: Use ipv4_is_

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/net/addrconf.h | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/net/addrconf.h b/include/net/addrconf.h index c56827d..1c3a560 100644 --- a/include/net/addrconf.h +++ b/include/net/addr

[PATCH net-2.6.25 3/8] net/core: Use ipv4_is_

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/core/netpoll.c |3 ++- net/core/pktgen.c |8 +--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index b1d5acd..6faa128 100644 --- a/net/core/netpoll.c +++ b/ne

[PATCH net-2.6.25 1/8] Create ipv4_is_(__be32 addr) functions

macros Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/in.h | 87 1 files changed, 74 insertions(+), 13 deletions(-) diff --git a/include/linux/in.h b/include/linux/in.h index a8f00ca..f8d6073 100644 --- a/include/linu

[PATCH net-2.6.25 5/8] net/netfilter: Use ipv4_is_

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/netfilter/xt_pkttype.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/xt_pkttype.c b/net/netfilter/xt_pkttype.c index c598bbe..2762449 100644 --- a/net/netfilter/xt_pkttype.c +++ b/net/net

[PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/in.h | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/include/linux/in.h b/include/linux/in.h index f8d6073..27d8a5a 100644 --- a/include/linux/in.h +++ b/include/linux/in.h @@ -272,12

[PATCH 04/11] drivers/net/mac89x0.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/mac89x0.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mac89x0.c b/drivers/net/mac89x0.c index a19b595..45b56ca 100644 --- a/drivers/net/mac89x0.c +++ b/drivers/net/mac89x0.c @@ -

[PATCH 09/11] drivers/net/tg3.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/tg3.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4942f7d..eea7da9 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -12351,9 +12

[PATCH 08/11] drivers/net/sunvnet.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/sunvnet.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/sunvnet.c b/drivers/net/sunvnet.c index ff1028a..4a0035f 100644 --- a/drivers/net/sunvnet.c +++ b/drivers/net/sun

[PATCH 06/11] drivers/net/pcnet32.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/pcnet32.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index ff92aca..87edeb6 100644 --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.c @@ -

[PATCH 03/11] drivers/net/mac8390.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/mac8390.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c index 9e70074..4eccebb 100644 --- a/drivers/net/mac8390.c +++ b/drivers/net/mac

[PATCH 01/11] drivers/net/ax88796.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/ax88796.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c index 7495a9e..107c11f 100644 --- a/drivers/net/ax88796.c +++ b/drivers/net/ax8

[PATCH 07/11] drivers/net/smc911x.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/smc911x.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 76cc1d3..f503b73 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -2

[PATCH 05/11] drivers/net/niu.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/niu.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/niu.c b/drivers/net/niu.c index abfc61c..8a0f8f8 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -7392,12 +7392,10 @@

[PATCH 10/11] drivers/net/tulip/de4x5.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/tulip/de4x5.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c index 41f34bb..288f994 100644 --- a/drivers/net/tulip/de4x5.c +++ b/drivers/net

[PATCH 02/11] drivers/net/hplance.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/hplance.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/hplance.c b/drivers/net/hplance.c index be6e5bc..2748b47 100644 --- a/drivers/net/hplance.c +++ b/drivers/net/hpl

[PATCH 11/11] drivers/net/usb/catc.c: Use print_mac

Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/usb/catc.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 76752d8..e20db50 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

On Fri, 2007-12-14 at 15:35 -0800, Auke Kok wrote: > + printk(KERN_ERR "/*/\n"); > + printk(KERN_ERR "Current EEPROM: 0x%04x\nCalculated: 0x%04x\n", > +csum_old, csum_new); Multiline printks need a KERN_ after every newline. Perhaps: printk(KE

[PATCH] pktgen - define and use pktgen_dbg,err,warn,info

Similar usage to ndev_ and dev_ printk macros Adds KERN_ indicators to all printks. Correct a spelling error Format u64 subtraction to %llu and (unsigned long long) Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/net/core/pktgen.c b/net/core/pktgen.c index b92a322..5a94cfc

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Wed, 18 Jul 2007 15:14:13 -0700 > > > -#define VERSION "pktgen v2.68: Packet Generator for packet performance > > testing.\n" > > +#define PKTGEN_N

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

On Mon, 2007-07-30 at 16:05 -0700, David Miller wrote: > I still don't know about this patch. Instead of the simple > transformation: > > - printk(foo); > + printk(KERN_INFO foo); > > we get this new macro, and the lines changes to use that macro. Actually, I agree. Many local macros c

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

On Sun, 2007-08-12 at 23:36 -0700, David Miller wrote: > Ok, 374 patches is just rediculious. > > So many patches eats up an enormous amount of mailing list resources, > and for these patches in particular there are few reasons to split > them up at all. The fact that the split up landed you at 3

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

On Mon, 2007-08-13 at 00:18 -0700, David Miller wrote: > The posting limit is 400K for linux-kernel, netdev, and one > or two of the other lists. Apologies. Posted it twice over 2 days. Anyway, I supposed you could kill the spool entries if you want. cheers, Joe - To unsubscribe from this list

Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

I like the ndev_printk idea. I think a ndev_ printks should take a const netdev* as the first argument. Also, better for the non-debug use of ndev_dbg is to have a static inline function so printf args are verified. For instance, dev_dbg does: static inline int __attribute__ ((format (printf, 2

Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

On Mon, 2007-06-11 at 14:37 -0700, Auke Kok wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 3a70f55..d185f41 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -540,6 +540,8 @@ struct net_device > struct device dev; >

Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

On Mon, 2007-06-11 at 15:01 -0700, Kok, Auke wrote: > > msg_enable is more frequently defined in drivers/net as u32 not int. > yes, we're only using the bottom 15 bits anyway, but the net_device struct > consistently uses 'int' style members, leaving it up to the compiler to pick > an > appropri

Re: [PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote: > +#define ndev_err(netdev, level, format, arg...) \ > + do { \ > + struct net_device *__nd = (netdev); \ > + if ((__nd)->msg_enable & NETIF_MSG_##level) \ > + printk(KERN_ERR "%s: %s: " format, (__nd

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

On Mon, 2007-08-13 at 11:49 +0100, Alan Cox wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 90c1b81..ac2226b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -697,6 +697,7 @@ ARPD SUPPORT > > P: Jonathan Layes > > L: netdev@vger.kernel.org > > S: Maintained > > +F: net/ipv4/

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

On Mon, 2007-08-13 at 17:35 +0100, Alan Cox wrote: > I wouldn't add a pattern for this. Back to:ARPD SUPPORT P: Jonathan Layes L: netdev@vger.kernel.org S: Maintained > Actually I think the entire thing is a > bad idea but thats another matter. Of course it's not an end-all soluti

Re: [PATCH] [459/2many] MAINTAINERS - SPIDERNET NETWORK DRIVER for CELL

On Mon, 2007-08-13 at 10:45 -0500, Linas Vepstas wrote: > Note quite right. spider-pic is not part of spider_net. SPIDERNET NETWORK DRIVER for CELL P: Linas Vepstas M: [EMAIL PROTECTED] L: netdev@vger.kernel.org S: Supported F: Documentation/networking/spider_net.txt F:

Re: drivers/infiniband/mlx/mad.c misplaced ;

On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> > > diff --git a/drivers/infiniband/hw/mlx4/mad.c > b/drivers/infiniband/hw/mlx4/mad.c > index 3330917..0ed02b7 100644 > --- a/drivers/infiniband/hw/mlx4/mad.c > +++ b/drivers/infiniband/hw/mlx4/m

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Wed, 2007-08-22 at 20:46 +0200, Johannes Berg wrote: > The two different wireless code bases both define macros to ease > printing MAC addresses: There are also several different uses of the equivalent of printk("%02x",addr[0]) for (i=1; i<6; i++) printk(":%02x"

[PATCH] Prefix each line of multiline printk(KERN_ "foo\nbar") with KERN_

Corrected printk calls with multiple output lines which did not correctly preface each line with KERN_ Fixed uses of some single lines with too many KERN_ Please pull from: git://repo.or.cz/linux-2.6/trivial-mods.git pr_newlines Signed-off-by: Joe Perches <[EMAIL PROTECTED]> arch/arm/

Re: [PATCH] Prefix each line of multiline printk(KERN_ "foo\nbar") with KERN_

On Sun, 2007-08-26 at 10:30 +0200, Geert Uytterhoeven wrote: > On Fri, 24 Aug 2007, Joe Perches wrote: > > Corrected printk calls with multiple output lines which > > did not correctly preface each line with KERN_ > > Fixed uses of some single lines with too many KERN_ >

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-08-27 at 12:54 +0200, Johannes Berg wrote: > Thanks for this patch though, I'd have done it otherwise. I had it, it was just a s/EUI48/MAC/ and copy/paste thing. There are also the arch, drivers/[^net], and net directories that have a few of these. The patch also added the missing "

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote: > From: Johannes Berg <[EMAIL PROTECTED]> > Date: Mon, 27 Aug 2007 12:54:09 +0200 > > #define MAC_FMT "%s" > > #define MAC_ARG(a) ({char __buf[18]; print_mac(a, __buf); __buf;}) > I don't think this works. $ cat test_fmt.c #include #include

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote: > there are better approaches to this, > how about just calling: > > print_mac(dev->dev_addr); > > Sure, we'll have to split up printk() calls, but in the end it's > likely still smaller and better. And I think it's much cleaner > than

Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

On Tue, 2007-08-28 at 00:01 +, Linux Kernel Mailing List wrote: > +NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK) > +P: Paul Moore > +M: [EMAIL PROTECTED] > +L: netdev@vger.kernel.org > +S: Maintained > + Aren't there now 2 subsystems in MAINTAINERS for the same thing?

Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

On Tue, 2007-08-28 at 08:46 -0400, Paul Moore wrote: > If having both a labeled networking and NetLabel maintainer entry is a > problem then how about the patch below? I don't think it is. > -NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK) > +NETWORKING [LABELED] (NetLabel/CIPSO, L

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-08-27 at 14:37 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > > My original patch had the equivalent of > > char* print_mac(char* buf, const char* addr) { > > sprintf(buf,"%02x:...", addr[0]...) > >

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote: > > Option 2: > > DECLARE_MAC_BUF(mac); > > printk("%s", print_mac(mac, dev->dev_addr)); > Between them, 1 and 2 seem roughly the same, but I'm slightly leaning > towards 2. 2 it is then. I thought you said Johannes' patch was reverte

Re: net-2.6.24 rebased

On Wed, 2007-08-29 at 16:41 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Wed, 29 Aug 2007 16:34:00 -0700 > > > On Tue, 2007-08-28 at 17:59 -0700, David Miller wrote: > > > I pushed this fix into net-2.6.24 just now, thanks again. >

Re: net-2.6.24 rebased

On Wed, 2007-08-29 at 16:47 -0700, Joe Perches wrote: > On Wed, 2007-08-29 at 16:41 -0700, David Miller wrote: > > From: Joe Perches <[EMAIL PROTECTED]> > > Date: Wed, 29 Aug 2007 16:34:00 -0700 > > > > > On Tue, 2007-08-28 at 17:59 -0700, David Miller wrote

Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote: > Ok, I must admit I didn't check with sparse since it seemed pointless > - we usually never cast void pointers to other pointer types, > specifically because the C language nicely guarantees that the right > thing will happen without the cast.

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > > Option 2: > > DECLARE_MAC_BUF(mac); > > printk("%s", print_mac(mac, dev->dev_addr)); > I'm slightly leaning towards 2. Here are the patches

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Sat, 2007-09-01 at 00:21 +0200, Johannes Berg wrote: > On Fri, 2007-08-31 at 15:16 -0700, Joe Perches wrote: > > please pull from: > > git pull git://repo.or.cz/linux-2.6/trivial-mods.git net-2.6.24-print_mac > got a gitweb for that somewhere? Does this work for you? http://

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Sat, 2007-09-01 at 00:32 +0200, Johannes Berg wrote: > I think you got a bit too trigger-happy: > p += sprintf(p, "key[%d] alg=CCMP key_set=%d " > -"tx_pn=%02x%02x%02x%02x%02x%02x " > -"rx_pn=%02x%02x%02x%02x%02x%02x " > +"tx_pn

Re: [PATCH] 3c59x: sparse warning fix

On Wed, 2007-09-05 at 15:23 +0100, Stephen Hemminger wrote: > --- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 > +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 > @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc >

RE: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

On Wed, 2007-09-12 at 11:44 -0700, Medve Emilian-EMMEDVE1 wrote: > First, this patch doesn't have the trailing "\n" problem that one had. I expect all the kernel logging functions to be overhauled eventually. I'd prefer a mechanism that somehow supports identifying complete messages. I think the

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

: > git pull git://repo.or.cz/linux-2.6/trivial-mods.git net-2.6.24-print_mac > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > -- > > include/linux/if_ether.h |7 +++ > include/net/ieee80211.h |5 - > include/net/mac80211.h |4 >

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-09-17 at 19:05 -0700, David Miller wrote: > Anyways, it would indeed help if you could rebase the patch > against net-2.6.24 It would save me a ton of time. I'll rebase it tomorrow against whatever's in your current net-2.6.24. cheers, Joe - To unsubscribe from this list: send the

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-09-17 at 19:14 -0700, Joe Perches wrote: > On Mon, 2007-09-17 at 19:05 -0700, David Miller wrote: > > Anyways, it would indeed help if you could rebase the patch > > against net-2.6.24 It would save me a ton of time. > > I'll rebase it tomorrow against wh

net-2.6.24 - build failure

allyesconfig CC drivers/net/wireless/p54pci.o LD drivers/net/wireless/built-in.o drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file': drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of `tsf_read_file' drivers/net/wireless/b43/built-in.o:net-2.6.24

[PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

In the same vein as print_mac, the implementations introduce declaration macros: DECLARE_IP_BUF(var) DECLARE_IPV6_BUF(var) and functions: print_ip print_ipv6 print_ipv6_nofmt IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr; print_ip(ipb

  1   2   3   4   5   6   7   8   9   10   >