Re: [patch net-next 16/19] lib: Introduce priority array area manager

On Thu, 2017-02-02 at 16:12 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > This introduces a infrastructure for management of linear priority > areas. Priority order in an array matters, however order of items inside > a priority group does not matter. > > As an initial

Re: [PATCH v2 net-next] net: ethtool: convert large order kmalloc allocations to vzalloc

On Mon, 2017-01-30 at 19:41 -0800, Alexei Starovoitov wrote: > On 1/30/17 7:28 PM, Joe Perches wrote: > > On Mon, 2017-01-30 at 18:25 -0800, Alexei Starovoitov wrote: > > > under memory pressure 'ethtool -S' command may warn: > > > [ 2374.385195] ethtool: page alloca

Re: [PATCH v2 net-next] net: ethtool: convert large order kmalloc allocations to vzalloc

On Mon, 2017-01-30 at 18:25 -0800, Alexei Starovoitov wrote: > under memory pressure 'ethtool -S' command may warn: > [ 2374.385195] ethtool: page allocation failure: order:4, mode:0x242c0c0 > [ 2374.405573] CPU: 12 PID: 40211 Comm: ethtool Not tainted > [ 2374.423071] Call Trace: > [ 2374.423076]

Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

On Fri, 2017-01-27 at 22:00 +0100, Johannes Berg wrote: > On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > > This fixes the checkpatch.pl warnings: > > * Macros should not use a trailing semicolon. > > * Spaces required around that '='. > > * Symbolic permissions 'S_IRUGO' are not

Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > This fixes the checkpatch.pl warnings: > * Macros should not use a trailing semicolon. > * Spaces required around that '='. > * Symbolic permissions 'S_IRUGO' are not preferred. OK > * Macro argument reuse 'buflen' - possible

Re: [PATCH 0/6 v3] kvmalloc

On Thu, 2017-01-26 at 11:32 +0100, Michal Hocko wrote: > So I have folded the following to the patch 1. It is in line with > kvmalloc and hopefully at least tell more than the current code. [] > diff --git a/mm/vmalloc.c b/mm/vmalloc.c [] > @@ -1741,6 +1741,13 @@ void

Re: [PATCH] cxgbit: use T6 specific macro to set force bit

On Wed, 2017-01-25 at 12:08 +0530, Varun Prakash wrote: > On Wed, Jan 25, 2017 at 02:41:40AM +0530, Joe Perches wrote: > > On Tue, 2017-01-24 at 17:07 +0530, Varun Prakash wrote: > > > For T6 adapters use T6 specific macro to set > > > force bit. > > > > []

Re: [PATCH] cxgbit: use T6 specific macro to set force bit

On Tue, 2017-01-24 at 17:07 +0530, Varun Prakash wrote: > For T6 adapters use T6 specific macro to set > force bit. [] > diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h > b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h [] > @@ -1349,6 +1349,10 @@ struct cpl_tx_data { > #define TX_FORCE_S

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

On Tue, 2017-01-24 at 05:18 +, Valo, Kalle wrote: > Joe Perches <j...@perches.com> writes: > > > On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: > > > use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). > > > > [] >

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: > use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). [] > diff --git a/drivers/net/wireless/ath/ath10k/pci.c > b/drivers/net/wireless/ath/ath10k/pci.c [] > @@ -896,7 +896,7 @@ static int

Re: [PATCH] net: ethernet: aquantia: fix alloc_cast.cocci warnings

On Thu, 2017-01-19 at 17:09 +0800, kbuild test robot wrote: > drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting > value returned by memory allocation function to (struct aq_ring_buff_s *) is > useless. > > Remove casting the values returned by memory allocation

Re: net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

On Sun, 2017-01-15 at 19:17 +0100, Heiner Kallweit wrote: > Don't use netdev_info and friends before the net_device is registered. > This avoids ugly messages like > "meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized): > Enable RX Mitigation via HW Watchdog Timer" It'd be nice

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

On Thu, 2017-01-12 at 22:57 -0800, David VomLehn wrote: > On 01/12/2017 09:59 PM, Joe Perches wrote: > > On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: > > > On 01/12/2017 09:06 PM, Joe Perches wrote: > > > > On Thu, 2017-01-12 at 21:02 -0800, Alexander L

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: > On 01/12/2017 09:06 PM, Joe Perches wrote: > > On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > > > From: David VomLehn <voml...@texas.net> > > > > > > Patches to create the make an

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > From: David VomLehn > > Patches to create the make and configuration files. This patch should _really_ be the last in the series not the first.

[PATCH] tilepro: Fix non-void return from void function

commit bc1f44709cf2 ("net: make ndo_get_stats64 a void function") mistakenly used a return value for this void conversion. Fix it. Signed-off-by: Joe Perches <j...@perches.com> cc: stephen hemminger <step...@networkplumber.org> --- drivers/net/ethernet/tile/tilepro.c | 4 -

Re: [net-next PATCH 1/3] Revert "icmp: avoid allocating large struct on stack"

On Tue, 2017-01-10 at 13:12 -0500, David Miller wrote: > From: Cong Wang > Date: Tue, 10 Jan 2017 10:06:01 -0800 > > > On Mon, Jan 9, 2017 at 10:52 AM, David Miller wrote: > >> From: Eric Dumazet > >> Date: Mon, 09 Jan 2017

Re: [net-next PATCH 1/3] Revert "icmp: avoid allocating large struct on stack"

On Mon, 2017-01-09 at 10:07 -0800, Eric Dumazet wrote: > On Mon, 2017-01-09 at 09:59 -0800, Cong Wang wrote: [] > > Facepalm... [] > We are in 2017. Whatever was said in 2013 is irrelevant. Unless you morph into the PEOTUS, as a general statement, this is untrue.

Re: [RFC PATCH] intel: Use upper_32_bits and lower_32_bits

On Mon, 2017-01-09 at 12:55 +, David Laight wrote: > From: Joe Perches > > Sent: 07 January 2017 18:33 > > Shifting and masking various types can be made a bit > > simpler to read by using the available kernel macros. > > ... > > - ew32(TDBAH, (t

[RFC PATCH] intel: Use upper_32_bits and lower_32_bits

Shifting and masking various types can be made a bit simpler to read by using the available kernel macros. Signed-off-by: Joe Perches <j...@perches.com> --- This RFC patch is meant as an example, not necessarily to apply, though it does compile to equivalent code. It does seem a bit s

[PATCH] ixgbe: Remove pr_cont uses

hex filename 62167 728 12 62907f5bb drivers/net/ethernet/intel/ixgbe/ixgbe_main.o.new 62273 728 12 63013f625 drivers/net/ethernet/intel/ixgbe/ixgbe_main.o.old Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.

Re: [PATCH 01/12] Make and configuration files.

On Tue, 2016-12-27 at 05:17 -0800, David VomLehn wrote: > Patches to create the make and configuration file [] > \ No newline at end of file Not good > diff --git a/drivers/net/ethernet/aquantia/atlantic/Makefile > b/drivers/net/ethernet/aquantia/atlantic/Makefile A really atypical Makefile

Re: [PATCH 01/12] Make and configuration files.

On Tue, 2016-12-27 at 05:17 -0800, David VomLehn wrote: > Patches to create the make and configuration files. A few small things about this patch series that adds a new driver: These should be sent with a cover letter [0/N] so that the reason this series is useful can be added to the merge log.

[PATCH] fddi: skfp: Use more common logging styles

from formats and add to macro defines o Coalesce a few consecutive logging uses to more simple single uses Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/fddi/skfp/cfm.c | 22 drivers/net/fddi/skfp/drvfbi.c | 4 +- drivers/net/fddi/skfp/ecm.c

[PATCH] skfp: hwmtm: Use proper logging macros, correct mismatches

Logging macros should allow format and argument validation. The DB_TX, DB_RX, and DB_GEN macros did not. Update the macros and uses and add no_printk validation to the previously compiled away #ifndef DEBUG variants. Done with coccinelle and some typing. Signed-off-by: Joe Perches &l

Re: [PATCH] net: fddi: skfp: use %p format specifier for addresses rather than %x

On Wed, 2016-12-21 at 16:03 +, Colin King wrote: > From: Colin Ian King > > Trivial fix: Addresses should be printed using the %p format specifier > rather than using %x. The DB_TX, DB_RX, DB_GEN, and DB_SMT macros are quite ugly because they don't match format and

Re: [PATCH] net: wan: Use dma_pool_zalloc

On Fri, 2016-12-16 at 19:25 +0530, Souptick Joarder wrote: > On Fri, Dec 16, 2016 at 11:40 AM, Joe Perches <j...@perches.com> wrote: > > On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote: > > > On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches <j...@perches.com>

Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

On Fri, 2016-12-16 at 20:21 +0200, Ozgur Karatas wrote: > This patch fixed to keyboard typo, brackets not closed. > I think, it should be close to parenthes. No. Please compile and test your patches on your own system before you send them.

Re: [PATCH] net: wan: Use dma_pool_zalloc

On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote: > On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches <j...@perches.com> wrote: > > On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote: > > > On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder <jrdr.li

Re: [PATCH] net: wan: Use dma_pool_zalloc

On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote: > On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder > wrote: > > On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa wrote: > > > Souptick Joarder writes: > > > > > > > We

Re: [patch net-next] irda: w83977af_ir: cleanup an indent issue

On Mon, 2016-12-12 at 14:21 +0300, Dan Carpenter wrote: > In commit 99d8d2159d7c ("irda: w83977af_ir: Neaten logging"), we > accidentally added an extra tab to these lines. Thanks Dan. Oops, It's kinda funny I did the whole series to fix that misindentation originally and added it back when

[PATCH v3 7/7] irda: w83977af_ir: Neaten logging

Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 56 -- 1 file changed, 27 inse

[PATCH v3 1/7] irda: w83977af_ir: Whitespace neatening

Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c

[PATCH v3 3/7] irda: w83977af_ir: Remove and add blank lines

Use a more typical vertical spacing style. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 166dd4e524fc..e30cbf

[PATCH v3 0/7] irda: w83977af_ir: Neatening

in the garage in who knows how long, if this device is still used somewhere, might as well neaten the code too. Joe Perches (7): irda: w83977af_ir: Whitespace neatening irda: w83977af_ir: More whitespace neatening irda: w83977af_ir: Remove and add blank lines irda: w83977af_ir: Neaten pointer

[PATCH v3 6/7] irda: w83977af_ir: Parenthesis alignment

Neaten function declaration and definition arguments. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5d5ec8

[PATCH v3 4/7] irda: w83977af_ir: Neaten pointer comparisons

Convert pointer comparisons to NULL. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c

[PATCH v3 2/7] irda: w83977af_ir: More whitespace neatening

Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 230 - 1 file changed, 115 insertions(+), 115 deletions(-) diff --git a/drivers/net/irda/w83977af_

[PATCH v3 5/7] irda: w83977af_ir: Use the common brace style

Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977a

[PATCH resend 5/8] irda: w83977af_ir: Use the common brace style

Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977a

[PATCH resend 2/8] irda: w83977af_ir: More whitespace neatening

Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 232 - 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/drivers/net/irda/w83977af_

[PATCH resend 8/8] irda: w83977af_ir: Fix misindented block

One indent level too many is too many. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 19b171

[PATCH resend 6/8] irda: w83977af_ir: Parenthesis alignment

Neaten function declaration and definition arguments. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5d776f

[PATCH resend 4/8] irda: w83977af_ir: Neaten pointer comparisons

Convert pointer comparisons to NULL. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c

[PATCH resend 7/8] irda: w83977af_ir: Neaten logging

Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 48 -- 1 file changed, 23 inse

[PATCH resend 3/8] irda: w83977af_ir: Remove and add blank lines

Use a more typical vertical spacing style. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 4ad91f4f867f..5aa614

[PATCH resend 1/8] irda: w83977af_ir: whitespace neatening

Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 392 - 1 file changed, 196 insertions(+), 196 deletions(-) diff --git a/drivers/ne

[PATCH resend 0/8] irda: w83977af_ir: Neatening

On top of Arnd's overly long udelay patch because I noticed a misindented block. Even though I haven't turned on the netwinder in a box in the garage in who knows how long, if this device is still used somewhere, might as well neaten the code too. Joe Perches (8): irda: w83977af_ir: whitespace

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: > On top of Arnd's overly long udelay patch because I noticed a > misindented block. > > Even though I haven't turned on the netwinder in a box in in the > garage in who knows how long, if this device is still used somewhere,

Re: [PATCH] mlx4: Use kernel sizeof and alloc styles

On Sun, 2016-12-04 at 12:58 -0800, Eric Dumazet wrote: > On Sun, 2016-12-04 at 12:11 -0800, Joe Perches wrote: > > Convert sizeof foo to sizeof(foo) and allocations with multiplications > > to the appropriate kcalloc/kmalloc_array styles. > > > > Signed-off-by: Jo

[PATCH] mlx4: Use kernel sizeof and alloc styles

Convert sizeof foo to sizeof(foo) and allocations with multiplications to the appropriate kcalloc/kmalloc_array styles. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 6 +++--- drivers/net/ethernet/mellanox/mlx4/cmd.c

Re: [PATCH] stmmac ethernet: remove cut & paste code

On Mon, 2016-11-28 at 15:35 +0100, Pavel Machek wrote: > On Mon 2016-11-28 06:24:28, Joe Perches wrote: > > On Mon, 2016-11-28 at 12:50 +0100, Pavel Machek wrote: > > > On Thu 2016-11-24 14:27:13, Joe Perches wrote: > > > > On Thu, 2016-11-24 at 22:44 +0100, Pavel

Re: [PATCH] stmmac ethernet: remove cut & paste code

On Mon, 2016-11-28 at 12:50 +0100, Pavel Machek wrote: > On Thu 2016-11-24 14:27:13, Joe Perches wrote: > > On Thu, 2016-11-24 at 22:44 +0100, Pavel Machek wrote: > > > On Thu 2016-11-24 12:05:25, Joe Perches wrote: > > > > On Thu, 2016-11-24 at 12:05 +0100, Pavel

Re: [PATCH] stmmac ethernet: remove cut & paste code

On Thu, 2016-11-24 at 22:44 +0100, Pavel Machek wrote: > On Thu 2016-11-24 12:05:25, Joe Perches wrote: > > On Thu, 2016-11-24 at 12:05 +0100, Pavel Machek wrote: > > > Remove duplicate code from _tx routines. > > > > trivia: > > > > > dif

Re: [PATCH] stmmac ethernet: remove cut & paste code

On Thu, 2016-11-24 at 12:05 +0100, Pavel Machek wrote: > Remove duplicate code from _tx routines. trivia: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c [] > @@ -1960,6 +1960,38 @@ static void stmmac_tso_allocator(struct

[PATCH 0/8] irda: w83977af_ir: Neatening

On top of Arnd's overly long udelay patch because I noticed a misindented block. Even though I haven't turned on the netwinder in a box in in the garage in who knows how long, if this device is still used somewhere, might as well neaten the code too. Joe Perches (8): irda: w83977af_ir

[PATCH 3/8] irda: w83977af_ir: Remove unnecessary blank lines

These just add unnecessary vertical whitespace. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 4ad91f

[PATCH 4/8] irda: w83977af_ir: Neaten pointer comparisons

Convert pointer comparisons to NULL. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c

[PATCH 1/8] irda: w83977af_ir: whitespace neatening

Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 392 - 1 file changed, 196 insertions(+), 196 deletions(-) diff --git a/drivers/ne

[PATCH 8/8] irda: w83977af_ir: Fix misindented block

One indent level too many is too many. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 19b171

[PATCH 7/8] irda: w83977af_ir: Neaten logging

Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 48 -- 1 file changed, 23 inse

[PATCH 6/8] irda: w83977af_ir: Parenthesis alignment

Neaten function declaration and definition arguments. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5d776f

[PATCH 5/8] irda: w83977af_ir: Use the common brace style

Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977a

[PATCH 2/8] irda: w83977af_ir: More whitespace neatening

Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/irda/w83977af_ir.c | 232 - 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/drivers/net/irda/w83977af_

Re: Coding Style: Reverse XMAS tree declarations ?

On Fri, 2016-11-04 at 11:07 -0400, David Miller wrote: > From: Lino Sanfilippo <lsan...@marvell.com> > > On 04.11.2016 07:53, Joe Perches wrote: > >> CHECK:REVERSE_XMAS_TREE: Prefer ordering declarations longest to > >> shortest > >> #4

Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: > From: Madalin Bucur > Date: Wed, 2 Nov 2016 22:17:26 +0200 > > > This introduces the Freescale Data Path Acceleration Architecture > > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) > > +{ > > + u8

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: > Code is 80 characters wide, and comments are /* */ never the ugly C++ > crap. You might look at the recent Linus Torvalds authored commit 5e467652ffef (?printk: re-organize log_output() to be more legible") which does both of those: c99 //

[PATCH net-next] i40evf: Move some i40evf_reset_task code to separate function

The i40evf_reset_task function is a couple hundred lines and it has a separable block that disables vf. Move that block to a new i40evf_disable_vf function to shorten i40evf_reset_task a bit. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/intel/i40evf/i40evf_main.

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

On Tue, 2016-11-01 at 08:15 +1000, John Heenan wrote: > > On 1 November 2016 at 07:25, Jes Sorensen wrote: > > > > John Heenan writes: > > > The rtl8723bu wireless IC shows evidence of a more agressive approach to > > > power saving, powering down its RF

Re: [PATCH 17/17] batman-adv: Avoid precedence issues in macros

On Fri, 2016-10-28 at 23:27 +0200, Sven Eckelmann wrote: > On Freitag, 28. Oktober 2016 14:13:06 CEST Joe Perches wrote: > > On Thu, 2016-10-27 at 21:01 +0200, Simon Wunderlich wrote: > > > From: Sven Eckelmann <s...@narfation.org> > > > > > > It

Re: [PATCH 17/17] batman-adv: Avoid precedence issues in macros

On Thu, 2016-10-27 at 21:01 +0200, Simon Wunderlich wrote: > From: Sven Eckelmann > > It must be avoided that arguments to a macro are evaluated ungrouped (which > enforces normal operator precendence). Otherwise the result of the macro > is not well defined. Curiosity: in

[PATCH 1/2] rds: Remove unused rds_conn_error

This macro's last use was removed in commit d769ef81d5b59 ("RDS: Update rds_conn_shutdown to work with rds_conn_path") so make the macro and the __rds_conn_error function definition and declaration disappear. Signed-off-by: Joe Perches <j...@perches.com> --- net/rds/c

[PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use

rds_conn_path_error already prefixes "RDS:" to the output. Signed-off-by: Joe Perches <j...@perches.com> --- net/rds/threads.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rds/threads.c b/net/rds/threads.c index e42df11bf30a..e36e333a0aa0 1006

[PATCH 0/2] rds: logging neatening

Joe Perches (2): rds: Remove unused rds_conn_error rds: Remove duplicate prefix from rds_conn_path_error use net/rds/connection.c | 15 --- net/rds/rds.h| 4 net/rds/threads.c| 3 +-- 3 files changed, 1 insertion(+), 21 deletions(-) -- 2.10.0.rc2.1.g053435c

Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver

On Fri, 2016-10-07 at 10:25 +0200, Corentin Labbe wrote: > This patch add support for sun8i-emac ethernet MAC hardware. > It could be found in Allwinner H3/A83T/A64 SoCs. trivial notes: > diff --git a/drivers/net/ethernet/allwinner/sun8i-emac.c > b/drivers/net/ethernet/allwinner/sun8i-emac.c []

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

On Thu, 2016-10-06 at 13:00 +, David Laight wrote: > From: Joe Perches > > Sent: 06 October 2016 12:39 > > On Thu, 2016-10-06 at 09:41 +, David Laight wrote: > > > From: Joe Perches > > > > No worries, and bool is the same ,size as u8. > >

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

On Thu, 2016-10-06 at 09:41 +, David Laight wrote: > From: Joe Perches > > No worries, and bool is the same ,size as u8. > That is not guaranteed at all. > One of the ARM ABI defined bool to be the size of int. Really? What kernel has sizeof(_Bool) != 1 ?

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote: > I believe you are wrong. bit addressability does not matter, cpu can > definitely get the bit values. > > u8 foo:1; > u8 bar:1; > u8 baz:1; > > should take 1 byte, where > > bool foo, bar, baz; > > will take more like 3. Definitely

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

On Thu, 2016-10-06 at 00:13 +0200, Pavel Machek wrote: > On Wed 2016-10-05 12:15:34, Joe Perches wrote: > > On Wed, 2016-10-05 at 21:11 +0200, Pavel Machek wrote: > > > On Wed 2016-10-05 10:53:16, Joe Perches wrote: [] > > > > trivia: > > > > It's genera

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

On Wed, 2016-10-05 at 21:11 +0200, Pavel Machek wrote: > On Wed 2016-10-05 10:53:16, Joe Perches wrote: > > On Wed, 2016-10-05 at 13:14 +0200, Marcel Holtmann wrote: > > > Hi Pavel, > > > > > > > bluetooth.h is not part of user API, so __ v

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

On Wed, 2016-10-05 at 13:14 +0200, Marcel Holtmann wrote: > Hi Pavel, > > > bluetooth.h is not part of user API, so __ variants are not neccessary > > here. > > > > Signed-off-by: Pavel Machek > > > > diff --git a/include/net/bluetooth/bluetooth.h > >

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: > Your output shows it moving to the text segment - if it's in a different > segment, eg. rodata, you should use output demonstrating that to justify > the change. For size, rodata _is_ text

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: > Joe Perches <j...@perches.com> writes: > > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > > x86-32) > >   textdata

[PATCH] realtek: rtl8xxxu: Use const init arrays

16e64 drivers/net/wireless/realtek/rtl8xxxu/built-in.o.old Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 6 +++--- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 8 drivers/net/wireless/realtek/rt

[PATCH] igb: Realign bad indentation

Statements should start on tabstops. Use a single statement and test instead of multiple tests. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/intel/igb/e1000_mac.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/et

[PATCH] i40e: Make struct i40e_stats const

/i40e_ethtool.o.old Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 183518

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

On Mon, 2016-09-26 at 21:37 +0300, Kalle Valo wrote: > I talked with Jouni and we concluded marking this fully obsolete is the > best (so removing the "Maintained" part completelo the shmoo list > is not used anymore, that can be removed. Well, it would be best if Jouni submitted something.

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: > hostap is an obsolete driver, it's waste of time doing style fixes to it > as nobody maintains it anymore. Dunno know if Jouni is still maintaining this at all but maybe a MAINTAINERS update to mark it obsolete so checkpatch warns on

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

On Mon, 2016-09-26 at 16:00 +, David Laight wrote: > From: SF Markus Elfring Sent: 26 September 2016 16:45 > > The script "checkpatch.pl" can point information out like the following. > > WARNING: sizeof … should be sizeof(…) > [] > > diff --git a/drivers/isdn/gigaset/common.c

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: > On 09/24/2016 12:32 PM, Joe Perches wrote: [] > o Reindent all the switch/case blocks to a more normal > kernel style (git diff -w would show no changes here) > That sounds like busy work to me, but if you want to do it, go

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

(adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: > I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the > drivers,  > and one that sets the enum values for that particular statement to hex > values. I  > also looked at the other large

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: > Would it make sense to explicitly set the enum values, or add them as > comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please be my guest. otherwise, hex is at least a

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > I'm not familiar with the %#x format. What does it do? Outputs SPECIAL prefix, it's the same as "0x%x" lib/vsprintf.c: #define SPECIAL 64 /* prefix hex with "0x", octal with "0" */

[PATCH] realtek: Add switch variable to 'switch case not processed' messages

Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/core.c | 3 ++- drivers/net/wireless/realtek/rtlwifi/pci.c | 3 ++- drivers/net/wi

rfc: Are any of the seq_pad() uses really necessary?

t; usage from seq_file users All seq_printf() users are using "%n" for calculating padding size, convert them to use seq_setwidth() / seq_pad() pair. Signed-off-by: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> Signed-off-by: Kees Cook <keesc...@chromium.org> Cc: Joe Per

Re: Possible code defects: macros and precedence

On Tue, 2016-09-20 at 10:07 -0700, Joe Perches wrote: > On Tue, 2016-09-20 at 15:14 +0200, Julia Lawall wrote: > > The semantic patch below finds a binary operator in a macro and a binary > > operator in the use of the macro, and checks if the priority of the > > operator i

Re: [PATCH net] MAINTAINERS: Gary Zambrano's email is bouncing

On Sat, 2016-09-17 at 16:38 -0700, Florian Fainelli wrote: > 2016-09-17 16:23 GMT-07:00 Joe Perches <j...@perches.com>: > > On Sat, 2016-09-17 at 16:17 -0700, Florian Fainelli wrote: > > > The list does not accept public subscribers, so this is the correct > &

Re: [PATCH net] MAINTAINERS: Gary Zambrano's email is bouncing

On Sat, 2016-09-17 at 16:17 -0700, Florian Fainelli wrote: > 2016-09-17 15:51 GMT-07:00 Joe Perches <j...@perches.com>: [] > > Without an actual maintainer, this should really be > > orphan and not supported. > I would like to hear from Michael before concluding that No

Re: [PATCH net] MAINTAINERS: Gary Zambrano's email is bouncing

On Sat, 2016-09-17 at 15:27 -0700, Florian Fainelli wrote: > Gary has not been with Broadcom for some time now, replace his address > with the internal mailing-list used for other entries. > > > Signed-off-by: Florian Fainelli > --- > Michael, > > Since this is an old

Re: [PATCH 00/26] constify local structures

On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > Constify local structures. Thanks Julia. A few suggestions & questions: Perhaps the script should go into scripts/coccinelle/ so that future cases could be caught by the robot and commit message referenced by the patch instances. Can you

<    1   2   3   4   5   6   7   8   9   >