Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com>
Thanks for fixing.
I think it's preferable to add 'Fixes'.
Fixes: 4c270b55a5af ("net: ethernet: socionext: add AVE ethernet driver")
Acked-by: Kunihiko Haya
Add "socionext,syscon-phy-mode" property to specify system controller that
configures the settings about phy-mode.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Reviewed-by: Rob Herring <r...@kernel.org>
---
Documentation/devicetree/bindings/net/socionext
t;net: ethernet: socionext: add AVE ethernet driver")
Suggested-by: Masahiro Yamada <yamada.masah...@socionext.com>
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Reviewed-by: Rob Herring <r...@kernel.org>
---
.../bindings/net/socionext,uniphier-ave4.txt |
the specified phy-mode
- Add DT property support indicating system controller that has the feature
for configurating phy-mode including built-in phy on LD11.
v1: https://www.spinics.net/lists/netdev/msg494904.html
Changes since v1:
- Add 'Reviewed-by' lines
Kunihiko Hayashi (3):
net: ethernet
syscon-phy-mode = <_glue 0>;
};
ethernet@6520 {
...
socionext,syscon-phy-mode = <_glue 1>;
};
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
---
drivers/net/ethernet/s
Add "socionext,syscon-phy-mode" property to specify system controller that
configures the settings about phy-mode.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt | 6 +-
1 file changed, 5
the specified phy-mode
- Add DT property support indicating system controller that has the feature
for configurating phy-mode including built-in phy on LD11.
Kunihiko Hayashi (3):
net: ethernet: ave: add multiple clocks and resets support as required
property
dt-bindings: net: ave: add
syscon-phy-mode = <_glue 0>;
};
ethernet@6520 {
...
socionext,syscon-phy-mode = <_glue 1>;
};
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
---
drivers/net/ethernet/s
t;net: ethernet: socionext: add AVE ethernet driver")
Suggested-by: Masahiro Yamada <yamada.masah...@socionext.com>
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
.../bindings/net/socionext,uniphier-ave4.txt | 13 ++-
drivers/net/ethernet/soc
Add a compatible string and SoC data for ethernet controller on
UniPhier PXs3 SoC.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
drivers/net/ethernet/socionext/sni_ave.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/socionext/sni_av
Add ethernet controller support on UniPhier PXs3 SoC.
Kunihiko Hayashi (2):
dt-bindings: net: ave: add PXs3 support
net: ethernet: ave: add UniPhier PXs3 support
Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt | 1 +
drivers/net/ethernet/socionext/sni_ave.c
Add a compatible string for ethernet controller on UniPhier PXs3 SoC.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindin
This enables AVE_GI_RXDROP interrupt factor. This factor indicates
depletion of Rx descriptors and the handler counts the number
of dropped packets.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
drivers/net/ethernet/socionext/sni_ave.c | 2 +-
1 file changed, 1 ins
org/patch/10025279/
I've checked our hardware configuration.
There are internal and external MDIO buses, and the register selects
between them. I'll consider to apply MDIO MUX layer to our MAC driver
rather than phy_is_internal of generic-phy.
Thank you,
---
Best Regards,
Kunihiko Hayashi
Hi Andrew,
On Thu, 8 Feb 2018 13:51:44 +0100 <and...@lunn.ch> wrote:
> On Thu, Feb 08, 2018 at 07:09:25PM +0900, Kunihiko Hayashi wrote:
> > Hello,
> >
> > Is there a way to specify "phy is internal" to generic phy driver,
> > that is, to make phy_i
ric phy. And I think that
the meaning of "integrated" is slightly different from "internal".
---
Best Regards,
Kunihiko Hayashi
ave_{get,set}_wol()
- remove netif_carrier functions, phydev initializer, and Tx budget check
- change obsolate codes
- replace ndev->{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bi
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
Acked-by: Rob Herring <r...@kernel.org>
Reviewed-by: Florian Fainelli <
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org&
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
Acked-by: Rob Herring <r...@kernel.org>
---
.../bindings/net/socionext
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org&
e members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt | 4
+ mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + ethphy: ethphy@1 {
> > + reg = <1>;
> > + };
> > + };
> > + };
>
> Andrew
Thank you,
---
Best Regards,
Kunihiko Hayashi
initions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt | 45 +
drivers/net/ethernet/Kconfig |1
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
Acked-by: Rob Herring <r...@kernel.org>
---
.../bindings/net/socionext
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org&
Hello David,
On Fri, 15 Dec 2017 12:57:49 -0500 David Miller <da...@davemloft.net> wrote:
> From: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
> Date: Thu, 14 Dec 2017 19:05:10 +0900
>
> > +static void ave_desc_write(struct net_device *ndev, enum desc_id id,
>
Hello Florian,
On Thu, 14 Dec 2017 15:24:17 -0800 <f.faine...@gmail.com> wrote:
>
>
> On 12/14/2017 02:05 AM, Kunihiko Hayashi wrote:
> > DT bindings for the AVE ethernet controller found on Socionext's
> > UniPhier platforms.
> >
> > Signed-
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
Acked-by: Rob Herring <r...@kernel.org>
---
.../bindings/net/socionext
;{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org&
On Mon, 11 Dec 2017 10:19:15 +0100 Phlippe Ombredanne <pombreda...@nexb.com>
wrote:
> Dear Kunihiko-san,
>
> On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi
> <hayashi.kunih...@socionext.com> wrote:
> > The UniPhier platform from Socionext provides t
perations
- add phydev check on ave_{get,set}_wol()
- remove netif_carrier functions, phydev initializer, and Tx budget check
- change obsolate codes
- replace ndev->{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihik
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org&
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
Acked-by: Rob Herring <r...@kernel.org>
---
.../bindings/net/socionext
Hi Andrew,
On Fri, 1 Dec 2017 14:49:00 +0100 Andrew Lunn <and...@lunn.ch> wrote:
> On Fri, Dec 01, 2017 at 10:03:50AM +0900, Kunihiko Hayashi wrote:
> > The UniPhier platform from Socionext provides the AVE ethernet
> > controller that includes MAC and MDIO bus supporting
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
Acked-by: Rob Herring <r...@kernel.org>
---
.../bindings/net/socionext
etif_carrier functions, phydev initializer, and Tx budget check
- change obsolate codes
- replace ndev->{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhi
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
---
.../bindings/net/socionext,uniphier-ave4.txt | 48 ++
bsolate codes
- replace ndev->{base_addr,irq} with the members of ave_private
- rename goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../binding
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
On Thu, 19 Oct 2017 09:29:03 +0900 <yamada.masah...@socionext.com> wrote:
> 2017-10-18 19:23 GMT+09:00 Kunihiko Hayashi <hayashi.kunih...@socionext.com>:
> > On Mon, 16 Oct 2017 00:08:21 +0900 <yamada.masah...@socionext.com> wrote:
>
> >> priv->rst =
On Sat, 14 Oct 2017 01:41:12 +0900 <yamada.masah...@socionext.com> wrote:
> 2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi <hayashi.kunih...@socionext.com>:
> > DT bindings for the AVE ethernet controller found on Socionext's
> > UniPhier platforms.
> >
&g
On Mon, 16 Oct 2017 00:08:21 +0900 <yamada.masah...@socionext.com> wrote:
> 2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi <hayashi.kunih...@socionext.com>:
> > +static int ave_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = >dev;
>
goto labels and mask definitions, and remove unused codes
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt | 53 +
drivers/net/ethernet/Kconfig
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
---
.../bindings/net/socionext,uniphier-ave4.txt | 53 ++
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
h the clock, the block is clocked, so it can consume some
> > amount of power, just do the necessary HW initialization with the clock
> > enabled, then defer until ndo_open() before turning it back on.
There are a number of the functions that needs clock enabled and "block reset"
operations, like mdiobus_register(), phy_connect(), and so on.
I tried to move such functions to ndo_open() to defer clock enabled until
ndo_open().
However, the driver didn't work for some reasons of hardware restriction.
I think it's hard to change this sequence.
---
Best Regards,
Kunihiko Hayashi
This renames the definition of page select register from
RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT to use it across models.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
Changes since v1:
- new patch in this series
---
drivers/net/phy/realtek.c | 10 +-
i...@linaro.org>
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
---
Changes since v1:
- use RTL821x_PAGE_SELECT instead of defining RTL8201F_PAGE_SELECT
pt wasn't
handled.
Although ave_init() calls phy_start_aneg(), it doesn't make sense
because phy driver doesn't start yet.
And according to Florian's comment in ave_init(),
> + phy_start_interrupts(phydev);
> +
> + phy_start_aneg(phydev);
>
> No, no, phy_start() would take care of all of that correctly for you,
> you don't have have to do it just there because ave_open() eventually
> calls phy_start() for you, so just drop these two calls.
When moving phy_start_aneg() to ave_open(), the handler doesn't need to call
phy_mac_interrupt() and I can remove it from the handler.
---
Best Regards,
Kunihiko Hayashi
Hi Andrew,
Thank your for reviewing.
On Sat, 9 Sep 2017 17:55:17 +0200 <and...@lunn.ch> wrote:
> On Sat, Sep 09, 2017 at 09:03:05AM +0530, Jassi Brar wrote:
> > On 9 September 2017 at 00:21, Florian Fainelli <f.faine...@gmail.com> wrote:
> > > On 09/08/2017 06
Hi Florian,
On Fri, 8 Sep 2017 11:54:31 -0700 <f.faine...@gmail.com> wrote:
> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > DT bindings for the AVE ethernet controller found on Socionext's
> > UniPhier platforms.
> >
> > Signed-off-by: Kunihiko Hayash
> node.
>
>mdio {
> ethphy: ethernet-phy@6 {
> reg = <6>;
> };
> };
>
> Andrew
I see. I'll rewrite the binding example using mdio node.
---
Best Regards,
Kunihiko Hayashi
Hi Florian,
On Sat, 9 Sep 2017 09:30:58 -0700 <f.faine...@gmail.com> wrote:
>
>
> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > The UniPhier platform from Socionext provides the AVE ethernet
> > controller that includes MAC and MDIO bus supporting RGMII/RMI
Hi Florian,
Thank you for your comments,
On Fri, 8 Sep 2017 12:31:18 -0700 <f.faine...@gmail.com> wrote:
> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:
> > The UniPhier platform from Socionext provides the AVE ethernet
> > controller that includes MAC and MDIO bus
Hi Yamada-san,
Thank you for your comments,
On Fri, 8 Sep 2017 23:44:13 +0900 <yamada.masah...@socionext.com> wrote:
> 2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi <hayashi.kunih...@socionext.com>:
>
> > diff --git a/drivers/net/ethernet/socionext/Kconfig
> > b/
ad to stop the own interrupt of PHY device
because it might be already enabled.
But surely we don't think of such a case.
> > +
> > + /* When PHY driver can't handle its interrupt directly,
> > +* interrupt request always fails and polling method is used
> > +* alternatively. In this case, the libphy says
> > +* "libphy: uniphier-mdio: Can't get IRQ -1 (PHY)".
> > +*/
> > + phy_start_interrupts(phydev);
>
> -1 is PHY_POLL. So calling phy_start_interrupts() is wrong. In fact,
> you should not be calling phy_start_interrupts() at all. No other
> Ethernet driver does.
The phy_start_interrupts() calls request_threaded_irq(), and it wll succeed
when PHY node has own 'interrupts' property.
In this case, it will fail and phydev->irq sets PHY_POLL.
However, phydev->irq is initialized PHY_POLL in phy_probe(),
surely it isn't necessary.
> > +
> > + phy_start_aneg(phydev);
> > +
> > + return 0;
> > +}
> > +
> > +static void ave_uninit(struct net_device *ndev)
> > +{
> > + struct ave_private *priv = netdev_priv(ndev);
> > +
> > + phy_stop_interrupts(priv->phydev);
>
> And no other Ethernet driver calls phy_stop_interrupts either.
> Please take a look at this.
I see. I'll check it.
>
> > + phy_disconnect(priv->phydev);
> > +}
> > +
>
> Andrew
---
Best Regards,
Kunihiko Hayashi
The UniPhier platform from Socionext provides the AVE ethernet
controller that includes MAC and MDIO bus supporting RGMII/RMII
modes. The controller is named AVE.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
-id and functions
Kunihiko Hayashi (2):
dt-bindings: net: add DT bindings for Socionext UniPhier AVE
net: ethernet: socionext: add AVE ethernet driver
.../bindings/net/socionext,uniphier-ave4.txt | 44 +
drivers/net/ethernet/Kconfig |1 +
drivers/net/ethernet
DT bindings for the AVE ethernet controller found on Socionext's
UniPhier platforms.
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
Signed-off-by: Jassi Brar <jaswinder.si...@linaro.org>
---
.../bindings/net/socionext,uniphier-ave4.txt | 44 ++
i...@linaro.org>
Signed-off-by: Kunihiko Hayashi <hayashi.kunih...@socionext.com>
---
drivers/net/phy/realtek.c | 45 +
1 file changed, 45 insertions(+)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 9cbe645..d9974ce 1006
63 matches
Mail list logo
