[PATCH] ssb: Add CHIPCO IRQ access functions

2008-02-22 Thread Michael Buesch
From: Aurelien Jarno <[EMAIL PROTECTED]> This patch adds functions to setup and read the CHIPCO IRQ. Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- For 2.6.26. drivers/ssb/driver_chipcommon.c | 10 +++

Re: pull request: wireless-2.6 'upstream' 2008-01-22

2008-01-23 Thread Michael Buesch
On Wednesday 23 January 2008 12:15:51 Stefano Brivio wrote: > On Tue, 22 Jan 2008 20:45:21 -0500 > "John W. Linville" <[EMAIL PROTECTED]> wrote: > > > b43legacy: Remove the PHY spinlock > > I hope you tested this. I still haven't been able to (I received the > needed hardware yesterday), an

Re: [PATCH] Force UNIX domain sockets to be built in

2007-12-31 Thread Michael Buesch
On Monday 31 December 2007 19:37:43 Torsten Kaiser wrote: > The base problem is that there already are many options to break > external modules. (CONFIG_MODULES=n ;) ) Exactly. There already are enough ways to break external modules. No need to introduce more. ;) > The question I can't answer in

Re: [PATCH] Force UNIX domain sockets to be built in

2007-12-31 Thread Michael Buesch
On Monday 31 December 2007 17:38:03 Alan Cox wrote: > On Mon, 31 Dec 2007 17:17:19 +0100 > "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > > a) this could be disabled during development if you want this > > b) this would even only affect development if you add new code that > > now needs a EXPORT_

Re: [PATCH] Force UNIX domain sockets to be built in

2007-12-31 Thread Michael Buesch
On Monday 31 December 2007 16:55:57 Torsten Kaiser wrote: > On Dec 31, 2007 3:42 PM, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > With CONFIG_MODULES=y the 13 EXPORT_SYMBOL's that only exist for the > > theoretical possibility of CONIG_UNIX=m waste a few hundred bytes > > of memory. > > One thing I

Re: SSB: No is not an answer

2007-12-01 Thread Michael Buesch
On Saturday 01 December 2007 20:00:23 Arnaldo Carvalho de Melo wrote: > Em Sat, Dec 01, 2007 at 12:45:32PM -0500, John W. Linville escreveu: > > On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote: > > > Sonics Silicon Backplane support (SSB) [M/y/?] (NEW) n > > > > > > Suppor

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-11-07 Thread Michael Buesch
On Wednesday 07 November 2007 01:13:14 John W. Linville wrote: > "ssb: Fix initcall ordering" changes a subsys_initcall to an > fs_initcall. This seems like a bit of a hack, but it fixes a real > problem and I'm not sure what cleaner solution is either reasonable > or available. The comment in th

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Michael Buesch
() or > > > kmem_cache_free(). > > On 11/5/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > Yeah. > > > > What I also saw was random "one-bit-errors" once and then on rmmod of > > modules. > > I have absolutely no idea how they were caused

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Michael Buesch
On Monday 05 November 2007 13:23:50 Pekka Enberg wrote: > Hi Michael, > > On Sat, 2007-11-03 at 21:06 +0100, Michael Buesch wrote: > > Who is responsible for slab btw? > > I mean, someone should be interested in getting this bug fixed. :) > > When using slab I see

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-03 Thread Michael Buesch
On Saturday 03 November 2007 20:58:09 Luis R. Rodriguez wrote: > I was using SLAB and ran into other strange oops, as the one below, > but after switching to SLUB, after Michael Buesch's suggestion that > one went away... The lockdep segfault is still present, however. Who is responsible for slab

Re: [patch 8/8] ssb bus needs

2007-10-13 Thread Michael Buesch
rivers/ssb/main.c: In function 'ssb_ssb_write32': > linux/drivers/ssb/main.c:542: error: implicit declaration of function 'writel' > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > --- > d

Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed

2007-10-04 Thread Michael Buesch
On Thursday 04 October 2007 16:34:43 Michael Wu wrote: > On Thursday 04 October 2007 07:33, Daniel Drake wrote: > > Fix this by unsetting the hard_start_xmit handler in ieee80211_if_reinit. > > It will then be reinitialised to the default (ieee80211_subif_start_xmit) > > in ieee80211_if_set_type. >

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-22 Thread Michael Buesch
On Saturday 22 September 2007, Ulrich Kunitz wrote: > Michael Buesch wrote: > > > On Saturday 22 September 2007 11:48:00 Ulrich Kunitz wrote: > > > A real high-quality driver will require Johannes' proposed > > > mac80211 driver interface changes to be merged an

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-22 Thread Michael Buesch
On Saturday 22 September 2007 11:48:00 Ulrich Kunitz wrote: > A real high-quality driver will require Johannes' proposed > mac80211 driver interface changes to be merged and TX > confirmations handled in a way, that the semantics can really be > supported by the driver. (Michael Buesh's patch is ta

Re: net-2.6.24 - build failure

2007-09-21 Thread Michael Buesch
On Thursday 20 September 2007 00:17:12 David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 14:53:22 -0700 > > > drivers/net/wireless/b43legacy/built-in.o: In function `tsf_read_file': > > drivers/net/wireless/b43legacy/debugfs.c:80: multiple definition of > > `tsf

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-19 Thread Michael Buesch
On Wednesday 19 September 2007 20:59:03 David Miller wrote: > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 14:10:05 -0400 > > > This patch adds z1211 (previously known as zd1211rw-mac80211), > > a driver for Zydas ZD1211 hardware. This driver has proven very > > robust --

Re: Please pull 'rt2x00' branch of wireless-2.6

2007-09-19 Thread Michael Buesch
On Wednesday 19 September 2007 20:47:59 Ivo van Doorn wrote: > On Wednesday 19 September 2007, David Miller wrote: > > From: Ivo van Doorn <[EMAIL PROTECTED]> > > Date: Wed, 19 Sep 2007 20:31:19 +0200 > > > > > Because I am indeed not really happy with this early merge, but I'll do my > > > best t

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-07 Thread Michael Buesch
On Friday 07 September 2007, Johannes Berg wrote: > On Thu, 2007-09-06 at 08:46 -0700, Paul E. McKenney wrote: > > > Looks good to me from an RCU viewpoint. I cannot claim familiarity with > > this code. I therefore especially like the indications of where RTNL > > is held and not!!! > > :) >

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-29 Thread Michael Buesch
On Wednesday 29 August 2007 21:33:43 Jon Smirl wrote: > What if a patch spans both code that is pure GPL and code imported > from BSD, how do you license it? I think it's a valid assumption, if we say that the author of the patch read the license header of a file and agreed with it. So the patch i

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-29 Thread Michael Buesch
On Wednesday 29 August 2007 00:54:19 David Miller wrote: > From: Michael Buesch <[EMAIL PROTECTED]> > Date: Tue, 28 Aug 2007 16:48:44 +0200 > > > On Monday 27 August 2007 23:11:50 David Miller wrote: > > > From: Joe Perches <[EMAIL PROTECTED]> > &g

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread Michael Buesch
On Monday 27 August 2007 23:11:50 David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Mon, 27 Aug 2007 13:57:42 -0700 > > > On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote: > > > From: Johannes Berg <[EMAIL PROTECTED]> > > > Date: Mon, 27 Aug 2007 12:54:09 +0200 > > > > #defi

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-15 Thread Michael Buesch
On Wednesday 15 August 2007 15:29:43 Arnd Bergmann wrote: > On Wednesday 15 August 2007, Paul E. McKenney wrote: > > > ACCESS_ONCE() is indeed intended to be used when actually loading or > > storing the variable. That said, I must admit that it is not clear to me > > why you would want to add an

b44: Fix Kconfig dependencies by using select

2007-08-15 Thread Michael Buesch
Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev-new/drivers/net/Kconfig === --- wireless-dev-new.orig/drivers/net/Kconfig 2007-08-11 00:49:28.0 +0200 +++ wireless-dev-new/drivers/net/K

[PATCH] b44: Fix MII interface of the B44 driver

2007-08-15 Thread Michael Buesch
ws B44 devices with integrated switch to be configured from userland. Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 36724fb..e6883f4 100644 --- a/drivers/net/b44.c +++ b/drivers/ne

Re: [RFC: -mm patch] improve the SSB dependencies

2007-08-15 Thread Michael Buesch
On Wednesday 15 August 2007 02:40:35 John W. Linville wrote: > On Mon, Aug 13, 2007 at 12:44:02AM +0200, Adrian Bunk wrote: > > On Sun, Aug 12, 2007 at 02:00:26PM +0200, Michael Buesch wrote: > > > Ok, I'll give it a try, with small modifications. > > > > Tha

[PATCH] b44-ssb: Powerup the bus before using the device.

2007-08-14 Thread Michael Buesch
We must turn on buspower before poking with the device Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev-new/drivers/net/b44.c === --- wireless-dev-new.orig/drivers/net/b44.c 2007-08-11 00:45:55.000

Re: dm9000: add set_mac_address() v2

2007-08-12 Thread Michael Buesch
On Monday 13 August 2007 00:45:17 Michael Trimarchi wrote: > > >> + return -EBUSY; > >> + > >> + memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); > >> + > >> + for (i = 0; i < 3; i++) > >> + write_srom_word(db, i, > >> + cpu_to_le16(((u16 *) (addr->

Re: dm9000: add set_mac_address() v2

2007-08-12 Thread Michael Buesch
On Sunday 12 August 2007 23:20:09 michael trimarchi wrote: > Implement set_mac_address() for the dm9000 driver. This allows changing > the mac address of the interface. Fix BigEndian problem. > > Signed-off-by: Michael Trimarchi <[EMAIL PROTECTED]> > --- > > --- linux-2.6.22/drivers/net/dm9000.

Re: dm9000: add set_mac_address()

2007-08-12 Thread Michael Buesch
On Sunday 12 August 2007 23:38:08 Michael Buesch wrote: > On Sunday 12 August 2007 21:27:41 Michael Trimarchi wrote: > > Implement set_mac_address() for the dm9000 driver. This allows changing > > the mac address of the interface. > > > > Signed-off-by: Michael

Re: dm9000: add set_mac_address()

2007-08-12 Thread Michael Buesch
On Sunday 12 August 2007 21:27:41 Michael Trimarchi wrote: > Implement set_mac_address() for the dm9000 driver. This allows changing > the mac address of the interface. > > Signed-off-by: Michael Trimarchi <[EMAIL PROTECTED]> > --- > > --- linux-2.6.22/drivers/net/dm9000.c.orig2007-07-09 01:

Re: [RFC: -mm patch] improve the SSB dependencies

2007-08-12 Thread Michael Buesch
Ok, I'll give it a try, with small modifications. On Sunday 12 August 2007, Adrian Bunk wrote: > Additional changes in this patch: > - small help text changes > - B44_PCI is no longer usr visible (automatically enabled when possible) I think we want that to be selectable, as it's not needed on so

Re: [PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-11 Thread Michael Buesch
On Saturday 11 August 2007 16:30:02 Adrian Bunk wrote: > And offering more options than required or manually sending users into > other menus are bad thing for your users. Breaking compilations are as bad. So, does your example actually work in practice and not only in theory, too? My select stuf

Re: [PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-11 Thread Michael Buesch
On Saturday 11 August 2007 03:41:11 Adrian Bunk wrote: > On Sat, Aug 11, 2007 at 02:57:36AM +0200, Johannes Berg wrote: > > On Sat, 2007-08-11 at 02:43 +0200, Adrian Bunk wrote: > > > > > -ENOMENUCONFIGPATCH > > > > Has anybody decided how it could possibly even look like anyhow? It > > should be

[PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-10 Thread Michael Buesch
off-by: Michael Buesch <[EMAIL PROTECTED]> -- I think this should be merged into the ssb branch of wireless-dev, unless you plan to maintain a seperate branch for b44-ssb. But I think merging it with the ssb core is probably OK. Index: wireless-dev/drivers

[PATCH] Fix the SSB dependency hell

2007-08-09 Thread Michael Buesch
off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/Kconfig === --- wireless-dev.orig/drivers/net/Kconfig 2007-08-09 14:47:01.0 +0200 +++ wireless-dev/drivers/net/Kconfig2007-08-09 14:47:

Re: [patch] ipvs: force read of atomic_t in while loop

2007-08-09 Thread Michael Buesch
On Thursday 09 August 2007 02:15:33 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 05:08:44PM -0400, Chris Snook wrote: > > Heiko Carstens wrote: > > >On Wed, Aug 08, 2007 at 03:21:31AM -0700, David Miller wrote: > > >>From: Heiko Carstens <[EMAIL PROTECTED]> > > >>Date: Wed, 8 Aug 2007 11:33:00 +0200

[PATCH] ssb: pci core driver fixes

2007-08-09 Thread Michael Buesch
rol to internal. - Add some delay between the configuration of the PCI controller and its registration. Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- a/drivers/ssb/driver_pcicore.c +++ b/drivers/ssb/driver_pcicor

Re: [PATCH] SSB PCI core driver fixes

2007-08-08 Thread Michael Buesch
On Thursday 09 August 2007, Aurelien Jarno wrote: > - Add some delay between the configuration of the PCI controller >and its registration. Why? It is _huge_ and people won't like it ;) At least add a comment why this is needed. > @@ -340,6 +345,7 @@ >* The following needs change, i

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 18:59:08 Jeff Garzik wrote: > Michael Buesch wrote: > > writel doesn't guarantee flushing either. > > readl does. > > > Not quite -- there are multiple kinds of flushing. You're thinking > about flushing across PCI bridges, which

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 18:33:24 Jeff Garzik wrote: > Michael Buesch wrote: > > On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote: > >> > But there are indeed a few cases that look wrong. > >> > >> yes... > >> > >> > ar

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote: > > But there are indeed a few cases that look wrong. > > yes... > > > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); > > eg this almost certainly wants to be > > writel(swab32(val), target); > > or so

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 15:48:25 Michael Buesch wrote: > > However if that's true then there are quite some drivers wrong: > > > > % grep -r write[bwl]\(cpu_to * | wc -l > > 57 > > Yeah, seems so. Most of them seem to be __raw_writew(cpu_toXX(... whic

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 15:38:50 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 03:28:33PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 15:08:28 Andi Kleen wrote: > > > On Wed, Aug 08, 2007 at 03:02:35PM +0200, Michael Buesch wrote: > > > > On Wed

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 15:08:28 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 03:02:35PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > > > On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > > > > On Wed

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > > > +

Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > + val, reg_index, addr, addr+4); */ > > > + writel(cpu_to_le32(reg_index), addr); > > > + writel(cpu_to_le32(val),(u8 *)addr + 4); > > > > wrong -- endian conversion macros not ne

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 01:08:08 David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Wed, 8 Aug 2007 00:04:59 +0100 > > > Please take a look at kernel/irq/handle.c. The irq handler is > > always called with the right dev_id argument. Everything would be a > > complete

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-07 Thread Michael Buesch
On Wednesday 08 August 2007 00:15:47 Jeff Garzik wrote: > Michael Buesch wrote: > > On Wednesday 01 August 2007 10:31:17 Michael Chan wrote: > >> +static irqreturn_t bnx2x_msix_sp_int(int irq, void *dev_instance) > >> +{ > >> + struct net_device *dev = dev_ins

Re: [PATCH 1/3] SSB EXTIF timing & serial port initialization

2007-08-06 Thread Michael Buesch
On Monday 06 August 2007, Aurelien Jarno wrote: > The patch below adds a new file drivers/ssb/driver_extif.c which > contains new SSB EXTIF functions to initializes the timing and the > serial ports. > > Cc: Felix Fietkau <[EMAIL PROTECTED]> > Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]> > +

Re: [PATCH 2/4][SSB] EXTIF serial port initialization

2007-08-06 Thread Michael Buesch
On Monday 06 August 2007, Arnaldo Carvalho de Melo wrote: > Em Mon, Aug 06, 2007 at 01:19:59AM +0200, Aurelien Jarno escreveu: > > The patch below against 2.6.23-rc1-mm2 implements EXTIF serial > > initialization, currently marked as TODO. > > > > It originally comes from the OpenWrt patches. > >

Re: [PATCH 4/4][SSB] Implement ssb_cpu_clock()

2007-08-06 Thread Michael Buesch
On Monday 06 August 2007, Aurelien Jarno wrote: > The patch below against 2.6.23-rc1-mm2 implements the ssb_cpu_clock() > currently doing nothing, and export it. This function is needed to > support the BCM947xx CPUs. > > It originally comes from the OpenWrt patches. > > Cc: Felix Fietkau <[EMAIL

Re: [PATCH 3/4][SSB] MIPS core flash driver

2007-08-06 Thread Michael Buesch
On Monday 06 August 2007, Aurelien Jarno wrote: > The patch below against 2.6.23-rc1-mm2 fixes the size of the flash > window and detect the width of the flash bus (8 or 16 bits). > > It originally comes from the OpenWrt patches. > > Cc: Felix Fietkau <[EMAIL PROTECTED]> > Signed-off-by: Aurelie

Re: [PATCH 2/4][SSB] EXTIF serial port initialization

2007-08-06 Thread Michael Buesch
On Monday 06 August 2007, Aurelien Jarno wrote: > The patch below against 2.6.23-rc1-mm2 implements EXTIF serial > initialization, currently marked as TODO. > > It originally comes from the OpenWrt patches. > > Cc: Felix Fietkau <[EMAIL PROTECTED]> > Signed-off-by: Aurelien Jarno <[EMAIL PROTECTE

Re: [PATCH 1/4][SSB] EXTIF timing initialization

2007-08-06 Thread Michael Buesch
o additional kconfig is needed. > @@ -4,6 +4,7 @@ > * > * Copyright 2005, Broadcom Corporation > * Copyright 2006, 2007, Michael Buesch <[EMAIL PROTECTED]> > + * Copyright 2006, 2007, Felix Fietkau <[EMAIL PROTECTED]> > * > * Licensed under the GNU/GP

Re: b44 compile error on !PCI

2007-08-02 Thread Michael Buesch
On Thursday 02 August 2007, Meelis Roos wrote: > Tryng to compile todays git on SBus-only Sparc64 (Ultra 1), no PCI. b44 > is selectable but fails to compile: > > CC [M] drivers/net/b44.o > drivers/net/b44.c: In function 'b44_sync_dma_desc_for_device': > drivers/net/b44.c:134: error: implicit

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-08-02 Thread Michael Buesch
On Thursday 02 August 2007, Geert Uytterhoeven wrote: > On Thu, 2 Aug 2007, Michael Buesch wrote: > > On Thursday 02 August 2007, Geert Uytterhoeven wrote: > > > On Fri, 27 Jul 2007, Michael Buesch wrote: > > > > The Sonics Silicon Backplane is a mini-bus used on >

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-08-02 Thread Michael Buesch
On Thursday 02 August 2007, Geert Uytterhoeven wrote: > On Fri, 27 Jul 2007, Michael Buesch wrote: > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Devices using the SSB include b44, bcm43xx and various > > Broa

Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

2007-08-01 Thread Michael Buesch
On Wednesday 01 August 2007 10:31:17 Michael Chan wrote: > +typedef struct { > + u8 reserved[64]; > +} license_key_t; No typedef. What is a "license key" used for, anyway? > +#define RUN_AT(x)(jiffies + (x)) That macro does only obfuscate code, in my opinion. If you want jiffies

Re: [PATCH] prevent SSB compilation on s390 part 2

2007-08-01 Thread Michael Buesch
eing selected. But appearantly it looks like this > > doesn't matter at all if it gets selected from somewhere else. > > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > > prevent selection on s390. > > > > Cc: "John W. Linville"

Re: [PATCH FINAL] Merge the Sonics Silicon Backplane subsystem

2007-08-01 Thread Michael Buesch
On Wednesday 01 August 2007, Andrew Morton wrote: > On Sun, 29 Jul 2007 13:24:54 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Sigh. > > s390:

Re: [PATCH 4/7] Add "depth".

2007-07-29 Thread Michael Buesch
On Sunday 29 July 2007 22:21, Corey Hickey wrote: > > Compare depth against (~0U/2)-1? What's that doing? Should probably add a > > comment. > > ~0U/2 - 1 is the maximum value depth can be, based on how it is used in > indexing q->dep. I agree, though, that deserves a comment. Actually, > I'll

Re: [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl()

2007-07-29 Thread Michael Buesch
On Sunday 29 July 2007 21:09, Satyam Sharma wrote: > Hi Michael, > > > On Sun, 29 Jul 2007, Michael Buesch wrote: > > > On Sunday 29 July 2007 20:34:46 Satyam Sharma wrote: > > > (2) !(dev->flags & IFF_UP) is bogus because the functions of this ioctl > &

Re: [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl()

2007-07-29 Thread Michael Buesch
On Sunday 29 July 2007 20:34:46 Satyam Sharma wrote: > (2) !(dev->flags & IFF_UP) is bogus because the functions of this ioctl > can (and should) be allowed even when the interface is not up and running. Are you _sure_? This function does poke with the device hardware. It might return crap or even

Re: [PATCH 4/7] Add "depth".

2007-07-29 Thread Michael Buesch
On Sunday 29 July 2007 09:08:51 Corey Hickey wrote: > p = d; > n = q->dep[d].next; > @@ -215,7 +216,7 @@ static unsigned int sfq_drop(struct Qdisc *sch) > drop a packet from it */ > > if (d > 1) { > - sfq_index x = q->dep[d+SFQ_DEPTH].next; > + s

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 22:12:49 Andrew Morton wrote: > On Fri, 27 Jul 2007 21:43:59 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > Sure, but why is the locking interruptible rather than plain old > > > mutex_lock()? > > > > Hm, well. We ho

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 21:38:53 Andrew Morton wrote: > > > > +static ssize_t ssb_pci_attr_sprom_show(struct device *pcidev, > > > > + struct device_attribute *attr, > > > > + char *buf) > > > > +{ > > > > + struct pci_d

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 21:21:20 John W. Linville wrote: > On Fri, Jul 27, 2007 at 06:57:20PM +0200, Michael Buesch wrote: > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Devices using the SSB include b44, bcm43xx and

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 21:03:18 Andrew Morton wrote: > On Fri, 27 Jul 2007 18:57:20 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Devices using

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 16:01, Bryan Wu wrote: > drivers/net/e100.c: ns->tx_window_errors += > le32_to_cpu(s->tx_late_collisions); > drivers/net/e100.c: ns->tx_carrier_errors += > le32_to_cpu(s->tx_lost_crs); > drivers/net/e100.c: ns->tx_fifo_errors += > le32_

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 14:07:44 Bryan Wu wrote: > @@ -483,9 +487,12 @@ > > void setup_mac_addr(u8 * mac_addr) > { > + u32 addr_low = le32_to_cpu(*(u32 *) & mac_addr[0]); > + u16 addr_hi = le16_to_cpu(*(u16 *) & mac_addr[4]); > + > /* this depends on a little-endian machine */ > -

Re: [PATCH try#2] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > +#if defined(CONFIG_BFIN_MAC_USE_L1) > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > +#else > +# define bfin_mac_alloc(dma_handle, size) \ > + dma_al

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-15 Thread Michael Buesch
On Sunday 15 July 2007 11:16:56 Bryan Wu wrote: > In current Blackfin DMA allocation/free, the return value from > bfin_mac_alloc() is used as the dma_handle, here it is the > tx_desc/rx_desc. > The "dma_handle" is useless in the following code. I think a comment has to be added, at least, as it

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Michael Buesch
On Saturday 14 July 2007 21:49:21 Mike Frysinger wrote: > On 7/14/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > > On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > > > +static int __init bf537mac_probe(struct net_device *dev) > > > +{ > > > + s

Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-14 Thread Michael Buesch
On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > +#if defined(CONFIG_BFIN_MAC_USE_L1) > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > +# define bfin_mac_free(dma_handle, ptr)l1_data_sram_free(ptr) > +#else > +# define bfin_mac_alloc(dma_handle, size) \ > + dma_

Re: [PATCH #2] Merge the Sonics Silicon Backplane subsystem

2007-07-14 Thread Michael Buesch
On Saturday 14 July 2007 19:26:05 Christoph Hellwig wrote: > On Sat, Jul 14, 2007 at 07:18:20PM +0200, Michael Buesch wrote: > > --- /dev/null > > +++ b/drivers/ssb/Makefile > > @@ -0,0 +1,11 @@ > > +ssb-builtin-drivers-y += >

[PATCH] b44: Port to SSB

2007-07-12 Thread Michael Buesch
PROTECTED]) * Copyright (C) 2006 Broadcom Corporation. + * Copyright (C) 2007 Michael Buesch <[EMAIL PROTECTED]> * * Distribute under GPL. */ @@ -21,17 +24,18 @@ #include #include #include +#include #include #include #include + #include "b44.h" #define

Re: [PATCH 2.6] SoftMAC : fix ESSID problem

2007-07-09 Thread Michael Buesch
; + mac->associnfo.associating = 0; > + mac->associnfo.associated = 0; > + } > goto out; > } else { > mac->associnfo.associating = 0; > Ac

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Michael Buesch
On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote: > well, FWIW when I started looking at adding these flags I looked in various > subsystems in the kernel and picked an implementation that suited. Guess what > pci.h has? ...: > > unsigned int msi_enabled:1; > unsigned int msix_enable

Re: RESEND [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-07-01 Thread Michael Buesch
On Sunday 01 July 2007 20:56:01 [EMAIL PROTECTED] wrote: > These changes allow driver close routine to be called during module unload, > to clean-up buffers and other software resources, flush queues etc. Also, > hardware is reset to pristine state. > > Signed-off-by: Dhananjay Phadke <[EMAIL PRO

Re: [PATCH] b44: power down PHY when interface down

2007-07-01 Thread Michael Buesch
On Sunday 01 July 2007 17:00:06 Lennert Buytenhek wrote: > A multimeter should do the trick, but I would advise against this > if you're not totally comfortable with hacking hardware. Ok, the resistor on the board is 100ohm, which is too big according to the docs of the extender. So what I tried i

Re: [PATCH] b44: power down PHY when interface down

2007-07-01 Thread Michael Buesch
On Sunday 01 July 2007 17:00:06 Lennert Buytenhek wrote: > On Sun, Jul 01, 2007 at 12:23:16PM +0200, Michael Buesch wrote: > > > > More or less. You can't add the resistances like that, since the > > > bus isolation chip buffers the IDSEL signal, but it is correct t

Re: [PATCH] b44: power down PHY when interface down

2007-07-01 Thread Michael Buesch
On Sunday 01 July 2007 14:49:23 Török Edvin wrote: > On 6/30/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > This is a non-standard formatting for comments, please follow > > Coding style: > > Thanks, I have updated the patch. > > When the interface is down (or driver removed), the Broad

Re: [PATCH] b44: power down PHY when interface down

2007-07-01 Thread Michael Buesch
On Sunday 01 July 2007 01:17:34 Lennert Buytenhek wrote: > More or less. You can't add the resistances like that, since the > bus isolation chip buffers the IDSEL signal, but it is correct that > if the host's IDSEL resistor is larger than a certain value, the > combination of the resistive coupli

Re: RESEND [PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers

2007-07-01 Thread Michael Buesch
On Sunday 01 July 2007 04:43:27 [EMAIL PROTECTED] wrote: > This patch updates the various access routines to access different > control and status settings present in different register locations. > This will fix problems related to working of different ports in > multi Port card. > > Signed-off b

Re: [PATCH] b44: power down PHY when interface down

2007-06-30 Thread Michael Buesch
On Sunday 01 July 2007 00:03:01 Lennert Buytenhek wrote: > On Sat, Jun 30, 2007 at 11:53:25PM +0200, Michael Buesch wrote: > > > > When the interface is down (or driver removed), the BroadCom 44xx card > > > remains > > > powered on, and both its MAC and PHY is

Re: [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-06-30 Thread Michael Buesch
On Saturday 30 June 2007 22:38:47 [EMAIL PROTECTED] wrote: > These changes allow driver close routine to be called during module unload, > to clean-up buffers and other software resources, flush queues etc. Also, > hardware is reset to pristine state. > > Signed-off-by: Dhananjay Phadke <[EMAIL P

Re: [PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers

2007-06-30 Thread Michael Buesch
On Saturday 30 June 2007 22:38:46 [EMAIL PROTECTED] wrote: > This patch updates the various access routines to access different > control and status settings present in different register locations. > This will fix problems related to working of different ports in > multi Port card. > > Signed-off

Re: [PATCH] b44: power down PHY when interface down

2007-06-30 Thread Michael Buesch
On Saturday 30 June 2007 13:47:35 Török Edvin wrote: > When the interface is down (or driver removed), the BroadCom 44xx card remains > powered on, and both its MAC and PHY is using up power. > This patch makes the driver issue a MAC_CTRL_PHY_PDOWN when the interface > is halted, and does a partial

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-23 Thread Michael Buesch
On Saturday 23 June 2007 02:09:18 C. Scott Ananian wrote: > > > diff -ruHpN -X dontdiff linux-2.6.22-rc5-orig/include/net/ip6_rdnss.h > > > linux-2.6.22-rc5/include/net/ip6_rdnss.h > > > --- linux-2.6.22-rc5-orig/include/net/ip6_rdnss.h1969-12-31 > > > 19:00:00.0 -0500 > > > +++ linux-2.6.2

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-22 Thread Michael Buesch
On Saturday 23 June 2007 01:26:19 C. Scott Ananian wrote: > +struct rdns6_info { > +   rwlock_tlock; > +   struct timer_list   expiry_timer; > +   struct rdns6_entry *rdnss_list; > +   struct inet6_dev *  in6_dev; /* back pointer for netlink notify */ > +

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-22 Thread Michael Buesch
On Saturday 23 June 2007 01:26:19 C. Scott Ananian wrote: > Attached is my first draft of a patch to implement RDNSS-in-Router > Advertisements support for IPv6 ( > http://tools.ietf.org/html/draft-jeong-dnsop-ipv6-dns-discovery-12 ) > as implemented in radvd ( http://www.litech.org/radvd/ ). It >

Re: [PATCH 1/3] NetXen: Fix MSI issues by using PCI function 0

2007-06-22 Thread Michael Buesch
On Friday 22 June 2007 10:40:41 Mithlesh Thukral wrote: > NetXen: Fix issue of MSI not working correctly > NetXen driver uses PCI function 0 to provide the functionality of MSI. > The patch makes driver check the bus master bit for function 0 and > enable it after the card initialization. > > Sign

Re: [PATCH 3/3] NetXen: Fix the rmmod error on PBlades due incorrect cleanup

2007-06-22 Thread Michael Buesch
On Friday 22 June 2007 10:42:38 Mithlesh Thukral wrote: > diff --git a/drivers/net/netxen/netxen_nic_hw.c > b/drivers/net/netxen/netxen_nic_hw.c > index 4e958c9..f0df6fb 100644 > --- a/drivers/net/netxen/netxen_nic_hw.c > +++ b/drivers/net/netxen/netxen_nic_hw.c > @@ -378,6 +378,7 @@ int netxen_ni

[PATCH] b44-ssb: Fix IRQ routing bits on the backplane

2007-06-17 Thread Michael Buesch
b44 driver. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Cc: Maximilian Engelhardt <[EMAIL PROTECTED]> Cc: Gary Zambrano <[EMAIL PROTECTED]> Index: bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c === -

Re: b44: high ping times with wireless-dev

2007-06-17 Thread Michael Buesch
On Sunday 17 June 2007 14:03:30 Maximilian Engelhardt wrote: > On Sunday 17 June 2007, Michael Buesch wrote: > > On Saturday 16 June 2007 23:27:43 Maximilian Engelhardt wrote: > > > [...] > > > ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 10 > > > ACPI: P

[PATCH] Fix stupid wol variable overflow bug

2007-06-17 Thread Michael Buesch
This bug was introduced by me. val is 16bit, but the read value is 32bit. Seems like I was smoking crack when porting that part of the driver. I guess that's the last stupid bug in these 4 lines of code. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: bu3sch-wireless-dev/driv

Re: b44: high ping times with wireless-dev

2007-06-17 Thread Michael Buesch
On Sunday 17 June 2007 12:55:39 Michael Buesch wrote: > On Saturday 16 June 2007 23:27:43 Maximilian Engelhardt wrote: > > [...] > > ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 10 > > ACPI: PCI Interrupt :02:02.0[A] -> Link [LNKD] -> GSI 10 (level, low) > &g

Re: b44: high ping times with wireless-dev

2007-06-17 Thread Michael Buesch
On Saturday 16 June 2007 23:27:43 Maximilian Engelhardt wrote: > [...] > ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 10 > ACPI: PCI Interrupt :02:02.0[A] -> Link [LNKD] -> GSI 10 (level, low) -> > IRQ 10 > ssb: Sonics Silicon Backplane found on PCI device :02:02.0 > b44.c:v2.0 > eth0: B

Re: b44: high ping times with wireless-dev

2007-06-16 Thread Michael Buesch
On Sunday 17 June 2007 02:42:18 Maximilian Engelhardt wrote: > I did build a kernel without the three mentioned above but the problem is > still the same. I also did remove everything but eth0 on interrupt 10 so the > only device using that interrupt is eth0 and then the card completely stopped

Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules

2007-06-15 Thread Michael Buesch
On Friday 15 June 2007 14:20:34 Keir Fraser wrote: > > On 15/6/07 13:11, "Michael Buesch" <[EMAIL PROTECTED]> wrote: > > >> No use of the following please: > >> If (foo) return 1; else return 0; > >> Is clearer as: > >> Return foo; &

  1   2   3   4   5   6   >