Re: [PATCH net-next v2 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

On Wed, Jul 27, 2016 at 12:31 AM, zhuyj wrote: > + if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { ><-Does this happen very rarely? If so, > > if (unlikely(vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { is > better? This is not in the

Re: question: tg3 driver/nics and inconsistent RX ring count

On Tue, Jul 26, 2016 at 1:32 PM, Michal Soltys wrote: > On 2016-07-26 22:06, Alexander Duyck wrote: >> On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: >>> Hi, >>> >>> I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 >>> servers -

[PATCH net-next v2 0/3] bnxt_en: Improve ntuple filters and add new IDs.

Improve ntuple filters and add some new PCI device IDs. Please review for net-next. Michael Chan (2): bnxt_en: Improve ntuple filters by checking destination MAC address. bnxt_en: Add new NPAR and dual media device IDs. Vasundhara Volam (1): bnxt_en: Log a message, if enabling NTUPLE

[PATCH net-next v2 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

From: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> If there are not enough resources to enable ntuple filtering, log a warning message. v2: Use single message and add missing newline. Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Cha

[PATCH net-next v2 3/3] bnxt_en: Add new NPAR and dual media device IDs.

Add 5741X/5731X NPAR device IDs and dual media SFP/10GBase-T device IDs. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 39 ++- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/net/et

[PATCH net-next v2 1/3] bnxt_en: Improve ntuple filters by checking destination MAC address.

using the correct index for the destination MAC address. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 ++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++ 2 files changed, 24 insertions(+), 3 deletions(-)

[PATCH net-next 3/3] bnxt_en: Add new NPAR and dual media device IDs.

Add 5741X/5731X NPAR device IDs and dual media SFP/10GBase-T device IDs. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 39 ++- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 1/3] bnxt_en: Improve ntuple filters by checking destination MAC address.

using the correct index for the destination MAC address. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 ++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++ 2 files changed, 24 insertions(+), 3 deletions(-)

[PATCH net-next 0/3] bnxt_en: Improve ntuple filters and add new IDs.

Improve ntuple filters and add some new PCI device IDs. Please review for net-next. Michael Chan (2): bnxt_en: Improve ntuple filters by checking destination MAC address. bnxt_en: Add new NPAR and dual media device IDs. Vasundhara Volam (1): bnxt_en: Log a message, if enabling NTUPLE

[PATCH net-next 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

From: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> If there are not enough resources to enable ntuple filtering, log a warning message. Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- dr

Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

STATE_CLOSING or 0. > > Reported-by: coverity (CID 1339583) > Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Thanks Florian. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

On Fri, Jul 15, 2016 at 11:20 PM, David Miller wrote: > From: Florian Fainelli > Date: Fri, 15 Jul 2016 16:42:01 -0700 > >> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp) >> for (i = 0; i < bp->tx_nr_rings; i++) { >>

[PATCH net-next 3/6] bnxt_en: Workaround Nitro A0 hardware RX bug (part 2).

dharan <prashant.sreedha...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 +++-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 12 ++-- 2 files changed, 25 insertions(+), 4 deleti

[PATCH net-next 5/6] bnxt_en: Workaround Nitro A0 RX hardware bug (part 4).

adcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 64 +-- 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom

[PATCH net-next 6/6] bnxt_en: Add BCM58700 PCI device ID for NS2 Nitro.

<vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index

[PATCH net-next 2/6] bnxt_en: Workaround Nitro A0 hardware RX bug (part 1).

. Add infrastructure to allow 2 contexts (RSS and CoS) per VNIC. Allocate and configure the CoS context for Nitro A0. Signed-off-by: Prashant Sreedharan <prashant.sreedha...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadco

[PATCH net-next 1/6] bnxt_en: Add basic support for Nitro in North Star 2.

ed-off-by: Prashant Sreedharan <prashant.sreedha...@broadcom.com> Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 38 --- drivers/net/ether

[PATCH net-next 0/6] bnxt_en: Add support for NS2 Nitro.

This series adds support for the embedded version of the ethernet controller (Nitro) in the North Star 2 SoC. There are a number of features not supported and a software workaround for a hardware rx bug is required for Nitro A0. Please review. Prashant Sreedharan (6): bnxt_en: Add basic

[PATCH net-next 4/6] bnxt_en: Workaround Nitro A0 hardware RX bug (part 3).

: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 81 ++- 1 file changed, 80 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bn

Re: [PATCH] bnxt_en: initialize rc to zero to avoid returning garbage

returned by initializing rc to 0. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [patch -next] bnxt: fix a condition

n: Add GRO logic for BCM5731X chips.') > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks. The fix is correct. Acked-by: Michael Chan <michael.c...@broadcom.com>

[PATCH net-next 03/11] bnxt_en: Do function reset on the 1st PF open only.

will always do function reset on every open. If there is an AER event, we will always do function reset. Signed-off-by: Michael Chan <michael.c...@broadocm.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 22 -- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files chang

[PATCH net-next 02/11] bnxt_en: Update firmware spec. to 1.3.0.

And update driver version to 1.3.0. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 11 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 87 ++- 2 files changed, 66 insertions(+), 32 deletions(-) diff

[PATCH net-next 10/11] bnxt_en: Assign netdev->dev_port with port ID.

This is useful for multi-function devices. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c

[PATCH net-next 08/11] bnxt_en: Increase maximum supported MTU to 9500.

From: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Vasundhara Volam <vasundhara-v.vo...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH net-next 07/11] bnxt_en: Enable MRU enables bit when configuring VNIC MRU.

For correctness, the MRU enables bit must be set when passing the MRU to firmware during vnic configuration. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next 11/11] bnxt_en: Allow statistics DMA to be configurable using ethtool -C.

The allowable range is 0.25 seconds to 1 second interval. Default is 1 second. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 + drivers/net/ethernet/br

[PATCH net-next 05/11] bnxt_en: Request firmware reset after successful firwmare update

From: Rob Swindell <rob.swind...@broadcom.com> Upon successful mgmt processor firmware update, request a self reset upon next PCIe reset (e.g. system reboot). Signed-off-by: Rob Swindell <rob.swind...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- dr

[PATCH net-next 09/11] bnxt_en: Allow promiscuous mode for VF if default VLAN is enabled.

With a default VLAN, the VF has its own VLAN domain and it can receive all traffic within that domain. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

[PATCH net-next 00/11] bnxt_en updates for net-next.

Mostly small miscellaneous changes. Please review for net-next. Thanks. Michael Chan (7): bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops. bnxt_en: Update firmware spec. to 1.3.0. bnxt_en: Do function reset on the 1st PF open only. bnxt_en: Enable MRU enables

[PATCH net-next 06/11] bnxt_en: Add support for firmware updates for additional processors.

From: Rob Swindell <rob.swind...@broadcom.com> Add support to the Ethtool FLASHDEV command handler for additional firmware types to cover all the on-chip processors. Signed-off-by: Rob Swindell <rob.swind...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com>

[PATCH net-next 04/11] bnxt_en: Add support for updating flash more securely

From: Rob Swindell <rob.swind...@broadcom.com> To support Secure Firmware Update, we must be able to allocate a staging area in the Flash. This patch adds support for the "update" type to tell firmware to do that. Signed-off-by: Rob Swindell <rob.swind...@broadcom.com>

[PATCH net-next 01/11] bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops.

Returning 0 for doing nothing is confusing to the user. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtoo

Re: [net-next PATCH v3 06/17] bnxt: Move GENEVE support from hard-coded port to using port notifier

ange the GENEVE port > number if we need to in the future. > > Signed-off-by: Alexander Duyck <adu...@mirantis.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [net-next PATCH v2 05/17] bnxt: Update drivers to support unified UDP encapsulation offload functions

t; Looks good, except that the last item in the description above is actually done in the next patch. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port

On Mon, Jun 13, 2016 at 11:41 AM, Jesse Gross wrote: > On Mon, Jun 13, 2016 at 10:48 AM, Alexander Duyck wrote: >> This change replaces the network device operations for adding or removing a >> VXLAN port with operations that are more generically defined to

[PATCH net-next 01/11] bnxt_en: Add function for VF driver to query default VLAN.

netdev_update_features() to fix up the VLAN features as necessary. Also, VLAN strip mode must be enabled to strip out the default VLAN tag. Only allow VF default VLAN to be set if the firmware spec is >= 1.2.1. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bn

[PATCH net-next 10/11] bnxt_en: Don't allow autoneg on cards that don't support it.

. The ethtool set_settings() call will check this field before proceeding with autoneg. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadco

[PATCH net-next 05/11] bnxt_en: Add PCI device ID for 57404 NPAR devices.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 9d785e6..1cf885a 100644 --- a/drive

[PATCH net-next 11/11] bnxt_en: Support new ETHTOOL_{G|S}LINKSETTINGS API.

To fully support 25G and 50G link settings. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 198 +- 1 file changed, 118 insertions(+), 80 deletions(-) diff --git a/drivers/net/ethernet/broadco

[PATCH net-next 03/11] bnxt_en: Handle VF_CFG_CHANGE event from firmware.

When the VF driver gets this event, the VF configuration has changed (such as default VLAN). The VF driver will initiate a silent reset to pick up the new configuration. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 + d

[PATCH net-next 06/11] bnxt_en: Define the supported chip numbers.

Define all the supported chip numbers and chip categories. Store the chip_num returned by firmware. If the call to get the version and chip number fails, we should abort. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 - d

[PATCH net-next 04/11] bnxt_en: Enable NPAR (NIC Partitioning) Support.

<sbadd...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 +++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++--- 3 files changed, 1

[PATCH net-next 00/11] bnxt_en: Updates for net-next.

-Add default VLAN support for VFs. -Add NPAR (NIC partioning) support. -Add support for new device 5731x and 5741x. GRO logic is different. -Support new ETHTOOL_{G|S}LINKSETTINGS. Please review. Thanks. Michael Chan (10): bnxt_en: Add function for VF driver to query default VLAN. bnxt_en

[PATCH net-next 09/11] bnxt_en: Add BCM5731X and BCM5741X device IDs.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c

[PATCH net-next 02/11] bnxt_en: Add new function bnxt_reset().

-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 --- 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 6

[PATCH net-next 07/11] bnxt_en: Refactor bnxt_gro_skb().

Newer chips require different logic to handle GRO packets. So refactor the code so that we can call different functions depending on the chip. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 52 --- drive

[PATCH net-next 08/11] bnxt_en: Add GRO logic for BCM5731X chips.

is added to adjust the offsets if it is a loopback packet. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 89 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 16 +- 2 files changed, 103 insertions(+), 2 del

[PATCH net 3/3] bnxt_en: Simplify VLAN receive logic.

Since both CTAG and STAG rx acceleration must be enabled together, we only need to check one feature flag (NETIF_F_HW_VLAN_CTAG_RX) before calling __vlan_hwaccel_put_tag(). Signed-off-by: Michael Chan <mc...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net 2/3] bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration together.

The hardware can only be set to strip or not strip both the VLAN CTAG and STAG. It cannot strip one and not strip the other. Add logic to bnxt_fix_features() to toggle both feature flags when the user is toggling one of them. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- d

[PATCH net 0/3] bnxt_en: Bug fixes.

Fix a race condition and VLAN rx acceleration logic. Michael Chan (3): bnxt_en: Fix tx push race condition. bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration together. bnxt_en: Simplify VLAN receive logic. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 47

[PATCH net 1/3] bnxt_en: Fix tx push race condition.

Set the is_push flag in the software BD before the tx data is pushed to the chip. It is possible to get the tx interrupt as soon as the tx data is pushed. The tx handler will not handle the event properly if the is_push flag is not set and it will crash. Signed-off-by: Michael Chan <michae

[PATCH net-next v2 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO

aparde <ajit.khapa...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 11 ++ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 121 +

[PATCH net-next v2 6/9] bnxt_en: Fix length value in dmesg log firmware error message.

The len value in the hwrm error message is wrong. Use the properly adjusted value in the variable len. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/et

[PATCH net-next v2 3/9] bnxt_en: Report PCIe link speed and width during driver load

; Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 59b2e36..ba0c3e5 100644

[PATCH net-next v2 8/9] bnxt_en: Add BCM57314 device ID.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 6def145..f2ac7da 100644 --- a/drive

[PATCH net-next v2 5/9] bnxt_en: Improve the delay logic for firmware response.

results in much faster bring-up/down time: Before the patch: time ip link set p4p1 up real0m0.120s user0m0.001s sys 0m0.009s After the patch: time ip link set p4p1 up real0m0.030s user0m0.000s sys 0m0.010s Signed-off-by: Michael Chan <michael.c...@broadcom.

[PATCH net-next v2 4/9] bnxt_en: Reduce maximum ring pages if page size is 64K.

The chip supports 4K/8K/64K page sizes for the rings and we try to match it to the CPU PAGE_SIZE. The current page size limits for the rings are based on 4K/8K page size. If the page size is 64K, these limits are too large. Reduce them appropriately. Signed-off-by: Michael Chan <michae

[PATCH net-next v2 7/9] bnxt_en: Simplify and improve unsupported SFP+ module reporting.

that and report any unsupported SFP+ module status. Delete the unnecessary last_port_module_event. Call this function at the end of bnxt_open to report unsupported module already plugged in. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next v2 1/9] bnxt_en: Fix invalid max channel parameter in ethtool -l.

value, and set max_rx/max_tx to 0 if it is non-zero. Signed-off-by: Satish Baddipadige <sbadd...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -

[PATCH net-next v2 0/9] bnxt_en: updates for net-next.

driver load Michael Chan (6): bnxt_en: Reduce maximum ring pages if page size is 64K. bnxt_en: Improve the delay logic for firmware response. bnxt_en: Fix length value in dmesg log firmware error message. bnxt_en: Simplify and improve unsupported SFP+ module reporting. bnxt_en: Add BCM57314

[PATCH net-next v2 9/9] bnxt_en: Use dma_rmb() instead of rmb().

Use the weaker but more appropriate dma_rmb() to order the reading of the completion ring. Suggested-by: Ajit Khaparde <ajit.khapa...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 ins

Re: [PATCH net-next 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO

On Sat, May 14, 2016 at 6:31 PM, Ben Hutchings <b...@decadent.org.uk> wrote: > On Sat, 2016-05-14 at 20:29 -0400, Michael Chan wrote: >> From: Ajit Khaparde <ajit.khapa...@broadcom.com> > [...] >> + /* Read A2 portion of the EEPROM */ >> +

[PATCH net-next 6/9] bnxt_en: Fix length value in dmesg log firmware error message.

The len value in the hwrm error message is wrong. Use the properly adjusted value in the variable len. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/et

[PATCH net-next 7/9] bnxt_en: Simplify and improve unsupported SFP+ module reporting.

that and report any unsupported SFP+ module status. Delete the unnecessary last_port_module_event. Call this function at the end of bnxt_open to report unsupported module already plugged in. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next 3/9] bnxt_en: Report PCIe link speed and width during driver load

; Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 59b2e36..ba0c3e5 100644

[PATCH net-next 9/9] bnxt_en: Use dma_rmb() instead of rmb().

Use the weaker but more appropriate dma_rmb() to order the reading of the completion ring. Suggested-by: Ajit Khaparde <ajit.khapa...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 ins

[PATCH net-next 1/9] bnxt_en: Fix invalid max channel parameter in ethtool -l.

value, and set max_rx/max_tx to 0 if it is non-zero. Signed-off-by: Satish Baddipadige <sbadd...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -

[PATCH net-next 4/9] bnxt_en: Reduce maximum ring pages if page size is 64K.

The chip supports 4K/8K/64K page sizes for the rings and we try to match it to the CPU PAGE_SIZE. The current page size limits for the rings are based on 4K/8K page size. If the page size is 64K, these limits are too large. Reduce them appropriately. Signed-off-by: Michael Chan <michae

[PATCH net-next 8/9] bnxt_en: Add BCM57314 device ID.

Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 6def145..f2ac7da 100644 --- a/drive

[PATCH net-next 5/9] bnxt_en: Improve the delay logic for firmware response.

results in much faster bring-up/down time: Before the patch: time ip link set p4p1 up real0m0.120s user0m0.001s sys 0m0.009s After the patch: time ip link set p4p1 up real0m0.030s user0m0.000s sys 0m0.010s Signed-off-by: Michael Chan <michael.c...@broadcom.

[PATCH net-next 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO

From: Ajit Khaparde <ajit.khapa...@broadcom.com> Add support to fetch the SFP EEPROM settings from the firmware and display it via the ethtool -m command. We support SFP+ and QSFP modules. Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com> Signed-off-by: Michael Cha

[PATCH net-next 0/9] bnxt_en: updates for net-next.

Non-critical bug fixes, improvements, a new ethtool feature, and a new device ID. Michael Chan (9): bnxt_en: Fix invalid max channel parameter in ethtool -l. bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO bnxt_en: Report PCIe link speed and width during driver load

[PATCH net 0/2] bnxt_en: Add workaround to detect bad opaque in rx completion.

2-part workaround for this hardware bug. Michael Chan (2): bnxt_en: Add workaround to detect bad opaque in rx completion (part 1) bnxt_en: Add workaround to detect bad opaque in rx completion (part 2) drivers/net/ethernet/broadcom/bnxt/bnxt.c | 63 +++ drivers

[PATCH net 1/2] bnxt_en: Add workaround to detect bad opaque in rx completion (part 1)

will then schedule a workqueue to reset the function. This patch adds the logic to keep track of the next rx consumer index. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files c

[PATCH net 2/2] bnxt_en: Add workaround to detect bad opaque in rx completion (part 2)

new buffers. The function will be reset from a workqueue. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 60 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 61 insertions(+) diff

[PATCH net 2/2] bnxt_en: Setup multicast properly after resetting device.

off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index f33ff20..9d4e8

[PATCH net 0/2] bnxt_en: 2 bug fixes.

Fix crash on ppc64 due to missing memory barrier and restore multicast after reset. Michael Chan (2): bnxt_en: Need memory barrier when processing the completion ring. bnxt_en: Setup multicast properly after resetting device. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 23

[PATCH net 1/2] bnxt_en: Need memory barrier when processing the completion ring.

system, causing it to crash. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 72eb29e..f

Re: [RFC PATCH 4/5] bnxt: Add support for segmentation of tunnels with outer checksums

On Fri, Apr 29, 2016 at 2:31 PM, Alexander Duyck wrote: > Okay so if that is the case we may want to make it so that we ignore > checksum for both IPv4 and IPv6 and then we can just provide it via > GSO_PARTIAL in the case we want it. Otherwise you are technically >

Re: [RFC PATCH 4/5] bnxt: Add support for segmentation of tunnels with outer checksums

On Fri, Apr 29, 2016 at 2:17 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Wed, Apr 27, 2016 at 9:32 PM, Michael Chan <michael.c...@broadcom.com> > wrote: >> On Wed, Apr 27, 2016 at 8:21 AM, Alexander Duyck >> <alexander.du...@gmail.com> wrote:

Re: [RFC PATCH 4/5] bnxt: Add support for segmentation of tunnels with outer checksums

On Wed, Apr 27, 2016 at 8:21 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Tue, Apr 26, 2016 at 10:55 PM, Michael Chan > <michael.c...@broadcom.com> wrote: >> On Tue, Apr 19, 2016 at 12:06 PM, Alexander Duyck <adu...@mirantis.com> >> wrote:

Re: [RFC PATCH 4/5] bnxt: Add support for segmentation of tunnels with outer checksums

On Tue, Apr 19, 2016 at 12:06 PM, Alexander Duyck wrote: > This patch assumes that the bnxt hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP and GRE headers. > > I have no means of testing

[PATCH net 2/3] bnxt_en: Limit RX BD pages to be no bigger than 32K.

up to 32K. Replace PAGE_SIZE with BNXT_RX_PAGE_SIZE in all appropriate places related to the rx aggregation ring logic. The next patch will add additional logic to divide the page into 32K chunks for aggrgation ring buffers if PAGE_SIZE is bigger than BNXT_RX_PAGE_SIZE. Signed-off-by: Michael

[PATCH net 3/3] bnxt_en: Divide a page into 32K buffers for the aggregation ring if necessary.

. Since each page can be referenced by multiple buffer entries, call get_page() as needed to get the proper reference count. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 35 ++- drivers/net/ethernet/broadco

[PATCH net 1/3] bnxt_en: Don't fallback to INTA on VF.

Only MSI-X can be used on a VF. The driver should fail initialization if it cannot successfully enable MSI-X. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH net 0/3] bnxt_en: Bug fixes for net.

Only use MSIX on VF, and fix rx page buffers on architectures with PAGE_SIZE >= 64K. Michael Chan (3): bnxt_en: Don't fallback to INTA on VF. bnxt_en: Limit RX BD pages to be no bigger than 32K. bnxt_en: Divide a page into 32K buffers for the aggregation ring if necessary. drivers/

[PATCH net-next 0/4] bnxt_en: Update for net-next

Misc. changes for link speed and VF MAC address change. Michael Chan (4): bnxt_en: Disallow forced speed for 10GBaseT devices. bnxt_en: Shutdown link when device is closed. bnxt_en: Call firmware to approve VF MAC address change. bnxt_en: Add async event handling for speed config changes

[PATCH net-next 2/4] bnxt_en: Shutdown link when device is closed.

Let firmware know that the driver is giving up control of the link so that it can be shutdown if no management firmware is running. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 16 1 file changed, 16 insertions(+)

[PATCH net-next 3/4] bnxt_en: Call firmware to approve VF MAC address change.

Some hypervisors (e.g. ESX) require the VF MAC address to be forwarded to the PF for approval. In Linux PF, the call is not forwarded and the firmware will simply check and approve the MAC address if the PF has not previously administered a valid MAC address for this VF. Signed-off-by: Michael

[PATCH net-next 4/4] bnxt_en: Add async event handling for speed config changes.

speeds. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index c83a5a1..4645c44

[PATCH net-next 1/4] bnxt_en: Disallow forced speed for 10GBaseT devices.

10GBaseT devices must autonegotiate to determine master/slave clocking. Disallow forced speed in ethtool .set_settings() for these devices. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + drivers/net/ethernet/broadco

[PATCH net-next v2 5/9] bnxt_en: Add get_eee() and set_eee() ethtool support.

Allow users to get|set EEE parameters. v2: Added comment for preserving the tx_lpi_timer value in get_eee. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 76 +++ 1 file changed, 76 insertions(+) diff

[PATCH net-next v2 9/9] bnxt_en: Improve ethtool .get_settings().

If autoneg is off, we should always report the speed and duplex settings even if it is link down so the user knows the current settings. The unknown speed and duplex should only be used for autoneg when link is down. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drive

[PATCH net-next v2 4/9] bnxt_en: Add EEE setup code.

ter is set, it will call bnxt_hwrm_set_eee(). Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 58 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethto

[PATCH net-next v2 6/9] bnxt_en: Set async event bits when registering with the firmware.

Currently, the driver only sets bit 0 of the async_event_fwd fields. To be compatible with the latest spec, we need to set the appropriate event bits handled by the driver. We should be handling link change and PF driver unload events, so these 2 bits should be set. Signed-off-by: Michael Chan

[PATCH net-next v2 8/9] bnxt_en: Check for valid forced speed during ethtool -s.

Check that the forced speed is a valid speed supported by firmware. If not supported, return -EINVAL. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 48 ++- 1 file changed, 38 insertions(+), 10 del

[PATCH net-next v2 7/9] bnxt_en: Add unsupported SFP+ module warnings.

Add the PORT_CONN_NOT_ALLOWED async event handling logic. The driver will print an appropriate warning to reflect the SFP+ module enforcement policy done in the firmware. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next v2 0/9] bnxt_en: Updates for net-next.

Update to latest firmware interface, add EEE feature, unsupported SFP+ module warning, and ethtool -s improvements. v2: Removed the GEEPROM patch and added more comments to the get_eee patch. Michael Chan (9): bnxt_en: Update to Firmware 1.2.2 spec. bnxt_en: Improve flow control autoneg

[PATCH net-next v2 3/9] bnxt_en: Add basic EEE support.

Get EEE capability and the initial EEE settings from firmware. Add "EEE is active | not active" to link up dmesg. Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 82 ++- drivers/net/ethernet/broa

<    2   3   4   5   6   7   8   9   10   11   >