Re: [PATCH 0/2] Change struct page layout for page_pool

2021-04-19 Thread Michael Ellerman
"Matthew Wilcox (Oracle)" writes: > The first patch here fixes two bugs on ppc32, and mips32. It fixes one > bug on arc and arm32 (in certain configurations). It probably makes > sense to get it in ASAP through the networking tree. I'd like to see > testing on those four architectures if possib

Re: [PATCH v2 0/8] Implement EBPF on powerpc32

2021-04-10 Thread Michael Ellerman
On Mon, 22 Mar 2021 16:37:45 + (UTC), Christophe Leroy wrote: > This series implements extended BPF on powerpc32. For the implementation > details, see the patch before the last. > > The following operations are not implemented: > > case BPF_ALU64 | BPF_DIV | BPF_X: /* dst /= sr

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-03 Thread Michael Ellerman
"Naveen N. Rao" writes: > On 2021/03/02 11:35AM, Jiri Olsa wrote: >> On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: >> > >> > >> > On 3/1/21 11:04 AM, Jiri Olsa wrote: >> > > When testing uprobes we the test gets GEP (Global Entry Point) >> > > address from kallsyms, but then the

Re: [PATCH v2] vio: make remove callback return void

2021-02-25 Thread Michael Ellerman
Uwe Kleine-König writes: > The driver core ignores the return value of struct bus_type::remove() > because there is only little that can be done. To simplify the quest to > make this function return void, let struct vio_driver::remove() return > void, too. All users already unconditionally return

[PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread Michael Ellerman
/freescale/fs_enet/mii-bitbang.o Add the missing MODULE_LICENSEs to fix the build. Both files include a copyright header indicating they are GPL v2. Signed-off-by: Michael Ellerman --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + drivers/net/ethernet/freescale/fs_enet/mii-fec.c

Re: [PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread Michael Ellerman
Andrew Lunn writes: > On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: >> Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() >> into error") the ppc32_allmodconfig build fails with: >> >> ERROR: modpost: missing MODULE_

[PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-04 Thread Michael Ellerman
/freescale/fs_enet/mii-bitbang.o Add the missing MODULE_LICENSEs to fix the build. Both files include a copyright header indicating they are GPL v2. Signed-off-by: Michael Ellerman --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + drivers/net/ethernet/freescale/fs_enet/mii-fec.c

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-12-10 Thread Michael Ellerman
On Thu, 26 Nov 2020 17:59:49 +0100, Uwe Kleine-König wrote: > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. Applied t

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-12-02 Thread Michael Ellerman
Uwe Kleine-König writes: > Hello Michael, > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: >> On Thu, 26 Nov 2020 17:59:50 +0100, >> Uwe Kleine-König wrote: >> > >> > The driver core ignores the return value of struct device_driver::remove >> > because there is only little that c

Re: [PATCH net 1/2] ibmvnic: Ensure that SCRQ entry reads are correctly ordered

2020-11-26 Thread Michael Ellerman
Thomas Falcon writes: > On 11/24/20 11:43 PM, Michael Ellerman wrote: >> Thomas Falcon writes: >>> Ensure that received Subordinate Command-Response Queue (SCRQ) >>> entries are properly read in order by the driver. These queues >>> are used in the ibmvni

Re: [PATCH net 1/2] ibmvnic: Ensure that SCRQ entry reads are correctly ordered

2020-11-24 Thread Michael Ellerman
Thomas Falcon writes: > Ensure that received Subordinate Command-Response Queue (SCRQ) > entries are properly read in order by the driver. These queues > are used in the ibmvnic device to process RX buffer and TX completion > descriptors. dma_rmb barriers have been added after checking for a > pen

Re: tools/bpf: Compilation issue on powerpc: unknown type name '__vector128'

2020-10-25 Thread Michael Ellerman
Vitaly Chikunov writes: > Adding netdev and PowerPC maintainers JFYI. Thanks. > On Sat, Oct 24, 2020 at 11:23:19AM +0300, Dmitry V. Levin wrote: >> Hi, >> >> On Sat, Oct 24, 2020 at 02:06:41AM +0300, Vitaly Chikunov wrote: >> > Hi, >> > >> > Commit f143c11bb7b9 ("tools: bpf: Use local copy of

[PATCH] net: ucc_geth: Drop extraneous parentheses in comparison

2020-10-22 Thread Michael Ellerman
It seems clear the intent here is to do a comparison not an assignment, so drop the extra parentheses to avoid any confusion. Signed-off-by: Michael Ellerman --- drivers/net/ethernet/freescale/ucc_geth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freesc

Re: selftests/bpf/test_tag takes ~30 minutes?

2019-05-06 Thread Michael Ellerman
Daniel Borkmann writes: > On 04/30/2019 03:21 PM, Michael Ellerman wrote: >> Hi Daniel, >> >> I'm running selftests/bpf/test_tag and it's taking roughly half an hour >> to complete, is that expected? >> >> I don't really grok what the tes

selftests/bpf/test_tag takes ~30 minutes?

2019-04-30 Thread Michael Ellerman
Hi Daniel, I'm running selftests/bpf/test_tag and it's taking roughly half an hour to complete, is that expected? I don't really grok what the test is doing TBH, but it does appear to be doing it 5 times :) for (i = 0; i < 5; i++) { do_test(&tests, 2, -1, bpf_gen_imm_

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-02-25 Thread Michael Ellerman
Souptick Joarder writes: > Remove duplicate headers which are included twice. > > Signed-off-by: Sabyasachi Gupta > Signed-off-by: Souptick Joarder > --- ... > tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c | 1 - I took this hunk via the powerpc tree. > diff --git a/tools/testing

Re: [PATCH net-next v5 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW

2019-02-10 Thread Michael Ellerman
Deepa Dinamani writes: >> You touched powerpc in the previous patch but not this one. >> >> That's because we use the asm-generic version I assume. > > That is correct. > >> Would be good to mention in the change log though to avoid any confusion. > > I'm not sure how to do that now. It looks lik

Re: [PATCH net-next v5 11/12] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes

2019-02-06 Thread Michael Ellerman
r.kernel.org > Cc: sparcli...@vger.kernel.org > --- > arch/alpha/include/uapi/asm/socket.h | 7 +-- > arch/mips/include/uapi/asm/socket.h| 6 -- > arch/parisc/include/uapi/asm/socket.h | 6 -- > arch/powerpc/include/uapi/asm/socket.h | 4 ++-- The powerpc ch

Re: [PATCH net-next v5 12/12] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW

2019-02-06 Thread Michael Ellerman
Deepa Dinamani writes: > Add new socket timeout options that are y2038 safe. > > Signed-off-by: Deepa Dinamani > Acked-by: Willem de Bruijn > Cc: ccaul...@redhat.com > Cc: da...@davemloft.net > Cc: del...@gmx.de > Cc: pau...@samba.org > Cc: r...@linux-mips.org > Cc: r...@twiddle.net > Cc: clust

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-11 Thread Michael Ellerman
Daniel Borkmann writes: < snip > > > I would actually just like to get rid of the BPF_JIT_LIMIT_DEFAULT > define also given for 4.21 arm64 will have its own dedicated area for > JIT allocations where neither the above limit nor the MODULES_END/ > MODULES_VADDR one would fit and I don't want to mak

Re: [bpf] bpf: powerpc: fix broken uapi for BPF_PROG_TYPE_PERF_EVENT

2018-12-09 Thread Michael Ellerman
On Thu, 2018-12-06 at 09:27:01 UTC, Sandipan Das wrote: > Now that there are different variants of pt_regs for userspace and > kernel, the uapi for the BPF_PROG_TYPE_PERF_EVENT program type must > be changed by exporting the user_pt_regs structure instead of the > pt_regs structure that is in-kerne

Re: [PATCH bpf] bpf: powerpc: fix broken uapi for BPF_PROG_TYPE_PERF_EVENT

2018-12-09 Thread Michael Ellerman
Alexei Starovoitov writes: > On Thu, Dec 06, 2018 at 02:57:01PM +0530, Sandipan Das wrote: >> Now that there are different variants of pt_regs for userspace and >> kernel, the uapi for the BPF_PROG_TYPE_PERF_EVENT program type must >> be changed by exporting the user_pt_regs structure instead of

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-07 Thread Michael Ellerman
Michael Roth writes: > Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > JIT allocations. At compile time it defaults to PAGE_SIZE * 4, > and is adjusted again at init time if MODULES_VADDR is defined. > > For ppc64 kernels, MODULES_VADDR isn't defined, so we're stuck with

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-26 Thread Michael Ellerman
; arch/ia64/mm/discontig.c | 6 +++--- > arch/ia64/sn/kernel/io_common.c | 3 ++- > arch/powerpc/include/asm/pci-bridge.h | 3 ++- > arch/powerpc/kernel/paca.c| 3 ++- > arch/powerpc/kernel/pci-common.c | 3 ++

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-20 Thread Michael Ellerman
"Naveen N. Rao" writes: > Daniel Borkmann wrote: >> On 02/15/2018 05:25 PM, Daniel Borkmann wrote: >>> On 02/13/2018 05:05 AM, Sandipan Das wrote: The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Michael Ellerman
Randy Dunlap writes: > On 02/12/2018 04:28 AM, Michael Ellerman wrote: >> Randy Dunlap writes: >> >>> From: Randy Dunlap >>> >>> Currently #includes for no obvious >>> reason. It looks like it's only a convenience, so remove kmeml

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Michael Ellerman
Randy Dunlap writes: > From: Randy Dunlap > > Currently #includes for no obvious > reason. It looks like it's only a convenience, so remove kmemleak.h > from slab.h and add to any users of kmemleak_* > that don't already #include it. > Also remove from source files that do not use it. > > Th

Re: [v3, 3/6] dt: booting-without-of: DT fix s/#interrupt-cell/#interrupt-cells/

2018-01-21 Thread Michael Ellerman
On Fri, 2017-06-02 at 12:38:46 UTC, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/4be4119d1fbd93c44d5c639735c312 cheers

Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2018-01-07 Thread Michael Ellerman
David Miller writes: > From: Michael Ellerman > Date: Fri, 22 Dec 2017 15:22:22 +1100 > >>> On Tue, Dec 19 2017, Michael Ellerman >>> wrote: >>>> This revert seems to have broken networking on one of my powerpc >>>> machines, according to gi

Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2017-12-21 Thread Michael Ellerman
Rasmus Villemoes writes: > On Tue, Dec 19 2017, Michael Ellerman > wrote: >>> From: Johannes Berg >>> >>> This reverts commit d6f295e9def0; some userspace (in the case >> >> This revert seems to have broken networking on one of my powerpc &g

Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2017-12-19 Thread Michael Ellerman
Hi Johannes, > From: Johannes Berg > > This reverts commit d6f295e9def0; some userspace (in the case > we noticed it's wpa_supplicant), is relying on the current > error code to determine that a fixed name interface already > exists. > > Reported-by: Jouni Malinen > Signed-off-by: Johannes Ber

Re: [kernel-hardening] [PATCH 0/3] kallsyms: don't leak address

2017-12-17 Thread Michael Ellerman
"Tobin C. Harding" writes: > This set plugs a kernel address leak that occurs if kallsyms symbol > look up fails. This set was prompted by a leaking address found using > scripts/leaking_addresses.pl on a PowerPC machine in the wild. Any details on that? I haven't heard about it. cheers

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Michael Ellerman
Frank Rowand writes: > Hi Michael, > > On 11/12/17 03:49, Michael Ellerman wrote: ... >> >> On our bare metal machines the device tree comes from skiboot >> (firmware), with some of the content provided by hostboot (other >> firmware), both of which are open

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Michael Ellerman
Hi Frank, Frank Rowand writes: > Hi Michael, Tobin, > > On 11/08/17 04:10, Michael Ellerman wrote: >> "Tobin C. Harding" writes: >>> Currently we are leaking addresses from the kernel to user space. This >>> script is an attempt to find some of those

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-08 Thread Michael Ellerman
"Tobin C. Harding" writes: > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote: >> "Tobin C. Harding" writes: > [snip] > > Hi Michael, > > I'm working an adding support for ppc64 to leaking_addresses.pl, I've > added

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-08 Thread Michael Ellerman
"Tobin C. Harding" writes: > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel addresses. > > Only works for 64 bit kernels, t

Re: [1/1] bpf: take advantage of stack_depth tracking in powerpc JIT

2017-11-07 Thread Michael Ellerman
On Fri, 2017-09-01 at 18:53:01 UTC, Sandipan Das wrote: > Take advantage of stack_depth tracking, originally introduced for > x64, in powerpc JIT as well. Round up allocated stack by 16 bytes > to make sure it stays aligned for functions called from JITed bpf > program. > > Signed-off-by: Sandipan

Re: [v3, 4/6] powerpc: dts: acadia: DT fix s/#interrupts-parent/#interrupt-parent/

2017-10-24 Thread Michael Ellerman
On Fri, 2017-06-02 at 12:38:47 UTC, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3d2d4339cc326c427638daa67e264d cheers

Re: [PATCH 3/3][v2] selftests: silence test output by default

2017-10-15 Thread Michael Ellerman
Shuah Khan writes: > On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: >> From: Josef Bacik >> >> Some of the networking tests are very noisy and make it impossible to >> see if we actually passed the tests as they run. Default to suppressing >> the output from any tests run in order to make

Re: [PATCH v3 3/6] dt: booting-without-of: DT fix s/#interrupt-cell/#interrupt-cells/

2017-08-30 Thread Michael Ellerman
Geert Uytterhoeven writes: > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring > --- Rob this has your ack, but I'd expect it to go via your tree? Or should I grab it? cheers > diff --git a/Documentation/devicetree/booting-without-of.txt > b/Documentation/devicetree/booting-without-

Re: [PATCH] PCI: Allow PCI express root ports to find themselves

2017-08-17 Thread Michael Ellerman
Thierry Reding writes: > From: Thierry Reding > > If the pci_find_pcie_root_port() function is called on a root port > itself, return the root port rather than NULL. > > This effectively reverts commit 0e405232871d6 ("PCI: fix oops when > try to find Root Port for a PCI device") which added an e

Re: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

2017-08-17 Thread Michael Ellerman
Daniel Borkmann writes: > On 08/17/2017 12:30 PM, Michael Ellerman wrote: >> The sysctl documentation states that the JIT is only available on >> x86_64, which is no longer correct. >> >> Update the list, and break it out to indicate which architectures >> suppor

Re: [PATCH] bpf: Update sysctl documentation to list all supported architectures

2017-08-17 Thread Michael Ellerman
Daniel Borkmann writes: > On 08/16/2017 01:10 PM, Michael Ellerman wrote: >> Daniel Borkmann writes: >>> On 08/16/2017 07:15 AM, Michael Ellerman wrote: >>>> diff --git a/Documentation/sysctl/net.txt b/Documentation/sysctl/net.txt >>>> index 14

[PATCH v2] bpf: Update sysctl documentation to list all supported architectures

2017-08-17 Thread Michael Ellerman
The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list, and break it out to indicate which architectures support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT (HAVE_EBPF_JIT). Signed-off-by: Michael Ellerman --- Documentation

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-16 Thread Michael Ellerman
Thierry Reding writes: ... > > In case of Tegra, dev actually points to the root port. Now if I read > the above code correctly, highest_pcie_bridge will still be NULL in that > case, which in turn will return NULL from pci_find_pcie_root_port(). But > shouldn't it really return dev? > > The patch

Re: [PATCH] bpf: Update sysctl documentation to list all supported architectures

2017-08-16 Thread Michael Ellerman
Daniel Borkmann writes: > Hi Michael, > > On 08/16/2017 07:15 AM, Michael Ellerman wrote: >> The sysctl documentation states that the JIT is only available on >> x86_64, which is no longer correct. >> >> Update the list to include all architectures that enable

[PATCH] bpf: Update sysctl documentation to list all supported architectures

2017-08-15 Thread Michael Ellerman
The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list to include all architectures that enable HAVE_CBPF_JIT or HAVE_EBPF_JIT under some configuration. Signed-off-by: Michael Ellerman --- Documentation/sysctl/net.txt | 5 +++-- 1

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-25 Thread Michael Ellerman
Paolo Abeni writes: > Thank you! > > I'll submit formally the patch after some more testing. Thanks. > I noticed this version has entered the ppc patchwork, but I think that > the formal submission should go towards the net-next tree. Yeah it picks up all patches sent to the list. That's fine I

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

2017-06-22 Thread Michael Ellerman
Hannes Frederic Sowa writes: > On Thu, Jun 22, 2017, at 22:57, Paolo Abeni wrote: >> >> Can you please check if the following patch fixes the issue? Only >> compiled tested here. >> >> Thanks!!! >> --- >> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c >> index 067a607..80d89fe 100644 >> --- a/net

Re: [PATCH 21/44] powerpc: implement ->mapping_error

2017-06-14 Thread Michael Ellerman
arch/powerpc/platforms/ps3/system-bus.c:static const struct dma_map_ops ps3_ioc0_dma_ops = { All of which look like they definitely can fail, but return 0 on error and don't implement ->mapping_error. So I guess I'm acking this and adding a TODO to fix up the NPU code at least, the ps3 code is probably better left alone these days. Acked-by: Michael Ellerman cheers

Re: [PATCH net-next] net: phy: use of_mdio_parse_addr

2017-06-09 Thread Michael Ellerman
Liviu Dudau writes: > On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote: >> From: Jon Mason >> Date: Wed, 31 May 2017 15:43:30 -0400 >> >> > use of_mdio_parse_addr() in place of an OF read of reg and a bounds >> > check (which is litterally the exact same thing that >> > of_mdio_pars

Re: [PATCH net-next] powerpc: use asm-generic/socket.h as much as possible

2017-05-31 Thread Michael Ellerman
Stephen Rothwell writes: > asm-generic/socket.h already has an exception for the differences that > powerpc needs, so just include it after defining the differences. > > Signed-off-by: Stephen Rothwell > --- > arch/powerpc/include/uapi/asm/socket.h | 92 > +- >

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-14 Thread Michael Ellerman
Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed-off-by: Elena Reshetova > Sig

Re: [1/3] powerpc: bpf: remove redundant check for non-null image

2017-01-26 Thread Michael Ellerman
On Fri, 2017-01-13 at 17:10:00 UTC, "Naveen N. Rao" wrote: > From: Daniel Borkmann > > We have a check earlier to ensure we don't proceed if image is NULL. As > such, the redundant check can be removed. > > Signed-off-by: Daniel Borkmann > [Added similar changes for classic BPF JIT] > Signed-of

Re: [2/3] powerpc: bpf: flush the entire JIT buffer

2017-01-26 Thread Michael Ellerman
On Fri, 2017-01-13 at 17:10:01 UTC, "Naveen N. Rao" wrote: > With bpf_jit_binary_alloc(), we allocate at a page granularity and fill > the rest of the space with illegal instructions to mitigate BPF spraying > attacks, while having the actual JIT'ed BPF program at a random location > within the all

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-07 Thread Michael Ellerman
Joe Perches writes: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >> > This introduces the Freescale Data Path Acceleration Architecture >> > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) >> > +{ >> > + 

Re: [mm PATCH v2 18/26] arch/powerpc: Add option to skip DMA sync as a part of mapping

2016-11-03 Thread Michael Ellerman
Alexander Duyck writes: > This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to > avoid invoking cache line invalidation if the driver will just handle it > via a sync_for_cpu or sync_for_device call. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras >

Re: [1/3] bpf powerpc: introduce accessors for using the tmp local stack space

2016-10-04 Thread Michael Ellerman
On Fri, 2016-23-09 at 20:35:00 UTC, "Naveen N. Rao" wrote: > While at it, ensure that the location of the local save area is > consistent whether or not we setup our own stackframe. This property is > utilised in the next patch that adds support for tail calls. > > Signed-off-by: Naveen N. Rao S

Re: [PATCH] MAINTAINERS: Remove myself from PA Semi entries

2016-09-14 Thread Michael Ellerman
Olof Johansson writes: > The platform is old, very few users and I lack bandwidth to keep after > it these days. > > Mark the base platform as well as the drivers as orphans, patches have > been flowing through the fallback maintainers for a while already. Sorry to see you go, but thanks for kee

Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests

2016-09-13 Thread Michael Ellerman
Shuah Khan writes: > Update to work under selftests. dnotify_test will not be run as part of > selftests suite and will not included in install targets. It can be built > separately for now. > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/filesystems/Makefile | 10 ++ > 1

[PATCH] net: Remove NO_IRQ from powerpc-only network drivers

2016-09-10 Thread Michael Ellerman
We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it from powerpc-only drivers. Signed-off-by: Michael Ellerman --- drivers/net/ethernet/freescale/fman/fman_mac.h | 2 +- drivers/net/ethernet/freescale/fs_enet/mac-fcc.c | 2 +- drivers/net/ethernet/freescale/fs_ene

Re: [PATCHv2, 2/7] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation

2016-06-28 Thread Michael Ellerman
On Wed, 2016-22-06 at 16:25:02 UTC, "Naveen N. Rao" wrote: > The existing LI32() macro can sometimes result in a sign-extended 32-bit > load that does not clear the top 32-bits properly. As an example, > loading 0x7fff results in the register containing > 0x7fff. While this does not

Re: [PATCHv2,1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le

2016-06-23 Thread Michael Ellerman
On Wed, 2016-22-06 at 16:25:01 UTC, "Naveen N. Rao" wrote: > Classic BPF JIT was never ported completely to work on little endian > powerpc. However, it can be enabled and will crash the system when used. > As such, disable use of BPF JIT on ppc64le. > > Reported-by: Thadeu Lima de Souza Cascardo

Re: [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-22 Thread Michael Ellerman
On Tue, 2016-06-07 at 19:02 +0530, Naveen N. Rao wrote: > PPC64 eBPF JIT compiler. > > Enable with: > echo 1 > /proc/sys/net/core/bpf_jit_enable > or > echo 2 > /proc/sys/net/core/bpf_jit_enable > > ... to see the generated JIT code. This can further be processed with > tools/net/bpf_jit_disasm.

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-21 Thread Michael Ellerman
On Tue, 2016-06-21 at 14:28 +0530, Naveen N. Rao wrote: > On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote: > > On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > > > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > > > Hi, Michael and Naveen. > > > >

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-21 Thread Michael Ellerman
On Fri, 2016-06-17 at 10:00 -0300, Thadeu Lima de Souza Cascardo wrote: > From a984dc02b6317a1d3a3c2302385adba5227be5bd Mon Sep 17 00:00:00 2001 > From: Thadeu Lima de Souza Cascardo > Date: Wed, 15 Jun 2016 13:22:12 -0300 > Subject: [PATCH] ppc: Fix BPF JIT for ABIv2 > > ABIv2 used for ppc64le d

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-21 Thread Michael Ellerman
On Tue, 2016-06-21 at 08:45 -0700, Alexei Starovoitov wrote: > On 6/21/16 7:47 AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > > > The calling convention is different with ABIv2 and so we'll need changes > > > > in bpf_slow_path_common() and sk_negative_common(). > > > > > > How big would th

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-21 Thread Michael Ellerman
On Tue, 2016-06-21 at 14:28 +0530, Naveen N. Rao wrote: > On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote: > > On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > > > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > > > Hi, Michael and Naveen. > > > >

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-21 Thread Michael Ellerman
On Tue, 2016-06-21 at 12:28 +0530, Naveen N. Rao wrote: > On 2016/06/21 09:38AM, Michael Ellerman wrote: > > On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > > > > > > #include > > > > > > in bpf_jit_comp64.c > > > >

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-20 Thread Michael Ellerman
On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > On 2016/06/17 10:53PM, Michael Ellerman wrote: > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > > > b/arch/powerpc/net/bpf_ji

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-17 Thread Michael Ellerman
On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > b/arch/powerpc/net/bpf_jit_comp64.c > new file mode 100644 > index 000..954ff53 > --- /dev/null > +++ b/arch/powerpc/net/bpf_jit_comp64.c > @@ -0,0 +1,956 @@ ... > + > +static void bpf

Re: [PATCH 3/3] param: convert some "on"/"off" users to strtobool

2016-01-28 Thread Michael Ellerman
| 10 +++--- > arch/powerpc/platforms/pseries/hotplug-cpu.c | 11 +++ Acked-by: Michael Ellerman (powerpc) cheers

Re: sbc8641: drop bogus PHY IRQ entries from DTS file

2015-12-14 Thread Michael Ellerman
On Tue, 2015-08-12 at 22:44:02 UTC, Paul Gortmaker wrote: > This file was originally cloned off of the MPC8641D-HPCN reference > platform, which actually had a PHY IRQ line connected. However > this board does not. The bogus entry was largely inert and went > undetected until commit 321beec5047af

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

2015-12-08 Thread Michael Ellerman
On Tue, 2015-12-08 at 21:04 -0500, Paul Gortmaker wrote: > [Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015 > (Wed 12:10) Michael Ellerman wrote: > > On Tue, 2015-12-08 at 17:44 -0500, Paul Gortmaker wrote: > > > This file was originally clone

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

2015-12-08 Thread Michael Ellerman
On Tue, 2015-12-08 at 21:40 -0500, David Miller wrote: > From: Paul Gortmaker > Date: Tue, 8 Dec 2015 17:44:02 -0500 > > This file was originally cloned off of the MPC8641D-HPCN reference > > platform, which actually had a PHY IRQ line connected. However > > this board does not. The bogus entry

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

2015-12-08 Thread Michael Ellerman
On Tue, 2015-12-08 at 17:44 -0500, Paul Gortmaker wrote: > This file was originally cloned off of the MPC8641D-HPCN reference > platform, which actually had a PHY IRQ line connected. However > this board does not. The bogus entry was largely inert and went > undetected until commit 321beec5047af

Re: [P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

2015-12-02 Thread Michael Ellerman
On Wed, 2015-12-02 at 05:59 +0100, Christian Zigotzky wrote: > Hi all, > > We tested some 4.3 kernels on a P.A. Semi reference board. Ultimately, > ethernet does not work, though on the reference board, the interface is > detected, gets link, but will not pass any packets/traffic. > > Somewhere

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-25 Thread Michael Ellerman
On Thu, 2015-07-23 at 07:07 -0700, Jeff Kirsher wrote: > On Wed, 2015-07-22 at 11:41 +1000, Michael Ellerman wrote: > > On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: > > > On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > > > > e1000e_disable

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-21 Thread Michael Ellerman
On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: > On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is > > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not u

[PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-13 Thread Michael Ellerman
e1000e_disable_aspm_locked() is only used in __e1000_resume() which is inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used" warning for e1000e_disable_aspm_locked(). Move it inside the existing CONFIG_PM block to avoid the warning. Signed-off-by: Michael Ellerman --

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-28 Thread Michael Ellerman
On Thu, 2015-06-25 at 21:25 -0500, Scott Wood wrote: > On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: > > On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: > > > On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > > > > (Evolution 3.16 is basica

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Michael Ellerman
On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: > On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > > (Evolution 3.16 is basically unbearable for replying to patches. > > Anyone > > else running into this?) > > If you mean the crazy lag when selecting moderate-to-large amounts of > te

Re: [PATCH] ehea: Fix memory hook reference counting crashes

2015-04-26 Thread Michael Ellerman
On Sat, 2015-04-25 at 14:43 -0400, David Miller wrote: > From: Michael Ellerman > Date: Fri, 24 Apr 2015 15:52:32 +1000 > > > The recent commit to only register the EHEA memory hotplug hooks on > > adapter probe has a few problems. > > > > Firstly the referen

[PATCH] ehea: Fix memory hook reference counting crashes

2015-04-23 Thread Michael Ellerman
ehea: registering mr failed ehea: register MR failed - driver inoperable! ehea: memory is going offline Fixes: aa183323312d ("ehea: Register memory hotplug, reboot and crash hooks on adapter probe") Signed-off-by: Michael Ellerman --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 6

Re: [patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

2008-02-26 Thread Michael Ellerman
(i < 0) > + printk(KERN_INFO "Warning: Could not disable RX section\n"); > + > + i = 1000; > + pasemi_write_dma_reg(PAS_DMA_COM_TXCMD, 0); > + while ((i > 0) && (pasemi_read_dma_reg(PAS_DMA_COM_TXSTA) & 1)) > + i--; This

Re: [PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Michael Ellerman
On Mon, 2008-02-04 at 16:24 +0100, Jan-Bernd Themann wrote: > On Monday 04 February 2008 15:46, Michael Ellerman wrote: > > On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: > > > Add memory remove hotplug support > > > > @@ -3559,6 +3578,10 @@ in

Re: [PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Michael Ellerman
stering crash handler"); You don't do anything except print a message if the registration fails. What happens when someone tries to remove memory but the memory notifier wasn't registered properly? Bang? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http:

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Michael Ellerman
t perhaps ehea_crash_shutdown() would be clearer. > @@ -3396,10 +3496,15 @@ out: > > static void __exit ehea_module_exit(void) > { > + int ret; > + > flush_scheduled_work(); > driver_remove_file(&ehea_driver.driver, &driver_attr_capabilities); >

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Michael Ellerman
gt; + memset(adapter->res_handles, sizeof(adapter->res_handles), 0); > > arguments wrong way around. Remind me why bzero is deprecated again? :) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 2118

Re: [PATCH] ehea: Add kdump support

2007-11-26 Thread Michael Ellerman
ete them before the driver loads. c) if neither of those work, provide a minimal routine that _only_ deletes the handles in the crashed kernel. d) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 7

Re: [PATCH] ehea: add kexec support

2007-11-01 Thread Michael Ellerman
On Wed, 2007-10-31 at 20:48 +0100, Christoph Raisch wrote: > Michael Ellerman <[EMAIL PROTECTED]> wrote on 30.10.2007 23:50:36: > > > > On Tue, 2007-10-30 at 09:39 +0100, Christoph Raisch wrote: > > > > > > Michael Ellerman <[EMAIL PROTECTED]> wrote on

Re: [PATCH] ehea: add kexec support

2007-10-30 Thread Michael Ellerman
On Tue, 2007-10-30 at 09:39 +0100, Christoph Raisch wrote: > > Michael Ellerman <[EMAIL PROTECTED]> wrote on 28.10.2007 23:32:17: > > > > > > How do you plan to support kdump? > > > > When kexec is fully supported kdump should work out of the box >

Re: [PATCH] ehea: add kexec support

2007-10-28 Thread Michael Ellerman
> before kexec starts a new kernel. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > How do you plan to support kdump? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Michael Ellerman
On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: > On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > > > On pseries there's a chance it will work for PCI error recovery, but if > > so it's just lucky that firmware has left everyth

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-21 Thread Michael Ellerman
able() in the error detection and recovery sequence. Yes I think so. That way we can properly reconfigure via the firmware interface. The other option would be to design some new arch hook to do resume, but just doing a disable/enable seems simpler to me. cheers -- Michael Ellerman OzLabs, IBM

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Michael Ellerman
will be bogus. That's a pity, but AFAIK it shouldn't be a problem because we don't enable CONFIG_PM on those machines anyway. If we ever want to we'll need to sort out with firmware how that will work WRT restoring MSI state. cheers -- Michael Ellerman OzLabs, IBM Australia

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-14 Thread Michael Ellerman
tching branches and back again is less so. ccache! cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person s

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Michael Ellerman
On Wed, 2007-06-13 at 21:01 +0200, Segher Boessenkool wrote: > > I wish there was a git option to "just make my shit look like the > > remote, dammit!" The above is the "easiest" way I know how to do that. > > git-fetch -f remote:local ? There's alwa

Re: [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Michael Ellerman
On Tue, 2007-06-12 at 21:54 -0400, Jeff Garzik wrote: > Michael Ellerman wrote: > > Linas posted the patches, I responded querying whether the bug fixes > > should go into 2.6.22, and then you told him "you need to order your bug > > fixes first in the queue". Which

Re: [PATCH 0/15] spidernet driver bug fixes

2007-06-12 Thread Michael Ellerman
On Tue, 2007-06-12 at 19:00 -0400, Jeff Garzik wrote: > Linas Vepstas wrote: > > On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote: > >> On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote: > >>> On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael

  1   2   >