On 5/30/2018 10:20 AM, Tariq Toukan wrote:
On 28/05/2018 7:09 PM, Eric Dumazet wrote:
On 05/28/2018 07:52 AM, Alexander Aring wrote:
as somebody who had similar issues with this patch series I can tell you
about what happened for the 6LoWPAN fragmentation.
The issue sounds similar, but
On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote:
> On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander Duyck wrote:
> > On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pirko wrote:
> > > Thu, Jul 26, 2018 at 02:43:59AM CEST, jakub.kicin...@netronome.com
> wrote:
> > >>On Wed, 25 Jul 2018 08:23:26 -0
; On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas
> wrote:
> > >> > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote:
> > >> >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh <
> moshes20...@gmail.com> wrote:
> > >> >> > On
>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote:
>> From: Moshe Shemesh
>>
>> Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags.
>> Remove QUERY_FUNC_CAP port_flags field which was not in use.
>
>The patch title says "Fix ..." but the chan
>On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote:
>> From: Moshe Shemesh
>>
>> Expose mlx4_config_svlan_tpid, that checks for feature support in
>> device capabilities and sets the Service Tag TPID accordingly.
>
>I Googled for service tag TPID and I un
Ethtool supports module EEPROM dumps via the `ethtool -m ` command.
But in current state its functionality is limited - offset and length
parameters, which are used to specify a linear desired region of EEPROM
data to dump, is not enough, considering emergence of complex module
EEPROM layouts such
From: Vladyslav Tarasiuk
Implement ethtool_ops::get_module_eeprom_data_by_page() to enable
support of new SFP standards.
Signed-off-by: Vladyslav Tarasiuk
---
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 42 +++
.../net/ethernet/mellanox/mlx5/core/port.c| 33
From: Vladyslav Tarasiuk
Prepare for ethtool_ops::get_module_eeprom_data() implementation by
extracting common part of mlx5_query_module_eeprom() into a separate
function.
Signed-off-by: Vladyslav Tarasiuk
---
.../net/ethernet/mellanox/mlx5/core/port.c| 79 +++
include/linu
From: Vladyslav Tarasiuk
Define get_module_eeprom_data_by_page() ethtool callback and implement
netlink infrastructure.
get_module_eeprom_data_by_page() allows network drivers to dump a part
of module's EEPROM specified by page and bank numbers along with offset
and length. It is effectively a n
From: Vladyslav Tarasiuk
Allow the driver to recognise DSFP transceiver module ID and therefore
allow its EEPROM dumps using ethtool.
Signed-off-by: Vladyslav Tarasiuk
---
drivers/net/ethernet/mellanox/mlx5/core/port.c | 3 ++-
include/linux/mlx5/port.h | 1 +
2 files chan
From: Vladyslav Tarasiuk
In case netlink get_module_eeprom_data_by_page() callback is not
implemented by the driver, try to call old get_module_info() and
get_module_eeprom() pair. Recalculate parameters to get_module_eeprom()
offset and len using page number and their sizes. Return error if
this
On 3/5/2021 2:50 AM, Don Bollinger wrote:
On Thu, Mar 04, 2021 at 10:57AM-0800, Moshe Shemesh wrote:
From: Vladyslav Tarasiuk
Define get_module_eeprom_data_by_page() ethtool callback and
implement netlink infrastructure.
get_module_eeprom_data_by_page() allows network drivers to dump a
On 3/5/2021 3:58 AM, Andrew Lunn wrote:
+/* MODULE EEPROM DATA */
+
+enum {
+ ETHTOOL_A_EEPROM_DATA_UNSPEC,
+ ETHTOOL_A_EEPROM_DATA_HEADER,
+
+ ETHTOOL_A_EEPROM_DATA_OFFSET,
+ ETHTOOL_A_EEPROM_DATA_LENGTH,
+ ETHTOOL_A_EEPROM_DATA_PAGE,
+ ETHTOOL_A_EEPROM_DATA_BANK,
+
On 3/5/2021 2:50 AM, Don Bollinger wrote:
On Thu, Mar 04, 2021 at 10:57AM-0800, Moshe Shemesh wrote:
From: Vladyslav Tarasiuk
In case netlink get_module_eeprom_data_by_page() callback is not
implemented by the driver, try to call old get_module_info() and
get_module_eeprom() pair
On 12/9/2020 4:46 AM, David Ahern wrote:
On 12/6/20 10:35 PM, Moshe Shemesh wrote:
+ print_string(PRINT_ANY, NULL, "%s",
reload_action_name(action));
That line should be:
print_string(PRINT_ANY,
On 11/24/2020 11:16 PM, Jakub Kicinski wrote:
On Tue, 24 Nov 2020 02:14:59 +0100 Andrew Lunn wrote:
On Mon, Nov 23, 2020 at 11:19:56AM +0200, Moshe Shemesh wrote:
Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable
transceiver). DSFP EEPROM memory layout is
On 11/24/2020 12:40 AM, Jesse Brandeburg wrote:
External email: Use caution opening links or attachments
Moshe Shemesh wrote:
From: Vladyslav Tarasiuk
CMIS 4.0 document describes a universal EEPROM memory layout, which is
used for some modules such as DSFP, OSFP and QSFP-DD modules. In
to
devlink reload command.
Patch 2 adds pr_out_dev() helper function and modify monitor function to
use it.
Patch 3 adds reload stats and remote reload stats to devlink dev show.
Moshe Shemesh (3):
devlink: Add devlink reload action and limit options
devlink: Add pr_out_dev
eload": {
"reload_actions_performed": [ "driver_reinit" ]
}
}
devlink dev reload pci/:82:00.0 action fw_activate -jp
{
"reload": {
"reload_actions_performed": [ "driver_reinit","fw_activate" ]
}
}
Signed-off-by
Add pr_out_dev() helper function and use it both by cmd_dev_show_cb()
and by cmd_mon_show_cb().
Dev stats will be added on the next patch to dev context, so
cmd_mon_show_cb() should print the whole dev context and not just dev
handle.
Signed-off-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
;no_reset": 0
}
},
"remote_reload": {
"driver_reinit": {
"unspecified": 1
},
"fw_activate": {
&qu
On 11/25/2020 4:18 PM, Andrew Lunn wrote:
External email: Use caution opening links or attachments
OK, we will add API options to select bank and page to read any specific
page the user selects. So advanced user will use it get the optional pages
he needs, but what about non advanced user wh
On 11/26/2020 5:21 PM, Andrew Lunn wrote:
If i was implementing the ethtool side of it, i would probably do some
sort of caching system. We know page 0 should always exist, so
pre-load that into the cache. Try the netlink API first. If that
fails, use the ioctl interface. If the ioctl is used,
On 11/29/2020 11:12 PM, David Ahern wrote:
On 11/26/20 4:14 AM, Moshe Shemesh wrote:
@@ -1997,7 +2066,7 @@ static void cmd_dev_help(void)
pr_err(" devlink dev eswitch show DEV\n");
pr_err(" devlink dev param set DEV name PARAMETER value VALUE cmo
On 11/29/2020 11:22 PM, David Ahern wrote:
On 11/26/20 4:14 AM, Moshe Shemesh wrote:
@@ -2975,17 +2996,93 @@ static int cmd_dev_param(struct dl *dl)
return -ENOENT;
}
-static void pr_out_dev(struct dl *dl, struct nlattr **tb)
+static void pr_out_action_stats(struct dl *dl
On 11/29/2020 11:15 PM, David Ahern wrote:
On 11/26/20 4:14 AM, Moshe Shemesh wrote:
diff --git a/devlink/devlink.c b/devlink/devlink.c
index a9ba0072..bd588869 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -2974,17 +2974,11 @@ static int cmd_dev_param(struct dl *dl
On 12/1/2020 1:25 PM, Vasundhara Volam wrote:
On Thu, Nov 26, 2020 at 4:46 PM Moshe Shemesh wrote:
Introduce new options on devlink reload API to enable the user to select
the reload action required and constrains limits on these actions that he
may want to ensure.
Add reload stats to show
to
devlink reload command.
Patch 2 adds pr_out_dev() helper function and modify monitor function to
use it.
Patch 3 adds reload stats and remote reload stats to devlink dev show.
Moshe Shemesh (3):
devlink: Add devlink reload action and limit options
devlink: Add pr_out_dev
;no_reset": 0
}
},
"remote_reload": {
"driver_reinit": {
"unspecified": 1
},
"fw_activate": {
Add pr_out_dev() helper function and use it both by cmd_dev_show_cb()
and by cmd_mon_show_cb().
Dev stats will be added on the next patch to dev context, so
cmd_mon_show_cb() should print the whole dev context and not just dev
handle.
Signed-off-by: Moshe Shemesh
Reviewed-by: Jiri Pirko
eload": {
"reload_actions_performed": [ "driver_reinit" ]
}
}
devlink dev reload pci/:82:00.0 action fw_activate -jp
{
"reload": {
"reload_actions_performed": [ "driver_reinit","fw_activate" ]
}
}
Signed-off-
On 9/4/2020 10:56 PM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Fri, 4 Sep 2020 11:04:50 +0200 Jiri Pirko wrote:
Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote:
On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote:
Wed, Sep 02, 2020 at 05:
On 9/7/2020 8:58 PM, Jakub Kicinski wrote:
On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote:
In that sense I don't like --live because it doesn't really say much.
AFAIU it means 1) no link flap; 2) < 2 sec datapath downtime; 3) no
configuration is lost in kernel or devi
bridge by checking that all the PF functions under the same PCI
bridge have same device ID. If no other device it uses PCI bridge link
control to turn link down and up.
Signed-off-by: Moshe Shemesh
---
.../ethernet/mellanox/mlx5/core/fw_reset.c| 121 ++
1 file changed, 121
update.
The function devlink_reload_actions_implicit_actions_performed() is
exported to enable also drivers update on reload actions performed,
for example in case firmware activation with reset finished
successfully but was initiated by remote host.
Signed-off-by: Moshe Shemesh
---
v3 ->
time allowed, no link flap and no
configuration is lost.
The no_reset limit level will have usecase in this patchset to
implement restricted fw_activate on mlx5.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- New patch
---
drivers/net/ethernet/mellanox/mlx4/main.c | 3 ++
.../
{
"reload_action_stats": [ {
"driver_reinit": 1
},{
"fw_activate": 1
},{
"driver_reinit_no_reset": 0
},{
"fw_activate_no_reset"
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Remove reload action fw_activate_no_reset
- Add reload actions limit levels and document the no_reset limit level
constrains
v2 -> v3:
- Devlink reload returns the a
firmware update reset is enabled.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Have MLX5_FW_RESET_FLAGS_NACK_RESET_REQUEST instead of
MLX5_HEALTH_RESET_FLAGS_NACK_RESET_REQUEST
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 21 +
.../ethernet/mellanox/mlx5/core/fw_rese
fw_activate reload action.
Patch 14 adds documentation file devlink-reload.rst
Moshe Shemesh (15):
devlink: Add reload action option to devlink reload command
devlink: Add reload action limit level
devlink: Add reload action stats
devlink: Add reload actions stats to dev get
net/mlx5
it is then it triggers firmware live patching flow.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Have action fw_activate with limit level no_reset instead of action
fw_activate_no_reset
v2 -> v3:
- Replace fw_live_patch action by fw_activate_no_reset
v1 -> v2:
- Have fw_live_pat
NACK any attempt to reset the device while the
driver is loaded.
Signed-off-by: Moshe Shemesh
---
Documentation/networking/devlink/devlink-params.rst | 6 ++
include/net/devlink.h | 4
net/core/devlink.c | 5 +
3 files
synchronizes all PFs on coming reset and driver reload.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Renamed actions_done to actions_performed
v2 -> v3:
- Return the reload actions done
- Update reload action counters if reset initiated by remote host
v1 -> v2:
- Have fw_activate action i
If firmware sends sync_reset_abort to driver the driver should clear the
reset requested mode as reset is not expected any more.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/net
it moves to reset
requested mode and if it gets PCI reset triggered by the other PF it
detect the reset and reloads.
Signed-off-by: Moshe Shemesh
---
v1 -> v2:
- Moved handling of sync reset recovery from health to fw_reset
---
.../ethernet/mellanox/mlx5/core/fw_reset.c|
-off-by: Moshe Shemesh
---
v3 -> v4:
- Removed fw_activate_no_reset as an action (next patch adds limit
levels instead).
- Renamed actions_done to actions_performed
v2 -> v3:
- Replace fw_live_patch action by fw_activate_no_reset
- Devlink reload returns the actions done over netlink reply
v1
Add functions to query and set the MFRL reset options supported by
firmware.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../ethernet/mellanox/mlx5/core/fw_reset.c| 46 +++
.../ethernet/mellanox/mlx5/core/fw_reset.h| 13
database to help debugging an issue.
Signed-off-by: Moshe Shemesh
---
.../mellanox/mlx5/core/diag/fw_tracer.c | 31 +++
.../mellanox/mlx5/core/diag/fw_tracer.h | 1 +
.../ethernet/mellanox/mlx5/core/fw_reset.c| 27
include/linux/mlx5/device.h
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core
On 9/14/2020 4:10 PM, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:07:49AM CEST, mo...@mellanox.com wrote:
[..]
diff --git a/include/net/devlink.h b/include/net/devlink.h
index b09db891db04..9ee5b8a9 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@
dev reload pci/:82:00.0 action fw_activate
reload_actions_performed:
driver_reinit fw_activate
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Removed fw_activate_no_reset as an action (next patch adds limit
levels instead).
- Renamed actions_done to actions_performed
v2 -> v3:
- R
case firmware activation with reset finished
successfully but was initiated by remote host.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Renamed reload_actions_cnts to reload_action_stats
- Add devlink notifications on stats update
- Renamed devlink_reload_actions_implicit_actions_performed()
On 9/15/2020 10:44 AM, Jiri Pirko wrote:
Tue, Sep 15, 2020 at 08:45:19AM CEST, ido...@idosch.org wrote:
On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:07:51AM CEST, mo...@mellanox.com wrote:
Expose devlink reload actions stats to the user through devlink
loaded. Once this reload
command is executed the driver initiates fw sync reset flow, where the
firmware synchronizes all PFs on coming reset and driver reload.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Renamed actions_done to actions_performed
v2 -> v3:
- Return the reload actions done
-
On 9/15/2020 12:33 AM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Mon, 14 Sep 2020 09:07:48 +0300 Moshe Shemesh wrote:
@@ -3011,12 +3060,41 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb,
struct genl_info *info)
return
On 9/15/2020 7:04 PM, Jakub Kicinski wrote:
External email: Use caution opening links or attachments
On Mon, 14 Sep 2020 09:08:02 +0300 Moshe Shemesh wrote:
+ * - ``no_reset``
+ - No reset allowed, no down time allowed, no link flap and no
+ configuration is lost.
It still
On 9/15/2020 4:26 PM, Jiri Pirko wrote:
Tue, Sep 15, 2020 at 02:12:25PM CEST, mo...@nvidia.com wrote:
On 9/14/2020 3:27 PM, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:07:48AM CEST, mo...@mellanox.com wrote:
[..]
@@ -7392,6 +7485,11 @@ struct devlink *devlink_alloc(const struct d
On 9/15/2020 4:37 PM, Jiri Pirko wrote:
Tue, Sep 15, 2020 at 02:44:02PM CEST, mo...@nvidia.com wrote:
On 9/14/2020 4:54 PM, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:07:57AM CEST, mo...@mellanox.com wrote:
[..]
+static void mlx5_fw_reset_complete_reload(struct mlx5_core_dev *dev)
+{
+
On 9/15/2020 4:34 PM, Jiri Pirko wrote:
Tue, Sep 15, 2020 at 02:31:38PM CEST, mo...@nvidia.com wrote:
On 9/15/2020 10:44 AM, Jiri Pirko wrote:
Tue, Sep 15, 2020 at 08:45:19AM CEST, ido...@idosch.org wrote:
On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:0
On 9/15/2020 4:33 PM, Jiri Pirko wrote:
Tue, Sep 15, 2020 at 02:30:19PM CEST, mo...@nvidia.com wrote:
On 9/14/2020 4:39 PM, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:07:50AM CEST, mo...@mellanox.com wrote:
[..]
+/**
+ * devlink_reload_implicit_actions_performed - Update devlink on rel
On 9/14/2020 4:54 PM, Jiri Pirko wrote:
Mon, Sep 14, 2020 at 08:07:57AM CEST, mo...@mellanox.com wrote:
[..]
+static void mlx5_fw_reset_complete_reload(struct mlx5_core_dev *dev)
+{
+ struct mlx5_fw_reset *fw_reset = dev->priv.fw_reset;
+
+ /* if this is the driver that initiated
. If it is a negative value then the dump returned an
error so we should set errno accordingly and check for ext_ack in case
it was set.
Fixes: 049c58539f5d ("devlink: mnlg: Add support for extended ack")
Signed-off-by: Moshe Shemesh
Acked-by: Jiri Pirko
---
devlink/mnlg.c
On 2/21/2019 7:54 PM, Stephen Hemminger wrote:
> The netlink API for IFLA_VF_VLAN_LIST allows multiple VLAN tags to
> be passed (and the message was validated) but only the first VLAN
> tag was being passed to the device. Change to iterate over each tag received.
>
> Fixes: 79aab093a0b5 ("net: U
On 3/21/2019 1:54 AM, Jakub Kicinski wrote:
> On Wed, 20 Mar 2019 16:39:53 -0700, Saeed Mahameed wrote:
>> From: Moshe Shemesh
>>
>> Move the definition of the default Geneve udp port from the geneve
>> source to the header file, so we can re-use it from drivers.
&g
On 3/21/2019 1:55 AM, Jakub Kicinski wrote:
> On Wed, 20 Mar 2019 16:39:56 -0700, Saeed Mahameed wrote:
>> diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.h
>> b/drivers/net/ethernet/netronome/nfp/flower/main.h
>> index 7afe66eff684..f214759d485b 100644
>> --- a/drivers/net/ethernet/
recovery
>> flow. Only one PF needs to issue the reset, so an attempt is made to
>> prevent the 2nd function from also issuing the reset.
>> It's not an error if that happens, it just slows recovery.
>>
>> Signed-off-by: Feras Daoud
>> Signed-off-by: Al
On 5/5/2019 6:49 PM, Jiri Pirko wrote:
> Sun, May 05, 2019 at 02:33:27AM CEST, sae...@mellanox.com wrote:
>> From: Moshe Shemesh
>>
>> Add support of dump callback for mlx5 FW reporter.
>> Once we trigger FW dump, the FW will write the core dump to its raw data
>&
On 5/5/2019 6:42 PM, Jiri Pirko wrote:
> Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellanox.com wrote:
>> From: Moshe Shemesh
>>
>> Create mlx5_devlink_health_reporter for FW reporter. The FW reporter
>> implements devlink_health_reporter diagnose callback.
>
On 5/5/2019 6:52 PM, Jiri Pirko wrote:
> Sun, May 05, 2019 at 02:33:33AM CEST, sae...@mellanox.com wrote:
>> From: Moshe Shemesh
>>
>> Add support of dump callback for mlx5 FW fatal reporter.
>> The FW fatal dump use cr-dump functionality to gather cr-space data for
Ethtool supports module EEPROM dumps via the `ethtool -m ` command.
But in current state its functionality is limited - offset and length
parameters, which are used to specify a linear desired region of EEPROM
data to dump, is not enough, considering emergence of complex module
EEPROM layouts such
From: Vladyslav Tarasiuk
Define get_module_eeprom_by_page() ethtool callback and implement
netlink infrastructure.
get_module_eeprom_by_page() allows network drivers to dump a part of
module's EEPROM specified by page and bank numbers along with offset and
length. It is effectively a netlink rep
From: Vladyslav Tarasiuk
Prepare for ethtool_ops::get_module_eeprom_data() implementation by
extracting common part of mlx5_query_module_eeprom() into a separate
function.
Signed-off-by: Vladyslav Tarasiuk
---
.../net/ethernet/mellanox/mlx5/core/port.c| 79 +++
include/linu
From: Vladyslav Tarasiuk
Allow the driver to recognise DSFP transceiver module ID and therefore
allow its EEPROM dumps using ethtool.
Signed-off-by: Vladyslav Tarasiuk
---
drivers/net/ethernet/mellanox/mlx5/core/port.c | 2 ++
include/linux/mlx5/port.h | 1 +
2 files chang
From: Vladyslav Tarasiuk
Implement ethtool_ops::get_module_eeprom_by_page() to enable
support of new SFP standards.
Signed-off-by: Vladyslav Tarasiuk
---
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 44 +++
.../net/ethernet/mellanox/mlx5/core/port.c| 41 +
From: Andrew Lunn
There are two ways to retrieve information from SFP EEPROMs. Many
devices make use of the common code, and assign the sfp_bus pointer in
the netdev to point to the bus holding the SFP device. Some MAC
drivers directly implement ops in there ethool structure.
Export within net/
From: Vladyslav Tarasiuk
In case netlink get_module_eeprom_by_page() callback is not implemented
by the driver, try to call old get_module_info() and get_module_eeprom()
pair. Recalculate parameters to get_module_eeprom() offset and len using
page number and their sizes. Return error if this can'
From: Andrew Lunn
The new netlink API for reading SFP data requires a new op to be
implemented. The idea of the new netlink SFP code is that userspace is
responsible to parsing the EEPROM data and requesting pages, rather
than have the kernel decide what pages are interesting and returning
them.
From: Andrew Lunn
If the device has a sfp bus attached, call its
sfp_get_module_eeprom_by_page() function, otherwise use the ethtool op
for the device. This follows how the IOCTL works.
Signed-off-by: Andrew Lunn
---
net/ethtool/eeprom.c | 25 -
1 file changed, 20 inser
evlink dev reload pci/:82:00.0 level fw-reset
# Run reload command with driver reload level:
$ devlink dev reload pci/:82:00.0 level driver
# Run reload command with driver's default level (backward compatible):
$ devlink dev reload pci/:82:00.0
Moshe Shemesh (13):
devlink: Add relo
bridge by checking that all the PF functions under the same PCI
bridge have same device ID. If no other device it uses PCI bridge link
control to turn link down and up.
Signed-off-by: Moshe Shemesh
---
.../ethernet/mellanox/mlx5/core/fw_reset.c| 126 ++
1 file changed, 126
reset and driver entities re-instantiation.
fw_live_patch: firmware live patching only.
Signed-off-by: Moshe Shemesh
---
drivers/net/ethernet/mellanox/mlx4/main.c | 6 ++-
.../net/ethernet/mellanox/mlx5/core/devlink.c | 6 ++-
drivers/net/ethernet/mellanox/mlxsw/core.c| 6 ++-
driver
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core
firmware update reset is enabled.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 29 +++
.../ethernet/mellanox/mlx5/core/fw_reset.c| 12
include/linux/mlx5/driver.h | 1 +
3 files changed, 42 insertions(+)
diff
it moves to reset
requested mode and if it gets PCI reset triggered by the other PF it
does silent recovery without reporting it as an error.
Signed-off-by: Moshe Shemesh
---
.../ethernet/mellanox/mlx5/core/fw_reset.c| 88 +++
.../ethernet/mellanox/mlx5/core/fw_reset.h| 3
database to help debugging an issue.
Signed-off-by: Moshe Shemesh
---
.../mellanox/mlx5/core/diag/fw_tracer.c | 31 +++
.../mellanox/mlx5/core/diag/fw_tracer.h | 1 +
.../ethernet/mellanox/mlx5/core/fw_reset.c| 27
include/linux/mlx5/device.h
"supported_levels": [ "driver","fw_reset","fw_live_patch" ]
}
},
"pci/:82:00.1": {
"reload_levels_info": {
"default_level": "driver",
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
.../networking/devlink/devlink-reload.rst | 56 +++
Documentation/networking/devlink/index.rst| 1 +
2 files changed, 57 insertions(+)
create mode 100644
If firmware sends sync_reset_abort to driver the driver should clear the
reset requested mode as reset is not expected any more.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/net
Add support for devlink reload level fw_live_patch which does live
patching to firmware.
The driver checks if the firmware is capable of handling the pending
firmware changes as a live patch. If it is then it triggers
fw_live_patch flow.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet
ff-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/devlink.c | 53 +--
.../ethernet/mellanox/mlx5/core/fw_reset.c| 14 +
.../ethernet/mellanox/mlx5/core/fw_reset.h| 1 +
3 files changed, 64 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mel
NACK any attempt to reset the device while the
driver is loaded.
Signed-off-by: Moshe Shemesh
---
Documentation/networking/devlink/devlink-params.rst | 6 ++
include/net/devlink.h | 4
net/core/devlink.c | 5 +
3 files
Add functions to query and set the MFRL reset options supported by
firmware.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../ethernet/mellanox/mlx5/core/fw_reset.c| 46 +++
.../ethernet/mellanox/mlx5/core/fw_reset.h| 13
On 7/28/2020 3:58 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:22 +0300 Moshe Shemesh wrote:
Expose devlink reload supported levels and driver's default level to the
user through devlink dev get command.
Examples:
$ devlink dev show
pci/:82:00.0:
reload_levels
On 7/28/2020 3:59 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote:
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets that can be initiated by other hosts. This
parameter is useful for setups where a device is shared by
On 7/28/2020 11:06 PM, Jakub Kicinski wrote:
On Tue, 28 Jul 2020 12:18:30 -0700 Jacob Keller wrote:
On 7/28/2020 11:44 AM, Jakub Kicinski wrote:
From user perspective what's important is what the reset achieves (and
perhaps how destructive it is). We can define the reset levels as:
$ devlin
On 7/30/2020 12:11 AM, Jakub Kicinski wrote:
On Wed, 29 Jul 2020 17:37:41 +0300 Moshe Shemesh wrote:
The fact that the driver supports fw_live_patch, does not necessarily
mean that the currently running FW can be live upgraded to the
currently flashed one, right?
That's correct, thoug
On 7/29/2020 11:57 PM, Jakub Kicinski wrote:
On Wed, 29 Jul 2020 17:42:12 +0300 Moshe Shemesh wrote:
On 7/28/2020 3:59 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote:
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets
On 7/30/2020 12:07 AM, Jakub Kicinski wrote:
On Wed, 29 Jul 2020 17:54:08 +0300 Moshe Shemesh wrote:
On 7/28/2020 11:06 PM, Jakub Kicinski wrote:
On Tue, 28 Jul 2020 12:18:30 -0700 Jacob Keller wrote:
On 7/28/2020 11:44 AM, Jakub Kicinski wrote:
From user perspective what's importa
On 7/31/2020 2:11 AM, Jakub Kicinski wrote:
On Thu, 30 Jul 2020 15:30:45 +0300 Moshe Shemesh wrote:
My expectations would be that the driver must perform the lowest
reset level possible that satisfies the requested functional change.
IOW driver may do more, in fact it should be acceptable for
On 8/3/2020 1:24 PM, Vasundhara Volam wrote:
On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote:
On 7/27/2020 10:25 PM, Vasundhara Volam wrote:
On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote:
Introduce new option on devlink reload API to enable the user to select the
reload level
1 - 100 of 281 matches
Mail list logo
