On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
> It may need hold Global Config Lock a longer time when download DDP
> package file, extend the timeout value to 5000ms to ensure that
> download can be finished before other AQ command got time to run,
> this will fix the issue below when probe
On Mon, 2021-04-19 at 09:23 +0200, Kurt Kanzenbach wrote:
> When using native XDP with the igb driver, the XDP frame data doesn't
> point to
> the beginning of the packet. It's off by 16 bytes. Everything works
> as expected
> with XDP skb mode.
>
> Actually these 16 bytes are used to store the pa
On Fri, 2021-04-16 at 14:12 -0700, Jakub Kicinski wrote:
> On Fri, 16 Apr 2021 13:44:56 -0700 Tony Nguyen wrote:
> > + bool is_failed;
> > + int i;
> > +
> > + do {
> > + is_failed = false;
> > + for (i = hw->mac.mta_reg_count - 1; i >= 0; i--) {
> > + if
On Fri, 2021-04-09 at 18:00 -0700, Jakub Kicinski wrote:
> On Fri, 9 Apr 2021 12:03:12 -0700 Tony Nguyen wrote:
> > From: Radoslaw Tyl
> >
> > The global rx error does not take into account all the error
> > counters
> > that are counted by device.
> >
> > Extend rx error with the following cou
On Sun, 2021-04-11 at 02:45 +0100, Salil Mehta wrote:
> If user has explicitly requested the number of {R,T}XQs, then it is
> unnecessary
> to get the count of already available {R,T}XQs from the PF
> avail_{r,t}xqs
> bitmap. This value will get overriden by user specified value in any
s/override
On Wed, 2021-03-31 at 02:28 +, Liu, Yongxin wrote:
> Hello Brett,
>
> Could you please help to review this V2?
>
Hi Yongxin,
I have this applied to the Intel-wired-lan tree to go through some
testing. Also, adding the Intel-wired-lan list for reviews.
Thanks,
Tony
> Thanks,
> Yongxin
>
>
On Thu, 2021-03-04 at 10:50 -0800, Jakub Kicinski wrote:
> On Wed, 3 Mar 2021 17:06:47 -0800 Tony Nguyen wrote:
> > From: Bartosz Golaszewski
> >
> > It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV -
> > we
> > still want to finalize the registration of the ixgbe device. Check
>
On Sat, 2021-02-27 at 10:58 +0100, Greg Kroah-Hartman wrote:
> The include guard for the e1000e and e1000 hw.h files are the same,
> so
> add the proper "E" term to the hw.h file for the e1000e driver.
There's a patch in process that addresses this issue [1].
> This resolves some static analyzer
On Fri, 2021-02-19 at 09:31 -0800, Jakub Kicinski wrote:
> On Thu, 18 Feb 2021 15:25:03 -0800 Tony Nguyen wrote:
> > From: Mateusz Palczewski
> >
> > Fix insufficient distinction between IPv4 and IPv6 addresses
> > when creating a filter.
> > IPv4 and IPv6 are kept in the same memory area. If IPv
On Tue, 2021-02-02 at 08:30 -0800, Jakub Kicinski wrote:
> On Tue, 2 Feb 2021 09:59:56 + Pierre Cheynier wrote:
> > On Sat, 30 Jan 2021 04:27:00 +0100 Jakub Kicinski wrote:
> >
> > > I must have missed that i40e_setup_pf_switch() is called from the
> > > probe
> > > path.
> >
> > Do you wan
On Mon, 2021-02-01 at 08:47 -0800, Jakub Kicinski wrote:
> On Sun, 31 Jan 2021 18:17:11 -0500 Matt Corallo wrote:
> > Given this fixes a major (albeit ancient) performance regression,
> > is
> > it not a candidate for backport? It landed on Tony's dev-queue
> > branch
> > with a Fixes tag but no st
On Thu, 2021-01-28 at 22:07 +0100, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has
> been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> Whe
On Wed, 2021-01-27 at 19:50 +0800, wangyunjian wrote:
> From: Yunjian Wang
>
> Before calling ice_set_dflt_mib(), the 'pf' has been dereferenced.
> So the additional check is unnecessary, just remove it.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: 7d9c9b791f9e ("ice: Imple
On Wed, 2021-01-27 at 08:04 +0100, Heiner Kallweit wrote:
> On 26.01.2021 23:10, Tony Nguyen wrote:
> > From: Corinna Vinschen
> >
> > Link speed advertising in igc has two problems:
> >
> > - When setting the advertisement via ethtool, the link speed is
> > converted
> > to the legacy 32 bit
On Tue, 2021-01-26 at 12:00 -0800, Jakub Kicinski wrote:
> On Tue, 26 Jan 2021 11:30:37 +0100 Corinna Vinschen wrote:
> > Ping?
> >
> > It looks like this patch got lost somehow. Without this patch,
> > setting link speed advertising is broken.
>
> Adding Intel maintainers.
I talked to the team
On Sat, 2021-01-23 at 19:52 -0800, Jakub Kicinski wrote:
> On Fri, 22 Jan 2021 15:57:31 -0800 Tony Nguyen wrote:
> > From: Piotr Raczynski
> >
> > XDP queue number for XDP_TX action is used inconsistently
> > and may result with no packets transmitted. Fix queue number
> > used by the driver when
On Fri, 2021-01-22 at 09:54 -0800, Alexander Duyck wrote:
> On Fri, Jan 22, 2021 at 5:29 AM wangyunjian
> wrote:
> >
> > From: Yunjian Wang
> >
> > The rx_ring->q_vector could be NULL, so it needs to be checked
> > before
> > calling xdp_rxq_info_reg.
> >
> > Fixes: b02e5a0ebb172 ("xsk: Propag
On Tue, 2020-12-08 at 14:22 -0800, Alexander Duyck wrote:
> On Tue, Dec 8, 2020 at 2:01 PM Nguyen, Anthony L
> wrote:
> >
> > On Tue, 2020-12-08 at 11:00 -0800, Alexander Duyck wrote:
> > > On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L
> > > wrote:
>
On Tue, 2020-12-08 at 11:00 -0800, Alexander Duyck wrote:
> On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L
> wrote:
> >
> > On Mon, 2020-11-23 at 17:11 -0800, Alexander Duyck wrote:
> > > On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg
> > > wrote:
&g
On Mon, 2020-11-23 at 17:11 -0800, Alexander Duyck wrote:
> On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg
> wrote:
> >
> > Alexander Duyck wrote:
> >
> > > > > I'm not sure this logic is correct. Can the flow director
> > > > > rules
> > > > > handle
> > > > > a field that is removed? Last I
On Thu, 2020-12-03 at 07:58 +0100, Magnus Karlsson wrote:
> On Wed, Dec 2, 2020 at 9:49 PM Maciej Fijalkowski
> wrote:
> >
> > On Wed, Dec 02, 2020 at 04:07:21PM +0100, Magnus Karlsson wrote:
> > > Optimize run_xdp_zc() for the XDP program verdict being
> > > XDP_REDIRECT
> > > in the zsk zero-co
On Wed, 2020-12-02 at 18:18 -0800, Jakub Kicinski wrote:
> This code does not jump to exit on an error in iavf_lan_add_device(),
> so the rtnl_unlock() from the normal path will follow.
>
> Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine")
> Signed-off-by: Jakub Kicinski
> ---
> drivers/
On Fri, 2020-11-13 at 17:25 -0800, Alexander Duyck wrote:
> On Fri, Nov 13, 2020 at 1:49 PM Tony Nguyen <
> anthony.l.ngu...@intel.com> wrote:
> >
> > From: Paul M Stillwell Jr
> >
> > There are times when the driver shouldn't return an error when the
> > Get
> > PHY abilities AQ command (0x0600
On Fri, 2020-11-13 at 15:56 -0800, Alexander Duyck wrote:
> On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen <
> anthony.l.ngu...@intel.com> wrote:
> >
> > From: Real Valiquette
> >
> > Implement the initial steps for creating an ACL filter to support
> > ntuple
> > masks. Create a flow profile based
On Fri, 2020-11-13 at 14:59 -0800, Alexander Duyck wrote:
> On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen <
> anthony.l.ngu...@intel.com> wrote:
> >
> > From: Real Valiquette
> >
> > ACL filtering can be utilized to expand support of ntuple rules by
> > allowing
> > mask values to be specified for
On Fri, 2020-11-13 at 14:59 -0800, Alexander Duyck wrote:
> On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen <
> anthony.l.ngu...@intel.com> wrote:
> >
> > From: Real Valiquette
> >
> > ACL filtering can be utilized to expand support of ntuple rules by
> > allowing
> > mask values to be specified for
On Thu, 2020-11-12 at 08:55 -0800, Jakub Kicinski wrote:
> On Tue, 10 Nov 2020 16:19:51 -0800 Tony Nguyen wrote:
> > This series contains updates to i40e and igc drivers and the
> > MAINTAINERS
> > file.
> >
> > Slawomir fixes updating VF MAC addresses to fix various issues
> > related
> > to repo
On Fri, 2020-10-09 at 16:36 -0700, Jakub Kicinski wrote:
> On Wed, 7 Oct 2020 16:10:48 -0700 Tony Nguyen wrote:
> > + if (hw->mac.type == I40E_MAC_X722 &&
> > + !(hw->flags & I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE)) {
> > + netdev_err(netdev, "Setting FEC encoding not supported
>
On Fri, 2020-10-09 at 13:46 -0400, Willem de Bruijn wrote:
> On Wed, Oct 7, 2020 at 7:11 PM Tony Nguyen <
> anthony.l.ngu...@intel.com> wrote:
> >
> > From: Aleksandr Loktionov
> >
> > Fix MAC setting flow for the PF driver.
> >
> > Without this change the MAC address setting was interpreted
>
On Mon, 2020-10-12 at 08:16 -0700, Jakub Kicinski wrote:
> On Mon, 12 Oct 2020 14:20:16 +0200 Bartosz Golaszewski wrote:
> > On Mon, Sep 28, 2020 at 9:17 AM Bartosz Golaszewski
> > wrote:
> > >
> > > From: Bartosz Golaszewski
> > >
> > > It's a valid use-case for ixgbe_mii_bus_init() to return
On Fri, 2020-10-09 at 14:18 +0800, Pujin Shi wrote:
> Fix up a compiler error on 64bit architectures where pointers.
>
> In file included from
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c:6:0:
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c: In function
> 'ice_free_flow_profs':
> drivers/net/
On Fri, 2020-09-25 at 17:56 -0700, Jakub Kicinski wrote:
> This set converts Intel drivers which have the ability to spawn
> multiple netdevs, but have only one UDP tunnel port table.
>
> Appropriate support is added to the core infra in patch 1,
> followed by netdevsim support and a selftest.
>
On Mon, 2020-09-21 at 14:44 -0700, Jakub Kicinski wrote:
> On Sat, 19 Sep 2020 07:23:58 + Brown, Aaron F wrote:
> > > From: Intel-wired-lan On
> > > Behalf Of Jakub
> > > Kicinski
> > > Sent: Tuesday, July 21, 2020 6:27 PM
> > > To: da...@davemloft.net
> > > Cc: netdev@vger.kernel.org; intel-w
On Tue, 2020-09-15 at 09:22 -0400, Jamal Hadi Salim wrote:
> Ethtool reporting zero. ip -s reporting non-zero.
> Which is right? See attached for more details.
>
I've asked the team responsible for the driver to look into this issue.
I will let you know what I hear back.
Thanks,
Tony
On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote:
> In i40e_clean_rx_irq_zc(), the variable failure is only set when a
> condition is met, but then its value is used unconditionally. Fix
> this.
>
> Addresses-Coverity: 1496986 ("Uninitialized value")
> Fixes: 8cbf74149903 ("i40e, xsk: move buff
On Thu, 2020-09-10 at 07:48 -0700, Jakub Kicinski wrote:
> On Wed, 9 Sep 2020 17:04:07 -0700 Tony Nguyen wrote:
> > This series contains updates to i40e and igc drivers.
> >
> > Stefan Assmann changes num_vlans to u16 to fix may be used
> > uninitialized
> > error and propagates error in i40_set_
On Thu, 2020-09-03 at 16:22 -0700, Jakub Kicinski wrote:
> On Thu, 23 Jul 2020 20:06:15 +0000 Nguyen, Anthony L wrote:
> > On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote:
> > > On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:
> > > > This set convert
On Fri, 2020-08-14 at 14:19 -0700, Jakub Kicinski wrote:
> On Fri, 14 Aug 2020 13:36:42 -0700 Tony Nguyen wrote:
> > + * @hw: pointer to the hw struct
> > + * @maj: api major value
> > + * @min: api minor value
> > +static bool i40e_is_aq_api_ver_ge(struct i40e_adminq_info *aq, u16
> > maj,
> > +
On Fri, 2020-07-31 at 16:49 -0700, David Miller wrote:
> From: Andy Shevchenko
> Date: Thu, 30 Jul 2020 19:04:51 +0300
>
> > Use %*phD format to print small buffer as hex string.
> >
> > Signed-off-by: Andy Shevchenko
>
> I am assuming the Intel folks will integrate this into their tree.
Yes,
On Thu, 2020-07-30 at 16:27 -0700, Jakub Kicinski wrote:
> On Thu, 30 Jul 2020 10:09:36 -0700 Tony Nguyen wrote:
> > This series contains updates to the e1000e and igb drivers.
> >
> > Aaron Ma allows PHY initialization to continue if ULP disable
> > failed for
> > e1000e.
> >
> > Francesco Rugge
On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote:
> On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:
> > This set converts Intel drivers which have the ability to spawn
> > multiple netdevs, but have only one UDP tunnel port table.
> >
> > Appropriate support is added to the core infra
On Wed, 2020-07-22 at 15:48 -0700, Jakub Kicinski wrote:
> On Wed, 22 Jul 2020 14:31:43 -0700 Tony Nguyen wrote:
> > Accordance to the i225 specification address 0x4118 used for
> > Host Good Packet Transmitted Count and defined as read on clear.
> > IGC_ICTXQEC not in use and could be removed.
>
On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:
> This set converts Intel drivers which have the ability to spawn
> multiple netdevs, but have only one UDP tunnel port table.
>
> Appropriate support is added to the core infra in patch 1,
> followed by netdevsim support and a selftest.
>
On Wed, 2020-07-01 at 09:25 +0800, Haiyue Wang wrote:
> The PF shall track all the outstanding switch filters (filter IDs to
> be
> precise) added by the DCF.
>
> Upon a VF reset event, the PF shall clear all outstanding switch
> filters
> for the given VF. Upon completion of either VF or PF reset
On Thu, 2019-09-26 at 20:05 +0200, Greg KH wrote:
> On Thu, Sep 26, 2019 at 09:45:00AM -0700, Jeff Kirsher wrote:
> > From: Tony Nguyen
> >
> > The RDMA block does not advertise on the PCI bus or any other bus.
>
> Huh? How do you "know" where it is then? Isn't is usually assigned
> to
> a PCI
On Mon, 2019-08-12 at 15:24 -0700, Jakub Kicinski wrote:
> On Mon, 12 Aug 2019 15:07:09 +0000, Nguyen, Anthony L wrote:
> > On Fri, 2019-08-09 at 14:15 -0700, Jakub Kicinski wrote:
> > > On Fri, 9 Aug 2019 11:31:25 -0700, Jeff Kirsher wrote:
> > > > From: Henry Tie
On Fri, 2019-08-09 at 14:15 -0700, Jakub Kicinski wrote:
> On Fri, 9 Aug 2019 11:31:25 -0700, Jeff Kirsher wrote:
> > From: Henry Tieman
> >
> > Add code to query and set the number of queues on the primary
> > VSI for a PF. This is accessed from the 'ethtool -l' and 'ethtool
> > -L'
> > command
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
> Sent: Thursday, July 26, 2018 2:47 PM
> On Thu, 26 Jul 2018 14:21:08 -0700, Jakub Kicinski wrote:
> > On Thu, 26 Jul 2018 10:40:45 -0700, Jeff Kirsher wrote:
> > > From: Tony Nguyen
> > >
> > > XDP does not support jumbo frames or LRO.
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Wednesday, July 19, 2017 3:55 AM
> Subject: Re: [net-next v3 1/5] ixgbe: Ensure MAC filter was added before
> setting
> MACVLAN
>
> On Tue, 2017-07-18 at 18:23 -0700, Jeff Kirsher wrote:
> > This patch adds a che
49 matches
Mail list logo
