Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

Hey Florian & Co, On Fri, 2018-01-19 at 18:26 +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > > > diff --git a/drivers/target/iscsi/iscsi_target_nego.c > > > b/drivers/target/iscsi/iscsi_target_nego.c

Re: iscsi target regression due to "tcp: remove prequeue support" patch

On Mon, 2018-01-15 at 14:33 -0600, Mike Christie wrote: > On 01/15/2018 12:41 AM, Nicholas A. Bellinger wrote: > > Hey MNC & Co, > > > > Ping on the earlier iscsi-target authentication login failures atop > > 4.14 + commit e7942d063 removing tcp prequeue suppor

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Hi Florian, (Adding netdev + DaveM CC') Thanks for the response. Comments below. On Mon, 2018-01-15 at 11:41 +0100, Florian Westphal wrote: > Mike Christie wrote: > > > Dec 13 17:55:01 rhel73n1 kernel: Got Login Command, Flags 0x81, ITT: > > 0x, CmdSN:

Re: iscsi target regression due to "tcp: remove prequeue support" patch

8-01-08 at 22:32 -0800, Nicholas A. Bellinger wrote: > Hi MNC & Florian, > > (Adding net-dev + DaveM CC') > > Catching up on pre-holiday threads, thanks for the heads up. > > Comments below. > > On Wed, 2017-12-13 at 23:56 -0600, Mike Christie wrote: > >

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Hi MNC & Florian, (Adding net-dev + DaveM CC') Catching up on pre-holiday threads, thanks for the heads up. Comments below. On Wed, 2017-12-13 at 23:56 -0600, Mike Christie wrote: > Hey Nick and Florian, > > Starting in 4.14 iscsi logins will fail around 50% of the time. > > I git bisected

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

ers/target/target_core_iblock.c | 12 ++-- > drivers/target/target_core_iblock.h | 3 ++- > 2 files changed, 8 insertions(+), 7 deletions(-) For the target_core_iblock part: Acked-by: Nicholas Bellinger <n...@linux-iscsi.org>

Re: [PATCH rfc 4/4] iscsi-target: use generic inet_pton_with_scope

gt; - return ERR_PTR(ret); > - } > - sock_in = (struct sockaddr_in *) > - sock_in->sin_family = AF_INET; > - sock_in->sin_port = htons((unsigned short)port); > - sock_in->sin_addr.s_addr = in_aton(ip_str); > + ret = inet_pton_with_scope(_net, AF_UNSPEC, ip_str, > + port_str, ); > + if (ret) { > + pr_err("malformed ip/port passed: %s\n", name); > + return ERR_PTR(ret); > } > + > tpg = container_of(se_tpg, struct iscsi_portal_group, tpg_se_tpg); > ret = iscsit_get_tpg(tpg); > if (ret < 0) A nice cleanup. Acked-by: Nicholas Bellinger <n...@linux-iscsi.org>

Re: [PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

on] > > Add linux/module.h to iscsi_target_login.c. > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> > Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> > --- Acked-by: Nicholas Bellinger <n...@linux-iscsi.org>

Re: [net-next v2 0/6] common library for Chelsio drivers

Hi Varun & Co, On Sat, 2016-07-16 at 22:49 +0530, Varun Prakash wrote: > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier this

[GIT PULL] target for-next-merge updates for v4.6-rc1

Hello Linus, Here are the target-pending for-next-merge updates for v4.6-rc1. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next-merge You'll hit one minor merge conflict in t4fw_api.h with net-next as reported by SFR:

Re: [target-pending 00/12] cxgb4 patch series for cxgbit.ko

On Tue, 2016-03-15 at 12:34 +0530, Hariprasad Shenai wrote: > On Mon, Mar 14, 2016 at 22:29:11 -0700, Nicholas A. Bellinger wrote: > > Hi Varun & Co, > > > > On Sun, 2016-03-13 at 19:49 +0530, Varun Prakash wrote: > > > Hi Nicholas, > > >

Re: [target-pending 00/12] cxgb4 patch series for cxgbit.ko

Hi Varun & Co, On Sun, 2016-03-13 at 19:49 +0530, Varun Prakash wrote: > Hi Nicholas, > >I am posting cxgb4 patch series as >suggested by you in following email thread > >http://www.spinics.net/lists/target-devel/msg12437.html > >This series consists of patches from >

Re: linux-next: manual merge of the target-merge tree with the net-next tree

On Mon, 2016-02-29 at 17:39 +1100, Stephen Rothwell wrote: > Hi Nicholas, > > Today's linux-next merge of the target-merge tree got a conflict in: > > drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h > > between commit: > > ba9cee6aa67d ("cxgb4/iw_cxgb4: TOS support") > > from the net-next

Re: simplify configfs attributes V2

Hi Christoph & Co, On Sat, 2015-10-03 at 15:32 +0200, Christoph Hellwig wrote: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This

Re: [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute

ly and write-only attributes with a single line of code. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- > fs/configfs/file.c | 17 - > include/linux/configfs.h | 27 +++ > 2 files changed, 39 insertions(+), 5 deletions(-)

Re: [PATCH 19/23] target: use per-attribute show and store methods

) > delete mode 100644 include/target/configfs_macros.h > delete mode 100644 include/target/target_core_fabric_configfs.h > I'm totally crazy for this patch. Very nice work to drop this much boilerplate macro-fu in target-core + fabric driver code. Reviewed-by: Nicholas Bellinger <n...@linux-iscsi.

Re: simplify configfs attributes

On Fri, 2015-09-25 at 06:49 -0700, Christoph Hellwig wrote: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and