Re: when having to acquire an SA, ipsec drops the packet

2007-02-02 Thread Paul Moore
that this procedure would need to be done for each SPD rule. I haven't thought about this too much yet, but I suspect proactively creating SAs is not going to be a practical solution. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-10 Thread Paul Moore
On Wednesday 10 January 2007 5:01 am, Jarek Poplawski wrote: On Tue, Jan 09, 2007 at 09:26:46AM -0500, Paul Moore wrote: On Tuesday 09 January 2007 3:43 am, Jarek Poplawski wrote: ... But if you consider this code will probably become classical and will be read, quoted and teached next

Re: [IPSEC] flow: Cache negative results

2007-01-10 Thread Paul Moore
); } } local_bh_enable(); - if (err) - obj = ERR_PTR(err); return obj; } } -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-09 Thread Paul Moore
me, I'll send out a patch to the patch later today. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread Paul Moore
A quick patch to change the inet_sock-is_icsk assignment to better fit with existing kernel coding style. Signed-off-by: Paul Moore [EMAIL PROTECTED] Cc: Jarek Poplawski [EMAIL PROTECTED] Cc: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/af_inet.c |2 +- net/ipv6/af_inet6.c |2

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-08 Thread Paul Moore
On Monday, January 8 2007 8:25 am, Jarek Poplawski wrote: On 04-01-2007 21:04, Paul Moore wrote: +++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c @@ -305,7 +305,7 @@ lookup_protocol: sk-sk_reuse = 1; inet = inet_sk(sk); - inet-is_icsk = INET_PROTOSW_ICSK answer_flags

[PATCH 0/2] Two pretty trivial NetLabel bugfixes

2007-01-05 Thread Paul Moore
of these patches with what I believe to be pretty much all of the kernel debug options enabled and I have not encountered any problems. Please consider these for the 2.6.20 release. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body

[PATCH 1/2] NetLabel: correct locking in selinux_netlbl_socket_setsid()

2007-01-05 Thread Paul Moore
The spinlock protecting the update of the sksec-nlbl_state variable is not currently softirq safe which can lead to problems. This patch fixes this by changing the spin_{un}lock() functions into spin_{un}lock_bh() functions. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux/ss

[PATCH 2/2] NetLabel: correct CIPSO tag handling when adding new DOI definitions

2007-01-05 Thread Paul Moore
sporadic failures. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- net/netlabel/netlabel_cipso_v4.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: net-2.6.20_bugfix_3/net/netlabel/netlabel_cipso_v4.c === --- net

Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]

2007-01-03 Thread Paul Moore
On Tuesday, January 2 2007 6:37 pm, David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Tue, 2 Jan 2007 16:25:24 -0500 I'm sorry I just saw this mail (mail not sent directly to me get shuffled off to a folder). I agree with your patch, I think dropping and then re-taking the RCU

Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]

2007-01-02 Thread Paul Moore
and send it out. Once again, sorry for the regression. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]

2007-01-02 Thread Paul Moore
example you could send? -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]

2006-12-25 Thread Paul Moore
promise to do so as soon as I am able. . paul moore . linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] A bugfix patchset for NetLabel

2006-12-18 Thread Paul Moore
if you think that has merit for the stable tree and I'll send the patch to the stable mailing list. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 2/2] NetLabel: correctly fill in unused CIPSOv4 level and category mappings

2006-12-15 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Back when the original NetLabel patches were being changed to use Netlink attributes correctly some code was accidentially dropped which set all of the undefined CIPSOv4 level and category mappings to a sentinel value. The result is the mappings data

[PATCH 0/2] A bugfix patchset for NetLabel

2006-12-15 Thread paul . moore
as well; is there anything special I need to do for that? -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] NetLabel: perform input validation earlier on CIPSOv4 DOI add ops

2006-12-15 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] There are a couple of cases where the user input for a CIPSOv4 DOI add operation was not being done soon enough; the result was unexpected behavior which was resulting in oops/panics/lockups on some platforms. This patch moves the existing input validation code

[PATCH] Netlink: add a pointer to the Generic Netlink wiki page

2006-12-05 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Add a pointer to the OSDL wiki page on Generic Netlink. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- Documentation/networking/00-INDEX|2 ++ Documentation/networking/generic_netlink.txt |3 +++ 2 files changed, 5 insertions(+) Index

Generic Netlink doc now wiki-ized

2006-12-04 Thread Paul Moore
. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread paul . moore
with this patchset; please consider this for net-2.6.20. Thanks. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] NetLabel: add the enumerated tag to the CIPSOv4 protocol

2006-11-29 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Add support for the enumerated tag (tag type #2) to the CIPSOv4 protocol. The enumerated tag allows for 15 categories to be specified in a CIPSO option, where each category is an unsigned 16 bit field with a maximum value of 65534. See Documentation/netlabel

[PATCH 3/3] NetLabel: add the ranged tag to the CIPSOv4 protocol

2006-11-29 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Add support for the ranged tag (tag type #5) to the CIPSOv4 protocol. The ranged tag allows for seven, or eight if zero is the lowest category, category ranges to be specified in a CIPSO option. Each range is specified by two unsigned 16 bit fields, each

Re: [PATCH 0/3] NetLabel: add the remaining CIPSO tag types from the IETF draft

2006-11-29 Thread Paul Moore
James Morris wrote: All applied to: git://git.infradead.org/~jmorris/selinux-net-2.6.20 Thanks. Did you mean your kernel.org git tree? -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 00/13] NetLabel cleanups for 2.6.20 [GIT]

2006-11-18 Thread Paul Moore
the fix. /scratching head -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c

2006-11-17 Thread Paul Moore
-2.6.20]$ Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Acked-by: Paul Moore [EMAIL PROTECTED] Looks fine to me. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 08/13] NetLabel: return the correct error for translated CIPSOv4 tags

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The CIPSOv4 translated tag #1 mapping does not always return the correct error code if the desired mapping does not exist; instead of returning -EPERM it returns -ENOSPC indicating that the buffer is not large enough to hold the translated value

[PATCH 11/13] NetLabel: SELinux cleanups

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] This patch does a lot of cleanup in the SELinux NetLabel support code. A summary of the changes include: * Use RCU locking for the NetLabel state variable in the skk_security_struct instead of using the inode_security_struct mutex. * Remove unnecessary

[PATCH 00/13] NetLabel cleanups for 2.6.20

2006-11-17 Thread paul . moore
make sense to go into too much details here, please see each patch for an explanation of what it does. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 02/13] NetLabel: convert the unlabeled accept flag to use RCU

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Currently the NetLabel unlabeled packet accept flag is an atomic type and it is checked for every non-NetLabel packet which comes into the system but rarely ever changed. This patch changes this flag to a normal integer and protects it with RCU locking. Signed

[PATCH 09/13] NetLabel: use the correct CIPSOv4 MLS label limits

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The CIPSOv4 engine currently has MLS label limits which are slightly larger than what the draft allows. This is not a major problem due to the current implementation but we should fix this so it doesn't bite us later. Signed-off-by: Paul Moore [EMAIL PROTECTED

[PATCH 03/13] NetLabel: change netlbl_secattr_init() to return void

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The netlbl_secattr_init() function would always return 0 making it pointless to have a return value. This patch changes the function to return void. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- include/net/netlabel.h |6 ++ 1 files changed, 2

[PATCH 06/13] NetLabel: add tag verification when adding new CIPSOv4 DOI definitions

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Currently the CIPSOv4 engine does not do any sort of checking when a new DOI definition is added. The tags are still verified but only as a side effect of normal NetLabel operation (packet processing, socket labeling, etc.) which would cause application errors

[PATCH 01/13] NetLabel: use gfp_t instead of int where it makes sense

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] There were a few places in the NetLabel code where the int type was being used instead of the gfp_t type, this patch corrects this mistake. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- include/net/netlabel.h |2 +- 1 files changed, 1 insertion(+), 1

[PATCH 04/13] NetLabel: make netlbl_lsm_secattr struct easier/quicker to understand

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The existing netlbl_lsm_secattr struct required the LSM to check all of the fields to determine if any security attributes were present resulting in a lot of work in the common case of no attributes. This patch adds a 'flags' field which is used to indicate

[PATCH 13/13] NetLabel: honor the audit_enabled flag

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The audit_enabled flag is used to signal when syscall auditing is to be performed. While NetLabel uses a Netlink interface instead of syscalls, it is reasonable to consider the NetLabel Netlink interface as a form of syscall so pay attention

[PATCH 05/13] NetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Right now the NetLabel code always jumps into the CIPSOv4 layer to determine if a CIPSO IP option is present. However, we can do this check directly in the NetLabel code by making use of the CIPSO_V4_OPTEXIST() macro which should save us a function call

[PATCH 12/13] SELinux: peer secid consolidation for external network labeling

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Now that labeled IPsec makes use of the peer_sid field in the sk_security_struct we can remove a lot of the special cases between labeled IPsec and NetLabel. In addition, create a new function, security_skb_extlbl_sid(), which we can use in several places

[PATCH 07/13] NetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] While the original CIPSOv4 code had provisions for multiple tag types the implementation was not as great as it could be, pushing a lot of non-tag specific processing into the tag specific code blocks. This patch fixes that issue making it easier to support

[PATCH 10/13] NetLabel: use cipso_v4_doi_search() for local CIPSOv4 functions

2006-11-17 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The cipso_v4_doi_search() function behaves the same as cipso_v4_doi_getdef() but is a local, static function so use it whenever possibile in the CIPSOv4 code base. Signed-of-by: Paul Moore [EMAIL PROTECTED] --- net/ipv4/cipso_ipv4.c |6 +++--- 1 files

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-17 Thread Paul Moore
trying to keep the document alive. [1] http://en.wikipedia.org/wiki/Foobar My favorite wikipedia page - http://en.wikipedia.org/wiki/Mad_Scientist -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: Generic Netlink Updates

2006-11-14 Thread Paul Moore
Thomas Graf wrote: Various simplifications to the generic netlink interface partially based on suggestions by Paul Moore. Acked-by: Paul Moore [EMAIL PROTECTED] These changes all look good to me. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Paul Moore
. Thanks. I'm going to mail out the latest version (my first draft with everybody's patches) later today - I want to give Jamal a little bit longer to reply. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Paul Moore
; /* finalize the message */ So here I am applying this patch by hand because the diffs are a bit off and I come across this ... I think I might have to nix this change on the basis of rudimentary quality standards :) Besides, *I* brought sexy back. -- paul moore linux security @ hp

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Paul Moore
jamal wrote: On Mon, 2006-13-11 at 09:08 -0500, Paul Moore wrote: I want to give Jamal a little bit longer to reply. Sorry, family emergency - still ongoing today, so havent looked at anything (including presentation that was supposed to be done) ;- Give me a day or two (I know i

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Paul Moore
alloc_skb(size, flags); + return alloc_skb(nlmsg_total_size(payload), flags); } I like this approach, it makes much more sense to me then the previous implementation which was a simple alias to alloc_skb(). Also, the NetLabel relevant sections look fine to me. Acked-by: Paul Moore [EMAIL PROTECTED

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Thomas Graf wrote: * Paul Moore [EMAIL PROTECTED] 2006-11-10 01:08 Excellent! Thanks. - u32 snd_pid This is the PID of the client which issued the request. In order to avoid confusion it might be better to call it netlink PID as it is not equal to the process ID. Good point, I

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Jarek Poplawski wrote: On 10-11-2006 07:08, Paul Moore wrote: ... An Introduction To Using Generic Netlink === ... Here is a proposal of small adjustments. Maybe some of them will be useful. They all look very

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
jamal wrote: On Fri, 2006-10-11 at 01:45 -0500, Paul Moore wrote: James Morris wrote: An Introduction To Using Generic Netlink === Wow, this is great! Thanks. I consider it an act of penance for all of the evil

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Stephen Hemminger wrote: Paul Moore wrote: A couple of months ago I promised Jamal and Thomas I would post some comments to Jamal's original genetlink how-to. However, as I started to work on the document the diff from the original started to get a little ridiculous so instead of posting

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Randy Dunlap wrote: On Fri, 10 Nov 2006 01:08:23 -0500 Paul Moore wrote: An Introduction To Using Generic Netlink === 3.1.2. The genl_family Structure Generic Netlink services are defined by the genl_family structure

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Paul Moore
Thomas Graf wrote: * Paul Moore [EMAIL PROTECTED] 2006-11-10 11:04 I like this approach, it makes much more sense to me then the previous implementation which was a simple alias to alloc_skb(). Also, the NetLabel relevant sections look fine to me. Question is wheter to do the same

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-09 Thread Paul Moore
James Morris wrote: On Thu, 9 Nov 2006, Paul Moore wrote: It sounds like you have an idea of how you would like to see this implemented, can you give me a rough outline? Is this the partitioned SECMARK field you talked about earlier? No, just the fact that you are in the same kernel address

Generic Netlink HOW-TO based on Jamal's original doc

2006-11-09 Thread Paul Moore
request a NLMSG_ERROR message when no error has occurred by setting the NLM_F_ACK flag on requests. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-09 Thread Paul Moore
;) -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Paul Moore
consistent behavior for all addresses/interfaces Besides the performance penalty of IPsec and the untested nature of this solution is there some gotcha here which would prevent this from working? -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Paul Moore
James Morris wrote: On Wed, 8 Nov 2006, Paul Moore wrote: 1. Functionality is available right now, no additional kernel changes needed 2. No special handling for localhost, I tend to like the idea of having consistent behavior for all addresses/interfaces I don't agree. SO_PEERSEC should

Re: [PATCH 2/3] mlsxfrm: Various fixes

2006-11-08 Thread Paul Moore
James Morris wrote: On Wed, 8 Nov 2006, Paul Moore wrote: James Morris wrote: On Wed, 8 Nov 2006, Paul Moore wrote: 1. Functionality is available right now, no additional kernel changes needed 2. No special handling for localhost, I tend to like the idea of having consistent behavior for all

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sunday 05 November 2006 1:43 pm, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference to `cipso_v4_sock_getattr' Hmm, that's both strange and not good :( I'm grabbing Linus' latests bits and I'll see what I can do. -- paul

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
;) It looks like I was stupid and made NetLabel depend on CONFIG_NET and not CONFIG_INET, the patch below should fix this by making NetLabel depend on CONFIG_INET and CONFIG_SECURITY. Please review and apply for 2.6.19. Signed-off-by: Paul Moore [EMAIL PROTECTED] diff --git a/net/Kconfig b/net

Re: linux-2.6.19-rc4-g10b1fbdb build #114 failed

2006-11-05 Thread Paul Moore
On Sunday 05 November 2006 7:45 pm, David Miller wrote: From: Paul Moore [EMAIL PROTECTED] Date: Sun, 5 Nov 2006 16:24:07 -0500 (EST) On Sun, 5 Nov 2006, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... : undefined reference

[patch 0/1] NetLabel bugfix for 2.6.19

2006-10-30 Thread paul . moore
with the NetLabel/CIPSO options on a socket causing all sorts of nastiness. This patch should solve these problems. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[patch 1/1] NetLabel: protect the CIPSOv4 socket option from setsockopt()

2006-10-30 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] This patch makes two changes to protect applications from either removing or tampering with the CIPSOv4 IP option on a socket. The first is the requirement that applications have the CAP_NET_RAW capability to set an IPOPT_CIPSO option on a socket; this prevents

Re: [patch 1/1] NetLabel: protect the CIPSOv4 socket option from setsockopt()

2006-10-30 Thread Paul Moore
Eric Paris wrote: On Mon, 2006-10-30 at 13:03 -0500, [EMAIL PROTECTED] wrote: plain text document attachment (netlabel-sockopts) From: Paul Moore [EMAIL PROTECTED] This patch makes two changes to protect applications from either removing or tampering with the CIPSOv4 IP option on a socket

[PATCH 0/3] Collection of small NetLabel bugfixes

2006-10-11 Thread paul . moore
When doing some more testing today I ran into a few bugs, this patchset addresses those bugs. This patchset is backed against today's net-2.6 git tree. Please apply these patches for 2.6.19, thanks. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe

[PATCH 1/3] NetLabel: only deref the CIPSOv4 standard map fields when using standard mapping

2006-10-11 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Fix several places in the CIPSO code where it was dereferencing fields which did not have valid pointers by moving those pointer dereferences into code blocks where the pointers are valid. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- net/ipv4/cipso_ipv4.c

[PATCH 2/3] NetLabel: better error handling involving mls_export_cat()

2006-10-11 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] Upon inspection it looked like the error handling for mls_export_cat() was rather poor. This patch addresses this by NULL'ing out kfree()'d pointers before returning and checking the return value of the function everywhere it is called. Signed-off-by: Paul

[PATCH 3/3] NetLabel: the CIPSOv4 passthrough mapping does not pass categories correctly

2006-10-11 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] The CIPSO passthrough mapping had a problem when sending categories which would cause no or incorrect categories to be sent on the wire with a packet. This patch fixes the problem which was a simple off-by-one bug. Signed-off-by: Paul Moore [EMAIL PROTECTED

[PATCH 02/11] secid reconciliation: Add LSM hooks

2006-10-09 Thread paul . moore
CONFIG_SECURITY_NETWORK_XFRM set_to_dummy_if_null(ops, xfrm_policy_alloc_security); -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 04/11] secid reconciliation: Invoke LSM hook for outbound traffic

2006-10-09 Thread paul . moore
; } -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 03/11] secid reconciliation: Invoke LSM hook for inbound traffic

2006-10-09 Thread paul . moore
; + return xfrm_policy_check(sk, dir, skb, AF_INET6); } -#endif static __inline__ xfrm_address_t *xfrm_flowi_daddr(struct flowi *fl, unsigned short family) -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH 11/11] secid reconciliation: support for NetLabel

2006-10-09 Thread paul . moore
From: Paul Moore [EMAIL PROTECTED] This patch provides the missing NetLabel support to the secid reconciliation patchset. This includes a change to the security_skb_flow_in() LSM hook to indicate if the hook is in the forwarding path and a change to netlbl_skbuff_err() to carry the forwarding

[PATCH 01/11] secid reconciliation: new SELinux flask definitions

2006-10-09 Thread paul . moore
0x0001UL #define KEY__READ 0x0002UL -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 09/11] secid reconciliation: Track peersecid at connection establishment

2006-10-09 Thread paul . moore
= selinux_skb_flow_out, -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 07/11] secid reconciliation: Enforcement for SELinux

2006-10-09 Thread paul . moore
to retrieve the context of a UDP packet - * based on its security association used to connect to the remote socket. + * based on its security association. * * Retrieve via setsockopt IP_PASSSEC and recvmsg with control message * type SCM_SECURITY. -- paul moore linux security @ hp

[PATCH 08/11] secid reconciliation: Use secmark when classifying flow using skb

2006-10-09 Thread paul . moore
inline void security_flow_classif { } +static inline void security_skb_classify_flow(struct sk_buff *skb, + struct flowi *fl) +{ +} + #endif /* CONFIG_SECURITY_NETWORK */ #endif /* __KERNEL__ */ -- paul moore linux security @ hp - To unsubscribe from

[PATCH 05/11] secid reconciliation: Label locally generated IPv6 traffic

2006-10-09 Thread paul . moore
(no data) */ tcph-doff = sizeof(struct tcphdr)/4; -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 10/11] secid reconciliation: various fixes

2006-10-09 Thread paul . moore
=selinux_igmp_classify_skb, .skb_flow_in = selinux_skb_flow_in, .skb_flow_out = selinux_skb_flow_out, -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 00/11] The _entire_ secid reconciliation patchset (tada!)

2006-10-09 Thread Paul Moore
first. I'll keep the patchset up to date and keep tracking the secid patches (I know there has been discussion around the IGMP hook this morning). Once everything looks okay I'll resend the patchset (with any updates/corrections/etc.) again. -- paul moore linux security @ hp - To unsubscribe from

[PATCH 1/1] NetLabel: use SECINITSID_UNLABELED for a base SID

2006-10-05 Thread paul . moore
This patch changes NetLabel to use SECINITSID_UNLABLELED as it's source of SELinux type information when generating a NetLabel context. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux/ss/services.c | 29 + 1 files changed, 9 insertions(+), 20

[PATCH 0/1] NetLabel changes from yesterday's discussion

2006-10-05 Thread paul . moore
address the issue. This patch does not rely on the secid patches currently in progress and should be considered a bugfix against the current net-2.6 tree. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 1/1] secid reconcialiation: Replace unlabeled_t with the network_t

2006-10-04 Thread Paul Moore
if it would also make sense to update the secmark to SECINITSID_UNLABELED in the abscence of any external labeling (labeled IPsec or NetLabel)? -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 1/1] secid reconcialiation: Replace unlabeled_t with the network_t

2006-10-04 Thread Paul Moore
Paul Moore wrote: Venkat Yekkirala wrote: The following replaces unlabeled_t with network_t for better characterization of the flow out/in checks in SELinux, as well as to allow for mls packets to flow out/in from the network since network_t would allow the full range of MLS labels, as opposed

Re: [PATCH 1/1] secid reconcialiation: Replace unlabeled_t with the network_t

2006-10-04 Thread Paul Moore
Christopher J. PeBenito wrote: On Wed, 2006-10-04 at 10:33 -0400, Paul Moore wrote: Venkat Yekkirala wrote: The following replaces unlabeled_t with network_t for better characterization of the flow out/in checks in SELinux, as well as to allow for mls packets to flow out/in from the network

[PATCH v4 1/2] NetLabel: secid reconciliation support

2006-10-04 Thread paul . moore
This patch provides the missing NetLabel support to the secid reconciliation patchset. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux/hooks.c| 104 +-- security/selinux/include/objsec.h |1 security/selinux/include

[PATCH 0/2] [PATCH 0/2] Updated NetLabel/secid-reconciliation bits and a bugfix

2006-10-04 Thread paul . moore
a bug which has been around since the very first NetLabel patches (not sure why I didn't see this sooner). -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 2/2] NetLabel: fix a cache race condition

2006-10-04 Thread paul . moore
-off-by: Paul Moore [EMAIL PROTECTED] --- include/net/netlabel.h | 62 +++-- net/ipv4/cipso_ipv4.c | 18 ++- net/netlabel/netlabel_kapi.c |2 - security/selinux/ss/services.c | 37 +--- 4 files changed, 79

Re: [PATCH v4 1/2] NetLabel: secid reconciliation support

2006-10-04 Thread Paul Moore
way or the other unless the above differences in behavior are desired or somehow accounted for in policy and apps. I agree - I'd like to hear what others (namely Stephen Smalley, James Morris and all of the Tresys folks past and present) have to say on this issue. -- paul moore linux security

Re: [PATCH 0/2] [PATCH 0/2] Updated NetLabel/secid-reconciliation bits and a bugfix

2006-10-04 Thread Paul Moore
. I think it's easier to decide on policy, review the design, and test it all if there is one place/patchset with all of the latest bits/patches. Right not it's not that easy with different patches scattered around. -- paul moore linux security @ hp - To unsubscribe from this list: send the line

Re: [PATCH 7/9] secid reconciliation-v04: Enforcement for SELinux

2006-10-02 Thread Paul Moore
) + goto out; + + if (xfrm_sid) + skb-secmark = xfrm_sid; + + /* See if NetLabel can flow in thru the current secmark here */ + +out: + return err ? 0 : 1; +}; -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 7/9] secid reconciliation-v04: Enforcement for SELinux

2006-10-02 Thread Paul Moore
Stephen Smalley wrote: On Mon, 2006-10-02 at 12:12 -0400, Paul Moore wrote: Venkat Yekkirala wrote: This defines SELinux enforcement of the 2 new LSM hooks as well as related changes elsewhere in the SELinux code. This also now keeps track of the peersid thru the establishment of a connection

Re: [PATCH 7/9] secid reconciliation-v04: Enforcement for SELinux

2006-10-02 Thread Paul Moore
out like the rest of the code already does (if that meets your needs that is). -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/1] Respun patch to match the latest secid patchset

2006-10-02 Thread paul . moore
deal with the other cleanups once I can prove them during testing. Please consider this for inclusion in 2.6.19. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread paul . moore
This patch provides the missing NetLabel support to the secid reconciliation patchset. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux/hooks.c| 67 +++-- security/selinux/include/objsec.h |1 security/selinux/include

Re: [PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread Paul Moore
Stephen Smalley wrote: On Mon, 2006-10-02 at 14:06 -0400, [EMAIL PROTECTED] wrote: plain text document attachment (netlabel-secid_support) This patch provides the missing NetLabel support to the secid reconciliation patchset. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux

Re: [PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread Paul Moore
Stephen Smalley wrote: On Mon, 2006-10-02 at 14:06 -0400, [EMAIL PROTECTED] wrote: plain text document attachment (netlabel-secid_support) This patch provides the missing NetLabel support to the secid reconciliation patchset. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux

[PATCH v3 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread paul . moore
This patch provides the missing NetLabel support to the secid reconciliation patchset. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux/hooks.c| 80 ++--- security/selinux/include/objsec.h |1 security/selinux/include

[PATCH v3 0/1] One more time ...

2006-10-02 Thread paul . moore
Version 3 of the NetLabel support for the secid patchset. This version takes into account comments made by Stephen Smalley. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
and allow both labeling methods on the same connection we'll need to decide how to handle resolving the two - maybe use a transition is this one case? -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
something like that would be acceptable. So, in summary, we would do the normal flow_in checks for both IPsec and NetLabel and then set the secmark using the IPsec label as the base sid for the NetLabel's generated SID? -- paul moore linux security @ hp - To unsubscribe from this list: send the line

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
. -- paul moore linux security @ hp - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

<    1   2   3   4   5   6   >