Change tcf_police_rate_bytes_ps() and tcf_police_tcfp_burst() helpers to
> allow using them from both rtnl and rcu protected contexts.
>
> Fixes: 8c8cfc6ed274 ("net/sched: add police action to the hardware
> intermediate representation")
> Signed-off-by: Vlad Buslov
Thank you Vlad.
Reviewed-by: Pieter Jansen van Vuuren
group() helper to allow using it from both rtnl
> and rcu protected contexts.
>
> Fixes: a7a7be6087b0 ("net/sched: add sample action to the hardware
> intermediate representation")
> Signed-off-by: Vlad Buslov
Thanks
Reviewed-by: Pieter Jansen van Vuuren
On Tue, 7 Nov 2017 08:54:20 -0800
Alexander Duyck wrote:
> On Mon, Nov 6, 2017 at 10:37 AM, Pieter Jansen van Vuuren
> wrote:
> > On Fri, 3 Nov 2017 11:50:47 -0400
> > Manish Kurup wrote:
> >
> >> Using a spinlock in the VLAN action causes performance is
On Fri, 3 Nov 2017 11:50:47 -0400
Manish Kurup wrote:
> Using a spinlock in the VLAN action causes performance issues when the VLAN
> action is used on multiple cores. Rewrote the VLAN action to use RCU read
> locking for reads and updates instead.
>
> Acked-by: Jamal Hadi Salim
> Acked-by: Ji
_vid(action))
> | NFP_FL_PUSH_VLAN_CFI;
> push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
> }
Thank you for this; you may consider this patch:
Reviewed-by: Pieter Jansen van Vuuren
On Mon, 6 Nov 2017 11:52:37 -0500
Manish Kurup wrote:
> Hi Dave,
>
> On Sun, Nov 5, 2017 at 8:08 AM, David Miller wrote:
>
> > From: Manish Kurup
> > Date: Fri, 3 Nov 2017 11:49:19 -0400
> >
> > > Modified the netronome drivers (flower action) to use the VLAN helper
> > > functions instead
On Tue, 31 Oct 2017 10:16:05 -0400
Manish Kurup wrote:
> Hi Pieter,
>
> On Tue, Oct 31, 2017 at 9:06 AM, Pieter Jansen van Vuuren <
> pieter.jansenvanvuu...@netronome.com> wrote:
>
> > On Sun, 29 Oct 2017 04:47:54 -0400
> > Manish Kurup wrote:
> >
&g
On Sun, 29 Oct 2017 04:47:54 -0400
Manish Kurup wrote:
> Using a spinlock in the VLAN action causes performance issues when the VLAN
> action is used on multiple cores. Rewrote the VLAN action to use RCU read
> locking for reads and updates instead.
> Fixed nxp flower action to use VLAN helper fu
Previously the vlan tci field was incorrectly exact matched. This patch
fixes this by using the flow dissector to populate the vlan tci field.
Fixes: 5571e8c9f241 ("nfp: extend flower matching capabilities")
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Reviewed
("nfp: extend flower add flow offload")
Signed-off-by: Pieter Jansen van Vuuren
Reviewed-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/flower/offload.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/net/ethernet/net
matching.
Pieter Jansen van Vuuren (3):
nfp: fix unchecked flow dissector use
nfp: fix supported key layers calculation
nfp: remove incorrect mask check for vlan matching
drivers/net/ethernet/netronome/nfp/flower/match.c | 139 +++--
.../net/ethernet/netronome/nfp/flower
Previously flow dissectors were referenced without first checking that
they are in use and correctly populated by TC. This patch fixes this by
checking each flow dissector key before referencing them.
Fixes: 5571e8c9f241 ("nfp: extend flower matching capabilities")
Signed-off-by: Pie
12 matches
Mail list logo
