Hi Antoine,
On 2020-06-19 14:22, Antoine Tenart wrote:
[...]
@@ -999,9 +1553,35 @@ int vsc8584_ptp_probe(struct phy_device *phydev)
if (!vsc8531->ptp)
return -ENOMEM;
+ mutex_init(&vsc8531->phc_lock);
mutex_init(&vsc8531->ts_lock);
+ /* Retrieve the
Hi Antoine,
Feels weird to review my own patches a year later having written them,
almost nostalgic :)
The review is mostly nitpicks.
On 2020-06-19 14:22, Antoine Tenart wrote:
[...]
@@ -373,6 +374,21 @@ struct vsc8531_private {
unsigned long ingr_flows;
unsigned long egr_flows
Hi Antoine,
On 2020-06-19 14:22, Antoine Tenart wrote:
This patch takes in account the use of the 1588 block in the MACsec
initialization, as a conditional configuration has to be done (when the
1588 block is used).
Signed-off-by: Antoine Tenart
---
drivers/net/phy/mscc/mscc_macsec.c | 4 +++-
store_page
functions")
Signed-off-by: Quentin Schulz
---
v3:
- remove useless goto label and condition,
v2:
- use phy_modify_paged instead of
phy_select_page -> __phy_read -> __phy_write -> phy_restore_page
drivers/net/phy/mscc.c | 14 +-
1 file changed, 5 in
Hi Andrew,
On Fri, Nov 23, 2018 at 04:08:06PM +0100, Andrew Lunn wrote:
> On Fri, Nov 23, 2018 at 09:16:36AM +0100, Quentin Schulz wrote:
> > The vsc85xx_default_config function called in the vsc85xx_config_init
> > function which is used by VSC8530, VSC8531, VSC8540 a
Hi Andrew,
On Fri, Sep 14, 2018 at 07:27:54PM +0200, Andrew Lunn wrote:
>
> > struct vsc8531_private {
> > int rate_magic;
> > u16 supp_led_modes;
> > @@ -181,6 +354,7 @@ struct vsc8531_private {
> > struct vsc85xx_hw_stat *hw_stats;
> > u64 *stats;
> > int nstats;
> > + bo
.
Signed-off-by: Quentin Schulz
---
v2:
- return -EINVAL when phy-reset-post-delay is greater than 1000ms
instead of defaulting to 1ms,
- remove `default to 1ms` when phy-reset-post-delay > 1000Ms from DT
binding doc and commit log,
- move phy-reset-post-delay property reading bef
Hi Andrew
On 22/05/2017 15:57, Andrew Lunn wrote:
> On Mon, May 22, 2017 at 11:15:17AM +0200, Quentin Schulz wrote:
>> Some PHY require to wait for a bit after the reset GPIO has been
>> toggled. This adds support for the DT property `phy-reset-post-delay`
>> which gives the
and are default to 1ms.
Signed-off-by: Quentin Schulz
---
Documentation/devicetree/bindings/net/fsl-fec.txt | 5 +
drivers/net/ethernet/freescale/fec_main.c | 17 +++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net
Hi all,
On 05/05/2017 15:50, Quentin Schulz wrote:
> To avoid possible ECC/parity checksum errors when reading an
> uninitialized buffer, the entire Message RAM is initialized when probing
> the driver. This initialization is done in the same function reading the
> Device Tre
it can
be called separately from device initialization from Device Tree.
Signed-off-by: Quentin Schulz
---
v4:
- remove unused variables from m_can_of_parse_mram,
drivers/net/can/m_can/m_can.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a
This creates a function to ungate M_CAN clocks and another to gate the
same clocks, then swaps all gating/ungating code with their respective
function.
Signed-off-by: Quentin Schulz
---
added in v4
drivers/net/can/m_can/m_can.c | 45 +--
1 file changed
This moves clocks gating outside of the m_can_stop function as the
m_can_start function does not (and cannot, at least in current
implementation) ungate clocks. This way, both functions can now be used
symmetrically.
Signed-off-by: Quentin Schulz
---
added in v4
drivers/net/can/m_can/m_can.c
This adds Power Management deep Suspend/Resume support for Bosch M_CAN
chip.
When entering deep sleep, the clocks are gated, the interrupts are
disabled. When resuming from deep sleep, the chip needs to be
reinitialized, the clocks ungated and the interrupts enabled.
Signed-off-by: Quentin
it can
be called separately from device initialization from Device Tree.
Signed-off-by: Quentin Schulz
---
drivers/net/can/m_can/m_can.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
This adds Power Management deep Suspend/Resume support for Bosch M_CAN
chip.
When entering deep sleep, the clocks are gated, the interrupts are
disabled. When resuming from deep sleep, the chip needs to be
reinitialized, the clocks ungated and the interrupts enabled.
Signed-off-by: Quentin
Hum, forgot the changelog.
On 03/05/2017 14:37, Quentin Schulz wrote:
> This adds Power Management deep Suspend/Resume support for Bosch M_CAN
> chip.
>
> When the system resumes from deep sleep, the chip needs to be fully
> reinitialized (RAM, chip, clocks, irq, candev, ...) t
it can
be called separately from device initialization from Device Tree.
Signed-off-by: Quentin Schulz
---
drivers/net/can/m_can/m_can.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
This adds Power Management deep Suspend/Resume support for Bosch M_CAN
chip.
When the system resumes from deep sleep, the chip needs to be fully
reinitialized (RAM, chip, clocks, irq, candev, ...) to be functional.
Signed-off-by: Quentin Schulz
---
drivers/net/can/m_can/m_can.c | 8 +++-
1
Hi Marc,
On 03/05/2017 14:16, Marc Kleine-Budde wrote:
> On 05/03/2017 02:11 PM, Quentin Schulz wrote:
>> This adds Power Management deep Suspend/Resume support for Bosch M_CAN
>> chip.
>>
>> When the chip resumes from deep sleep, the RAM needs to be initialized
>&
it can
be called separately from device initialization from Device Tree.
Signed-off-by: Quentin Schulz
---
drivers/net/can/m_can/m_can.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
This adds Power Management deep Suspend/Resume support for Bosch M_CAN
chip.
When the chip resumes from deep sleep, the RAM needs to be initialized
as it is done when the driver probes. The net interface also needs to be
closed and reopened to be fully functional.
Signed-off-by: Quentin Schulz
olfgang Grandegger
>> Cc: Alexandre Belloni ; Florian
>> Fainelli
>> ; Quentin Schulz ;
>> Wenyou Yang - A41535 ; Nicolas Ferre
>> ; linux-...@vger.kernel.org; netdev@vger.kernel.org;
>> linux-ker...@vger.kernel.org
>> Subject: Re: [PATCH v2] can: m_can: en
= 0x31040730)
Signed-off-by: Florian Vallee
Tested-by: Quentin Schulz
---
drivers/net/can/m_can/m_can.c | 38 +++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 195f15e
24 matches
Mail list logo
