This shrinks the code a little.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 34 ---
1 file changed, 9 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
>From Documentation/networking/driver.txt
If you return NETDEV_TX_BUSY from the ndo_start_xmit method, you
must not keep any reference to that SKB and you must not attempt
to free it up.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 2 --
1 file changed, 2 deleti
This way both if clauses assign last_bdp instead
of only one clause overriding the default.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index bc084ad9..da2e3c530 100644
--- a/drivers
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 98b9be2..380c8e2 100644
--- a/drivers/net/ethernet/freescale
This saves 1 comparison.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 1a838cc..fcbbf0d 100644
Signed-off-by: Troy Kisky
---
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
index a35d54f..771f650 100644
--- a/arch/arm/boot/dts/imx6qdl
Unmap descriptors upon error.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index
Perform skb_tx_timestamp before transferring ownership
This shrinks the window for 'tx int lost'
If the packet is transmitted and napi clears the tx interrupt
before the txq->bd.cur assignment, then the tx interrupt is
effectively lost.
Signed-off-by: Troy Kisky
---
drivers
When the tx queue is dumped, it is easier to see that this
entry is idle.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 29c5781..98b9be2 100644
--- a/drivers/net/ethernet
Signed-off-by: Troy Kisky
---
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index caeed56..1d42331 100644
--- a/arch/arm/boot/dts/imx6qdl
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 7258051..e141f6f 100644
--- a/drivers/net/ethernet
If a bootloader initializes the mac, prefer that
to device tree or fuses.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 33 +--
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b
This is for debug purposes. If a receive interrupt
is lost, writing to this file can recover the FEC.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 52 +++
1 file changed, 52 insertions(+)
diff --git a/drivers/net/ethernet/freescale
removal of fec_enet_get_prevdesc.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 14 +---
drivers/net/ethernet/freescale/fec_main.c | 38 ++-
2 files changed, 18 insertions(+), 34 deletions(-)
diff --git a/drivers/net/ethernet
next packet is transmitted.
This patch also has the advantage of increasing iperf speed.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 15a93f90..3ed79fd 100644
--- a/drivers/net/ethernet
Dump all tx queues, not just queue 0.
Also, disable fec interrupts first.
The interrupts will be reenabled in fec_restart.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 36 +--
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git
The queue_id is the qid member of struct bufdesc_prop.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
Print the current interrupt flags and mask and
the interrupt state during the last interrupt in
fec_timeout.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 1 +
drivers/net/ethernet/freescale/fec_main.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index cf53e21..7258051 100644
--- a/drivers/net/ethernet/freescale
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index e8f35fb..b87f80d 100644
--- a/drivers/net
l now continue to
receive the previously pending packets.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 6 +-
drivers/net/ethernet/freescale/fec_main.c | 127 --
2 files changed, 50 insertions(+), 83 deletions(-)
diff --git a/drivers/net/eth
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index b87f80d..15a93f90 100644
--- a/drivers/net/ethernet
Relying on the wrap bit to stay valid once initialized
when the controller also writes to this byte seems
undesirable since we can easily know what the value
should be.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 31 ++-
1 file changed
instead.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 620834f..8e1f2a6 100644
--- a/drivers/net/ethernet
queue_id is the qid member of struct bufdesc_prop.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 380c8e2..cf53e21 100644
--- a/drivers/net/ethernet
FEC_ENET_RXF is 3 separate bits, we only check one queue
at a time. So, when the last queue is being checked, it is
bad to remove the interrupt on the 1st queue.
Also, since this is now done in the napi
routine and not the interrupt, it is not needed.
Signed-off-by: Troy Kisky
---
drivers/net
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index da2e3c530..29c5781 100644
--- a/drivers/net
On 1/28/2016 3:02 PM, Arnd Bergmann wrote:
> On Thursday 28 January 2016 14:25:32 Troy Kisky wrote:
>> Signed-off-by: Troy Kisky
>> ---
>> drivers/net/ethernet/freescale/fec_main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> [note: missi
On 3/3/2018 1:12 PM, Guenter Roeck wrote:
> On 03/03/2018 12:48 PM, Guenter Roeck wrote:
>> On 03/03/2018 11:07 AM, Troy Kisky wrote:
>>> On 3/3/2018 8:32 AM, Guenter Roeck wrote:
>>>> Hi,
>>>>
>>>> since v4.15, I get the following runtime wa
On 3/3/2018 8:32 AM, Guenter Roeck wrote:
> Hi,
>
> since v4.15, I get the following runtime warning when running sabrelite images
> in qemu.
>
> irq 65: nobody cared (try booting with the "irqpoll" option)
> ...
> handlers:
> [<26292474>] fec_pps_interrupt
> Disabling IRQ #65
> fec 2188000.ether
On 1/2/2018 6:39 PM, Fugang Duan wrote:
> The static variable dev_id always plus one before netdev registerred.
> It should restore the dev_id value in the cases of probe error.
>
> Signed-off-by: Fugang Duan
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 +
> 1 file changed, 1 insertion(
101 - 135 of 135 matches
Mail list logo