Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-04 Thread roopa
On 6/4/15, 8:04 AM, Toshiaki Makita wrote: On 15/06/04 (木) 3:41, roopa wrote: On 6/3/15, 8:43 AM, Toshiaki Makita wrote: On 15/06/03 (水) 4:01, Scott Feldman wrote: On Tue, Jun 2, 2015 at 9:58 AM, roopa ro...@cumulusnetworks.com wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2

[PATCH WIP RFC 3/3] mpls: register lwtunnel ops

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com - This is just part of the patch. Unfortunately i realized that my tree has other changes for mpls unrelated to ler - also, The nla_put and nla_get label are different in the patch than upstream because of some other changes in my tree Signed-off

[PATCH WIP RFC 2/3] ipv4 fib: lwtunnel handling

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com - parse RTA_ENCAP - store lwtstate in every nexthop - set dst-output to point to lwtunnel output Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/dst.h|2 ++ include/net/ip_fib.h |5 - net/ipv4

[PATCH WIP RFC 0/3] mpls: support for ler

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This is still WIP and incomplete. Posting it here because of the other discussions happening around mpls ler in the context of Roberts code and I happened to mention this implementation. This was in response to earlier email thread with Eric on net

[PATCH WIP RFC 1/3] lwtunnels: basic infra for light weight tunnels like mpls

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Still in the works. Not fully functional. And in some cases me going back and forth on a few things. Started with thinking the tunnel hdr can be shared and refcounted. Its somewhere mid way now. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-03 Thread roopa
On 6/2/15, 12:01 PM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 9:58 AM, roopa ro...@cumulusnetworks.com wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim j...@mojatatu.com wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-03 Thread roopa
On 6/3/15, 8:43 AM, Toshiaki Makita wrote: On 15/06/03 (水) 4:01, Scott Feldman wrote: On Tue, Jun 2, 2015 at 9:58 AM, roopa ro...@cumulusnetworks.com wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim j...@mojatatu.com wrote: On 06/02/15 03:10

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread roopa
On 6/2/15, 11:30 AM, Eric W. Biederman wrote: roopa ro...@cumulusnetworks.com writes: On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread roopa
On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack

[PATCH net iproute2 v4] mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for route add/deletes

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread roopa
On 6/2/15, 2:13 PM, Eric W. Biederman wrote: So I just stopped and looked at what is happening. When you originally reported this you said (or at least I understood) that rtm_scope was not being set in iproute. I assumed that meant it was not being touched and it was taking a default value of

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread roopa
On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an interface for each tunnel endpoint doesn't

Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread roopa
On 6/1/15, 3:58 PM, David Miller wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Wed, 27 May 2015 11:37:05 -0700 - if (rtm-rtm_scope != RT_SCOPE_UNIVERSE) - goto errout; + if (nlh-nlmsg_type != RTM_DELROUTE + rtm-rtm_scope != RT_SCOPE_UNIVERSE

Re: [RFC net-next 2/3] ipv4: storing and retrieval of per-nexthop encap

2015-06-02 Thread roopa
On 6/1/15, 9:46 AM, Robert Shearman wrote: Parse RTA_ENCAP attribute for one path and multipath routes. The encap length is stored in a newly added field to fib_nh, nh_encap_len, although this is added to a padding hole in the structure so that it doesn't increase the size at all. The encap data

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread roopa
On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack of labels, in the same format as for RTA_NEWST. It uses the encap data which

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread roopa
On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim j...@mojatatu.com wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says master is the default. Want we want, I believe, is to adjust what the man

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-06-02 Thread roopa
On 5/27/15, 9:01 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On Wed, May 27, 2015 at 9:59 AM, Scott Feldman sfel...@gmail.com wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On

[PATCH net v3 0/2] mpls: fix route del errors on wrong scope and type

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

[PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Ignore scope for route del messages Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com Reviewed-by: Robert Shearman rshea...@brocade.com --- net/mpls/af_mpls.c |3 ++- 1 file changed

[PATCH net iproute2 v3 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com Reviewed-by: Robert Shearman rshea...@brocade.com --- ip/iproute.c |5 + 1

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 3:35 PM, Andy Gospodarek wrote: On Thu, May 28, 2015 at 08:40:11AM -0700, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-28 Thread roopa
On 5/28/15, 9:10 AM, John Fastabend wrote: On 05/28/2015 08:40 AM, Scott Feldman wrote: On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote: Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16

[PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- ip/iproute.c |5 + 1 file changed, 5 insertions(+) diff --git a/ip

[PATCH net v2 0/2] mpls: fix route del errors on wrong scope and type

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

[PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Ignore scope for route del messages Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread roopa
On 5/27/15, 12:59 PM, Robert Shearman wrote: On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread roopa
On 5/27/15, 1:08 PM, roopa wrote: On 5/27/15, 12:59 PM, Robert Shearman wrote: On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off

[PATCH net] mpls: fix mpls route deletes to not check for route scope and type

2015-05-26 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL error due to invalid scope and type for mpls route deletes. iproute2 route modify code does not set protocol/scope/type for RTM_DELROUTE msgs. mpls code can skip checking for these too. $ip -f mpls route add 100

Re: [PATCH net] mpls: fix mpls route deletes to not check for route scope and type

2015-05-26 Thread roopa
On 5/26/15, 2:48 PM, Eric W. Biederman wrote: Roopa Prabhu ro...@cumulusnetworks.com writes: From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL error due to invalid scope and type for mpls route deletes. Well this is embarrassing apparently I did not exercise

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread roopa
and multicast_router attributes can be changed even if the according bridge (port) is down, just like other other bridge (port) attributes allow too. Signed-off-by: Linus Lüssing linus.luess...@c0d3.blue --- Changelog: * [RFC PATCH net-next] - [PATCH net-next] Acked-by: Roopa Prabhu ro

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-21 Thread roopa
(not the change Roopa has proposed) that you would be open to considering a change the current behavior? I am saying that we have a contract with users not to break existing behavior. Full stop. After rehearing David's argument, we should probably explore option d) which is a refinement

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-18 Thread roopa
On 5/18/15, 1:19 PM, David Miller wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Date: Sun, 17 May 2015 16:42:05 -0700 On most systems where you can offload routes to hardware, doing routing in software is not an option (the cpu limitations make routing impossible in software). You

Re: [PATCH net-next v5 12/21] switchdev: remove old switchdev_port_bridge_setlink

2015-05-05 Thread roopa
On 5/5/15, 10:34 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com New attr-based bridge_setlink can recurse lower devs and recover on err, so remove old wrapper. Also, restore br_setlink back to original and don't call into SELF port driver. rtnetlink.c:bridge_setlink

Re: [PATCH net-next v4 00/24] switchdev: spring cleanup

2015-04-16 Thread roopa
On 4/13/15, 10:47 PM, roopa wrote: On 4/12/15, 11:16 PM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com v4: Well, it was a lot of work, but now prepare-commit transaction model is how davem advises: if prepare fails, abort the transaction. The driver must do resource

<    4   5   6   7   8   9