From: Eric Dumazet [EMAIL PROTECTED]
Date: Tue, 08 Jan 2008 08:53:10 +0100
It warns us because rt_cache_get_first() can returns with RCU_BH
*acquired* or not.
As Herbert mentioned that's a pretty often used paradigm called
conditional locking. :-)
--
To unsubscribe from this list: send the
On 08-01-2008 08:53, Eric Dumazet wrote:
David Miller a écrit :
...
Furthermore, these:
rcu_read_unlock_bh()
rcu_read_lock_bh()
sequences are at best funny looking. For other lock types we would
look at this and ask Does this even accomplish anything reliably?
Well, original
CHECK net/ipv4/route.c
net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' -
wrong count at exit
net/ipv4/route.c:307:3: warning: context imbalance in 'rt_cache_get_next' -
unexpected unlock
net/ipv4/route.c:346:3: warning: context imbalance in 'rt_cache_seq_stop' -
Eric Dumazet [EMAIL PROTECTED] wrote:
CHECK net/ipv4/route.c
net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' -
wrong count at exit
net/ipv4/route.c:307:3: warning: context imbalance in 'rt_cache_get_next' -
unexpected unlock
net/ipv4/route.c:346:3: warning:
On Mon, 07 Jan 2008 23:11:53 +1100
Herbert Xu [EMAIL PROTECTED] wrote:
Eric Dumazet [EMAIL PROTECTED] wrote:
CHECK net/ipv4/route.c
net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first'
- wrong count at exit
net/ipv4/route.c:307:3: warning: context imbalance in
On Mon, Jan 07, 2008 at 02:56:24PM +0100, Eric Dumazet wrote:
AFAIK, this patch reduces complexity and text size.
But if we had loads of empty hash buckets couldn't this potentially
increase latency by disabling BH longer than before?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Herbert Xu a écrit :
On Mon, Jan 07, 2008 at 02:56:24PM +0100, Eric Dumazet wrote:
AFAIK, this patch reduces complexity and text size.
But if we had loads of empty hash buckets couldn't this potentially
increase latency by disabling BH longer than before?
Well, we call
On Mon, Jan 07, 2008 at 09:46:45PM +0100, Eric Dumazet wrote:
Well, we call rcu_read_unlock_bh()/rcu_read_lock_bh() for each bucket,
empty or not, before and after patch, so we dont change latency.
Oh I see. Your patch looks good then. But we still need a solution
in general unless we're to
From: Eric Dumazet [EMAIL PROTECTED]
Date: Mon, 7 Jan 2008 12:01:17 +0100
CHECK net/ipv4/route.c
net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' -
wrong count at exit
net/ipv4/route.c:307:3: warning: context imbalance in 'rt_cache_get_next' -
unexpected
David Miller a écrit :
From: Eric Dumazet [EMAIL PROTECTED]
Date: Mon, 7 Jan 2008 12:01:17 +0100
CHECK net/ipv4/route.c
net/ipv4/route.c:298:2: warning: context imbalance in 'rt_cache_get_first' -
wrong count at exit
net/ipv4/route.c:307:3: warning: context imbalance in
10 matches
Mail list logo