Re: [PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-12 Thread Kok, Auke
Joe Perches wrote: On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote: +#define ndev_err(netdev, level, format, arg...) \ + do { \ + struct net_device *__nd = (netdev); \ + if ((__nd)->msg_enable & NETIF_MSG_##level) \ + printk(KERN_ERR "%s:

Re: [PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-12 Thread Kok, Auke
Jeff Garzik wrote: Joe Perches wrote: On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote: +#define ndev_err(netdev, level, format, arg...) \ + do { \ + struct net_device *__nd = (netdev); \ + if ((__nd)->msg_enable & NETIF_MSG_##level) \ +

Re: [PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-12 Thread Jeff Garzik
Joe Perches wrote: On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote: +#define ndev_err(netdev, level, format, arg...) \ + do { \ + struct net_device *__nd = (netdev); \ + if ((__nd)->msg_enable & NETIF_MSG_##level) \ + printk(KERN_ERR "%s:

Re: [PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-12 Thread Joe Perches
On Mon, 2007-06-11 at 17:40 -0700, Auke Kok wrote: > +#define ndev_err(netdev, level, format, arg...) \ > + do { \ > + struct net_device *__nd = (netdev); \ > + if ((__nd)->msg_enable & NETIF_MSG_##level) \ > + printk(KERN_ERR "%s: %s: " format, (__nd

[PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
A lot of netdevices implement their own variant of printk and use use variations of dev_printk, printk or others that use msg_enable, which has been an eyesore with countless variations across drivers. This patch implements a standard ndev_printk and derivatives such as ndev_err, ndev_info, ndev_w