Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread James Chapman
Mandeep Singh Baines wrote: Daniele Venzano ([EMAIL PROTECTED]) wrote: The patch looks good and I think it can be pushed higher (-mm ?) for some wider testing. I don't have the hardware available to do some tests myself, unfortunately, but it would be similar to yours anyway. I'd like to

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread James Chapman
jamal wrote: On Wed, 2007-05-09 at 13:03 +0100, James Chapman wrote: I have a patch that solves the high interrupt rate problem by keeping the driver in polled mode longer. It's written for the latest NAPI version that DaveM posted recently. I'll try to get some time to write it up and post

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread jamal
On Wed, 2007-05-09 at 14:55 +0100, James Chapman wrote: Thanks Jamal. Yes, I'd already read your paper. I think my idea is different to the ideas described in your paper I am hoping you can pick from the lessons of what has been tried and failed and the justification for critiqueing

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread Mandeep Singh Baines
jamal ([EMAIL PROTECTED]) wrote: On Wed, 2007-05-09 at 14:55 +0100, James Chapman wrote: Thanks Jamal. Yes, I'd already read your paper. I think my idea is different to the ideas described in your paper I am hoping you can pick from the lessons of what has been tried and failed and

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread jamal
On Mon, 2007-03-09 at 20:20 -0700, Mandeep Singh Baines wrote: I didn't see much saving in interrupts on my machine (too fast, I guess). You could try the idea suggested by Dave earlier and just turn interupts for every nth packet. That should cut down the numbers. I did see a significant

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread Daniele Venzano
- Message d'origine - De: Mandeep Singh Baines [EMAIL PROTECTED] Date: Mon, 3 Sep 2007 20:20:36 -0700 Sujet: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition Hi Daniele, Attached is a patch for converting the sis900 driver to NAPI. Please take a look at let me know

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread Mandeep Baines
On 9/4/07, jamal [EMAIL PROTECTED] wrote: On Mon, 2007-03-09 at 20:20 -0700, Mandeep Singh Baines wrote: I didn't see much saving in interrupts on my machine (too fast, I guess). You could try the idea suggested by Dave earlier and just turn interupts for every nth packet. That should cut

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-04 Thread Mandeep Baines
Baines [EMAIL PROTECTED] Date: Mon, 3 Sep 2007 20:20:36 -0700 Sujet: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition Hi Daniele, Attached is a patch for converting the sis900 driver to NAPI. Please take a look at let me know what you think. I'm not 100% sure if I'm

[PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-03 Thread Mandeep Singh Baines
Hi Daniele, Attached is a patch for converting the sis900 driver to NAPI. Please take a look at let me know what you think. I'm not 100% sure if I'm handling the rotting packet issue correctly or that I have the locking right in tx_timeout. These might be areas to look at closely. I didn't see