Re: [PATCH] Ipvlan should return an error when an address is already in use.

2017-01-04 Thread Krister Johansen
On Tue, Jan 03, 2017 at 02:24:43PM -0500, Aaron Conole wrote: > David Miller writes: > > > From: Aaron Conole > > Date: Tue, 03 Jan 2017 10:50:00 -0500 > > > >>> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, > >>> struct nlmsghdr *nlh, > >>> Notifier will trigger

Re: [PATCH] Ipvlan should return an error when an address is already in use.

2017-01-04 Thread Krister Johansen
On Sun, Jan 01, 2017 at 10:26:32PM -0500, David Miller wrote: > From: Krister Johansen > Date: Fri, 30 Dec 2016 20:10:58 -0800 > > > The ipvlan code already knows how to detect when a duplicate address is > > about to be assigned to an ipvlan device. However, that failure is not > > propogated o

Re: [PATCH] Ipvlan should return an error when an address is already in use.

2017-01-03 Thread Aaron Conole
David Miller writes: > From: Aaron Conole > Date: Tue, 03 Jan 2017 10:50:00 -0500 > >>> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, >>> struct nlmsghdr *nlh, >>>Notifier will trigger FIB update, so that >>>listeners of netlink will know about new ifa

Re: [PATCH] Ipvlan should return an error when an address is already in use.

2017-01-03 Thread David Miller
From: Aaron Conole Date: Tue, 03 Jan 2017 10:50:00 -0500 >> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, >> struct nlmsghdr *nlh, >> Notifier will trigger FIB update, so that >> listeners of netlink will know about new ifaddr */ >> rtmsg_ifa(RTM_N

Re: [PATCH] Ipvlan should return an error when an address is already in use.

2017-01-03 Thread Aaron Conole
Hi Krister, Krister Johansen writes: > The ipvlan code already knows how to detect when a duplicate address is > about to be assigned to an ipvlan device. However, that failure is not > propogated outward and leads to a silent failure. This teaches the ip > address addition functions how to re

Re: [PATCH] Ipvlan should return an error when an address is already in use.

2017-01-01 Thread David Miller
From: Krister Johansen Date: Fri, 30 Dec 2016 20:10:58 -0800 > The ipvlan code already knows how to detect when a duplicate address is > about to be assigned to an ipvlan device. However, that failure is not > propogated outward and leads to a silent failure. This teaches the ip > address addit

[PATCH] Ipvlan should return an error when an address is already in use.

2016-12-30 Thread Krister Johansen
The ipvlan code already knows how to detect when a duplicate address is about to be assigned to an ipvlan device. However, that failure is not propogated outward and leads to a silent failure. This teaches the ip address addition functions how to report this error to the user applications so that