Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Florian Fainelli
On 12/7/18 9:26 AM, Andrew Lunn wrote: >> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs? > > I think it makes sense to allow a fixed phy carrier to be changed from > user space. However, i don't think you can easily plumb that to > .ndo_change_carrier(), since that is a

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Andrew Lunn
> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs? I think it makes sense to allow a fixed phy carrier to be changed from user space. However, i don't think you can easily plumb that to .ndo_change_carrier(), since that is a MAC feature. You need to change the

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Joakim Tjernlund
On Fri, 2018-12-07 at 15:15 +0100, Andrew Lunn wrote: > > > > Been a bit busy today but now I have played with dormant using ip link and > > got some odd results: > > # > ifconfig eth0 > > eth0: flags=4163 mtu 1500 > > inet 172.20.0.246 netmask 255.255.0.0 broadcast 172.20.255.255 >

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Andrew Lunn
> Been a bit busy today but now I have played with dormant using ip link and > got some odd results: > # > ifconfig eth0 > eth0: flags=4163 mtu 1500 > inet 172.20.0.246 netmask 255.255.0.0 broadcast 172.20.255.255 > inet6 fe80::ad9c:b230:1da8:1821 prefixlen 64 scopeid 0x20 >

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Joakim Tjernlund
On Thu, 2018-12-06 at 20:43 +0100, Andrew Lunn wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > I can have a look at using dormant, but what is

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Andrew Lunn
> I can have a look at using dormant, but what is change_carrier > supposed to do if not this? It is intended for interfaces which are stacked, like the team driver, and for devices which don't have a phy, e.g. tun, and dummy. > I didn't find a tool for DORMANT, I guess i will have to write one

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Joakim Tjernlund
On Thu, 2018-12-06 at 17:54 +0100, Andrew Lunn wrote: > > > I wish I had a proper DSA/Switchdev driver in place but I don't :( > > Adding one is not impossible but then a lot of our user space app needs > > fixing so all > > in all it it a fairly big project. > > Anyhow, these carrier additions

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Andrew Lunn
> I wish I had a proper DSA/Switchdev driver in place but I don't :( > Adding one is not impossible but then a lot of our user space app needs > fixing so all > in all it it a fairly big project. > Anyhow, these carrier additions should be fine I think? I'm not too sure about that. You are

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Joakim Tjernlund
On Thu, 2018-12-06 at 17:21 +0100, Andrew Lunn wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > > Hi Joakim > > > > > > Please could you explain the use

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Andrew Lunn
> > Hi Joakim > > > > Please could you explain the use case for this. > > I have an eth I/F connected to an internal (on board) switch which has an > external port to a mgmt network. > Whenever the external link is broken I want inform linux IP stack that the > link is down on the internal eth

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Joakim Tjernlund
On Thu, 2018-12-06 at 16:47 +0100, Andrew Lunn wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Thu, Dec 06, 2018 at 04:31:25PM +0100, Joakim Tjernlund

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Andrew Lunn
On Thu, Dec 06, 2018 at 04:31:25PM +0100, Joakim Tjernlund wrote: > This allows to control carrier from /sys/class/net/ethX/carrier Hi Joakim Please could you explain the use case for this. Andrew

[PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Joakim Tjernlund
This allows to control carrier from /sys/class/net/ethX/carrier Signed-off-by: Joakim Tjernlund --- drivers/net/ethernet/freescale/gianfar.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c