Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-15 Thread Auke Kok
Brandeburg, Jesse wrote: On Sat, 12 Aug 2006, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Since the e1000 change is non-trivial I'm not going to bypass the driver author on it, sorry. What I did do was put the netdev_alloc_skb() change into my tree, and since

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-14 Thread Brandeburg, Jesse
On Sat, 12 Aug 2006, Christoph Hellwig wrote: > > >> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> > > > > > >Since the e1000 change is non-trivial I'm not going to bypass > > >the driver author on it, sorry. > > > > > >What I did do was put the netdev_alloc_skb() change into my > > >tree, a

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-12 Thread Christoph Hellwig
On Mon, Aug 07, 2006 at 05:29:54PM -0700, Jesse Brandeburg wrote: > On 8/7/06, David Miller <[EMAIL PROTECTED]> wrote: > >From: Christoph Hellwig <[EMAIL PROTECTED]> > >Date: Sat, 5 Aug 2006 15:01:09 +0200 > > > >> All caller of netdev_alloc_skb need to assign skb->dev shortly > >> afterwards. Mov

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-07 Thread Jesse Brandeburg
On 8/7/06, David Miller <[EMAIL PROTECTED]> wrote: From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 15:01:09 +0200 > All caller of netdev_alloc_skb need to assign skb->dev shortly > afterwards. Move it into common code. > > I also had to fixup a little bit of the surrounding co

Re: [PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-07 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 15:01:09 +0200 > All caller of netdev_alloc_skb need to assign skb->dev shortly > afterwards. Move it into common code. > > I also had to fixup a little bit of the surrounding control flow in > e1000 - it was just too convoluted.

[PATCH] move skb->dev assignment into netdev_alloc_skb

2006-08-05 Thread Christoph Hellwig
All caller of netdev_alloc_skb need to assign skb->dev shortly afterwards. Move it into common code. I also had to fixup a little bit of the surrounding control flow in e1000 - it was just too convoluted. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/e1000/e