Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-04-15 Thread Kalle Valo
Eliad Peller writes: > On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches wrote: >> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >>> Joe Perches writes: >>> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >>> > > Joe Perches

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-03-31 Thread Eliad Peller
On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches wrote: > On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >> Joe Perches writes: >> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> > > Joe Perches writes: >> > > > >> > > > Using

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-03-31 Thread Joe Perches
On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: > Joe Perches writes: > > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > > > Joe Perches writes: > > > > > > > > Using the normal kernel logging mechanisms makes this code > > > > a bit more like

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-03-31 Thread Kalle Valo
Joe Perches writes: > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> Joe Perches writes: >> > Using the normal kernel logging mechanisms makes this code >> > a bit more like other wireless drivers. >> Personally I don't see the point but I don't have

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-03-30 Thread Joe Perches
On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > Joe Perches writes: > > Using the normal kernel logging mechanisms makes this code > > a bit more like other wireless drivers. > Personally I don't see the point but I don't have any strong opinions. A > bigger problem is

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-03-30 Thread Kalle Valo
Joe Perches writes: > Using the normal kernel logging mechanisms makes this code > a bit more like other wireless drivers. Personally I don't see the point but I don't have any strong opinions. A bigger problem is that TI drivers are not really in active development and that's

[PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

2016-03-07 Thread Joe Perches
Using the normal kernel logging mechanisms makes this code a bit more like other wireless drivers. Joe Perches (5): ti: Convert wl1271_ logging macros to dev_ or pr_ ti: wl1251: Convert wl1251_error to wiphy_err/pr_err ti: wl1251: Convert wl1251_warning to wiphy_warn ti: wl1251: Convert