On Wed, 2006-04-05 at 10:32 -0700, Stephen Hemminger wrote:
> On Wed, 05 Apr 2006 10:31:14 -0700
> Sanjeev Jorapur <[EMAIL PROTECTED]> wrote:
>
> > On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> > > On Wed, 05 Apr 2006 09:38:24 -0700
> > > "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrot
On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> On Wed, 05 Apr 2006 09:38:24 -0700
> "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote:
>
> > On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote:
> >
> > > We would like this driver to be inluded in mainline kernel.
>
On Wed, 05 Apr 2006 10:31:14 -0700
Sanjeev Jorapur <[EMAIL PROTECTED]> wrote:
> On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> > On Wed, 05 Apr 2006 09:38:24 -0700
> > "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote:
> >
> > > On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit
On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> Or for a new driver, just make it one big piece and put it at a
> website for download and include linke.
Funny, I'd have thought that was a guaranteed way to get it ignored.
http://vger.kernel.org/majordomo-info.html
On Wed, 05 Apr 2006 09:38:24 -0700
"Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote:
> On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote:
>
> > We would like this driver to be inluded in mainline kernel.
> > Kindly review it and feel free to get back to me for any
> > feedback
On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote:
> We would like this driver to be inluded in mainline kernel.
> Kindly review it and feel free to get back to me for any
> feedback/queries/comments.
Based on some light reading and my own recent experience, I'd estimate
On Sat, 2006-04-01 at 05:17 -0800, Linsys Contractor Amit S. Kale wrote:
> +unsigned long
> +decode_crb_addr (unsigned long addr)
> +{
Missing a nexgen_ prefix.
> +int
> +wait_rom_done (netxen_adapter *adapter)
Ditto.
> +int
> +rom_fast_read (netxen_adapter *adapter, int addr)
And again. I'm
> diff -Naru linux-2.6.16_orig/drivers/net/netxen/Makefile
> linux-2.6.16/drivers/net/netxen/Makefile
> --- linux-2.6.16_orig/drivers/net/netxen/Makefile 1969-12-31
> 16:00:00.0 -0800
> +++ linux-2.6.16/drivers/net/netxen/Makefile 2006-03-24 14:25:53.0
> -0800
> @@ -0,0 +1,
On Monday 03 Apr 2006 3:18 am, Roland Dreier wrote:
> - Please try to use software to post your patches so that they end up
>nicely threaded via In-Reply-To: headers. And also try to plan
>ahead enough so that you don't end up things like "[PATCH 1.2/9]".
>Finally, please try to give
Just a couple of very general comments:
- The kernel style is to avoid "//" comments like
> +//reset abyte_cnt and dummy_byte_cnt
please replace all of this with comments like
/* single-line comment */
or
/*
* multi-line comments
* look like t
diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c
linux-2.6.16/drivers/net/netxen/netxen_nic_init.c
--- linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c 1969-12-31
16:00:00.0 -0800
+++ linux-2.6.16/drivers/net/netxen/netxen_nic_init.c 2006-03-24
14:13:57.
Hi,
I'll be sending a NetXen (formerly Universal Network Machines) 1G/10G in
subsequent emails. This is a revised version of the UNM driver posted
earlier. We would like this driver to be inluded in mainline kernel.
Kindly review it and feel free to get back to me for any
feedback/queries/comm
12 matches
Mail list logo
