Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-25 Thread Cong Wang
On Fri, May 25, 2018 at 1:39 PM, Vlad Buslov wrote: > > On Thu 24 May 2018 at 23:34, Cong Wang wrote: >> On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote: >>> Currently, all netlink protocol handlers for updating rules,

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-25 Thread Vlad Buslov
On Thu 24 May 2018 at 23:34, Cong Wang wrote: > On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote: >> Currently, all netlink protocol handlers for updating rules, actions and >> qdiscs are protected with single global rtnl lock which removes any

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-24 Thread Cong Wang
On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote: > Currently, all netlink protocol handlers for updating rules, actions and > qdiscs are protected with single global rtnl lock which removes any > possibility for parallelism. This patch set is a first step to remove > rtnl

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-18 Thread Vlad Buslov
On Fri 18 May 2018 at 12:33, Jamal Hadi Salim wrote: > On 17/05/18 09:35 AM, Vlad Buslov wrote: >> >> On Wed 16 May 2018 at 21:51, Jiri Pirko wrote: >>> Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: > > Please make sure you have

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-18 Thread Jamal Hadi Salim
On 17/05/18 09:35 AM, Vlad Buslov wrote: On Wed 16 May 2018 at 21:51, Jiri Pirko wrote: Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: Please make sure you have these in your kernel config: CONFIG_NET_ACT_IFE=y CONFIG_NET_IFE_SKBMARK=m

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-17 Thread Vlad Buslov
On Wed 16 May 2018 at 21:51, Jiri Pirko wrote: > Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: >> >>On Wed 16 May 2018 at 17:36, Roman Mashak wrote: >>> Vlad Buslov writes: >>> On Wed 16 May 2018 at 14:38, Roman

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Jiri Pirko
Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: > >On Wed 16 May 2018 at 17:36, Roman Mashak wrote: >> Vlad Buslov writes: >> >>> On Wed 16 May 2018 at 14:38, Roman Mashak wrote: On Wed, May 16, 2018 at 2:43 AM,

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 18:10, Davide Caratti wrote: > On Wed, 2018-05-16 at 13:36 -0400, Roman Mashak wrote: >> Vlad Buslov writes: >> >> > On Wed 16 May 2018 at 14:38, Roman Mashak wrote: >> > > On Wed, May 16, 2018 at 2:43 AM, Vlad

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 17:36, Roman Mashak wrote: > Vlad Buslov writes: > >> On Wed 16 May 2018 at 14:38, Roman Mashak wrote: >>> On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: I'm trying to run tdc,

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Davide Caratti
On Wed, 2018-05-16 at 13:36 -0400, Roman Mashak wrote: > Vlad Buslov writes: > > > On Wed 16 May 2018 at 14:38, Roman Mashak wrote: > > > On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: > > > > > > > > I'm trying to run tdc, but

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Roman Mashak
Vlad Buslov writes: > On Wed 16 May 2018 at 14:38, Roman Mashak wrote: >> On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: >>> I'm trying to run tdc, but keep getting following error even on clean >>> branch without my

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 15:02, Jamal Hadi Salim wrote: > On 16/05/18 10:38 AM, Roman Mashak wrote: > You may actually have broken something with your patches in this case. >>> >>> Results is for net-next without my patches. >> >> Do you have skbmod compiled in kernel

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Wed 16 May 2018 at 14:38, Roman Mashak wrote: > On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: >> I'm trying to run tdc, but keep getting following error even on clean >> branch without my patches: > > Vlad, not sure if you saw my

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Jamal Hadi Salim
On 16/05/18 10:38 AM, Roman Mashak wrote: You may actually have broken something with your patches in this case. Results is for net-next without my patches. Do you have skbmod compiled in kernel or as a module? Also - suggestion is to use latest iproute2 which interprets extended error

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Roman Mashak
On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov wrote: > I'm trying to run tdc, but keep getting following error even on clean > branch without my patches: Vlad, not sure if you saw my email: Apply Roman's patch and try again

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Tue 15 May 2018 at 22:07, Lucas Bates wrote: > On Tue, May 15, 2018 at 6:03 PM, Lucas Bates wrote: >> On Tue, May 15, 2018 at 5:49 PM, Jamal Hadi Salim wrote: Test 7d50: Add skbmod action to set destination mac exit: 255

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-16 Thread Vlad Buslov
On Tue 15 May 2018 at 21:49, Jamal Hadi Salim wrote: > On 15/05/18 05:21 PM, Vlad Buslov wrote: >> >> On Tue 15 May 2018 at 18:25, Jamal Hadi Salim wrote: >>> On 14/05/18 04:46 PM, Vlad Buslov wrote: On Mon 14 May 2018 at 18:03, Jamal Hadi Salim

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Lucas Bates
On Tue, May 15, 2018 at 6:03 PM, Lucas Bates wrote: > On Tue, May 15, 2018 at 5:49 PM, Jamal Hadi Salim wrote: >>> Test 7d50: Add skbmod action to set destination mac >>> exit: 255 0 >>> dst MAC address <11:22:33:44:55:66> >>> RTNETLINK answers: No such

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Lucas Bates
On Tue, May 15, 2018 at 5:49 PM, Jamal Hadi Salim wrote: >> Test 7d50: Add skbmod action to set destination mac >> exit: 255 0 >> dst MAC address <11:22:33:44:55:66> >> RTNETLINK answers: No such file or directory >> We have an error talking to the kernel >> > > You may

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Jamal Hadi Salim
On 15/05/18 05:21 PM, Vlad Buslov wrote: On Tue 15 May 2018 at 18:25, Jamal Hadi Salim wrote: On 14/05/18 04:46 PM, Vlad Buslov wrote: On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote: On 14/05/18 10:27 AM, Vlad Buslov wrote: Hello Jamal, I'm

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Vlad Buslov
On Tue 15 May 2018 at 18:25, Jamal Hadi Salim wrote: > On 14/05/18 04:46 PM, Vlad Buslov wrote: >> >> On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote: >>> On 14/05/18 10:27 AM, Vlad Buslov wrote: > > >> Hello Jamal, >> >> I'm trying to run tdc, but

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Jamal Hadi Salim
On 14/05/18 04:46 PM, Vlad Buslov wrote: On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote: On 14/05/18 10:27 AM, Vlad Buslov wrote: Hello Jamal, I'm trying to run tdc, but keep getting following error even on clean branch without my patches: Vlad, not sure if you

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-15 Thread Jiri Pirko
Mon, May 14, 2018 at 08:03:20PM CEST, j...@mojatatu.com wrote: >On 14/05/18 10:27 AM, Vlad Buslov wrote: >> Currently, all netlink protocol handlers for updating rules, actions and >> qdiscs are protected with single global rtnl lock which removes any >> possibility for parallelism. This patch set

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Vlad Buslov
On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote: > On 14/05/18 10:27 AM, Vlad Buslov wrote: >> Currently, all netlink protocol handlers for updating rules, actions and >> qdiscs are protected with single global rtnl lock which removes any >> possibility for parallelism.

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Jamal Hadi Salim
On 14/05/18 10:27 AM, Vlad Buslov wrote: Currently, all netlink protocol handlers for updating rules, actions and qdiscs are protected with single global rtnl lock which removes any possibility for parallelism. This patch set is a first step to remove rtnl lock dependency from TC rules update

[PATCH 00/14] Modify action API for implementing lockless actions

2018-05-14 Thread Vlad Buslov
Currently, all netlink protocol handlers for updating rules, actions and qdiscs are protected with single global rtnl lock which removes any possibility for parallelism. This patch set is a first step to remove rtnl lock dependency from TC rules update path. It updates act API to use atomic