Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Jakub Kicinski
Hi Jacob! First of all thanks for putting your time into sorting this out, figuring out what to do with user-set RSS table when queues are reconfigured was a head scratcher for me as well. On Fri, 5 Feb 2016 12:30:21 -0800, Jacob Keller wrote: > +#define FM10K_FLAG_RETA_TABLE_CONFIGURED

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 13:26 +, Jakub Kicinski wrote: > Hi Jacob! > > First of all thanks for putting your time into sorting this out, > figuring out what to do with user-set RSS table when queues are > reconfigured was a head scratcher for me as well. > Yep! > On Fri,  5 Feb 2016 12:30:21

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Jakub Kiciński
On Mon, 8 Feb 2016 17:13:15 +, Keller, Jacob E wrote: > On Mon, 2016-02-08 at 13:26 +, Jakub Kicinski wrote: > > On Fri,  5 Feb 2016 12:30:21 -0800, Jacob Keller wrote: > > > +#define FM10K_FLAG_RETA_TABLE_CONFIGURED (u32)(BIT(6)) > > > > If we go with your proposal every driver will have

Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-08 Thread Keller, Jacob E
On Mon, 2016-02-08 at 19:23 +, Jakub Kiciński wrote: > On Mon, 8 Feb 2016 17:13:15 +, Keller, Jacob E wrote: > > Maybe we can store it as a flag in the netdev structure instead? > > Either flag in the netdev or keep your reset callback.  Neither seems > spectacularly clean.  Maybe someone

[PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-05 Thread Jacob Keller
Previously, the fm10k driver would incorrectly allow changing the number of combined channels when this would have altered user configured RSS indirection table. With the new ethtool operation .reset_rxfh_indir, we are now able to correctly handle the changes to number of channels. This requires