Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-02 Thread Jiri Benc
On Tue, 2 Oct 2018 09:11:17 -0600, David Ahern wrote: > Generically speaking a filter modifies the output based on the input. > Specifying a target namespace is an input to the dump that modifies the > output. That's conventionally called "algorithm" :-) Let's just say we have a different underst

Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-02 Thread David Ahern
On 10/2/18 4:54 AM, Jiri Benc wrote: > On Mon, 1 Oct 2018 17:28:28 -0700, David Ahern wrote: >> Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid >> into it. Since IFA_TARGET_NETNSID is a kernel side filter add the >> NLM_F_DUMP_FILTERED flag so userspace knows the request was hon

Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-02 Thread Christian Brauner
On Tue, Oct 02, 2018 at 01:07:49PM +0200, Jiri Benc wrote: > On Tue, 2 Oct 2018 13:03:00 +0200, Christian Brauner wrote: > > Well, it's a namespace filter that's how I saw it. > > That would imply that without it, you get data from all name spaces > (= unfiltered by name space), which is not what'

Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-02 Thread Jiri Benc
On Tue, 2 Oct 2018 13:03:00 +0200, Christian Brauner wrote: > Well, it's a namespace filter that's how I saw it. That would imply that without it, you get data from all name spaces (= unfiltered by name space), which is not what's happening :-) Jiri

Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-02 Thread Christian Brauner
On Tue, Oct 02, 2018 at 12:54:25PM +0200, Jiri Benc wrote: > On Mon, 1 Oct 2018 17:28:28 -0700, David Ahern wrote: > > Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid > > into it. Since IFA_TARGET_NETNSID is a kernel side filter add the > > NLM_F_DUMP_FILTERED flag so userspace

Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-02 Thread Jiri Benc
On Mon, 1 Oct 2018 17:28:28 -0700, David Ahern wrote: > Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid > into it. Since IFA_TARGET_NETNSID is a kernel side filter add the > NLM_F_DUMP_FILTERED flag so userspace knows the request was honored. IFA_TARGET_NETNSID is not a filter.

[PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-01 Thread David Ahern
From: David Ahern Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid into it. Since IFA_TARGET_NETNSID is a kernel side filter add the NLM_F_DUMP_FILTERED flag so userspace knows the request was honored. Signed-off-by: David Ahern Acked-by: Christian Brauner --- net/ipv6/addrc