Re: [PATCH net] ipv4: add support for "gratuitous" redirect

2015-09-30 Thread Paolo Abeni
On Tue, 2015-09-29 at 11:49 -0700, David Miller wrote: > I don't know if it's a question of terminology but RFC1122 does > seem to ask us to make this check, from 3.2.2.2: > > A Redirect message SHOULD be silently discarded if ... the > source of the Redirect is not the current fi

Re: [PATCH net] ipv4: add support for "gratuitous" redirect

2015-09-29 Thread David Miller
From: Paolo Abeni Date: Fri, 25 Sep 2015 15:16:58 +0200 > Such hosts are going to silently discard the ICMP redirect > messages generated by the VRRP router since the message's source > IP will differ from the redirected route's gateway. > > RFC1122 don't imposes the above check, so this patch m

[PATCH net] ipv4: add support for "gratuitous" redirect

2015-09-25 Thread Paolo Abeni
The ICMP redirect messages are generated using the selected interface's primary address as source. On VRRP routers said IP may differ from the VRRP IP used as the default gatetway from the LAN hosts. Such hosts are going to silently discard the ICMP redirect messages generated by the VRRP router s