Re: [PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly

2016-08-31 Thread Gao Feng
On Wed, Aug 31, 2016 at 12:16 PM, Gao Feng wrote: > On Wed, Aug 31, 2016 at 12:14 PM, Eric Dumazet wrote: >> On Wed, 2016-08-31 at 10:56 +0800, f...@ikuai8.com wrote: >>> From: Gao Feng >>> >>> The original codes depend on that the

Re: [PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly

2016-08-30 Thread Gao Feng
On Wed, Aug 31, 2016 at 12:14 PM, Eric Dumazet wrote: > On Wed, 2016-08-31 at 10:56 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> The original codes depend on that the function parameters are evaluated from >> left to right. But the parameter's

Re: [PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly

2016-08-30 Thread Eric Dumazet
On Wed, 2016-08-31 at 10:56 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The original codes depend on that the function parameters are evaluated from > left to right. But the parameter's evaluation order is not defined in C > standard actually. > > When

[PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly

2016-08-30 Thread fgao
From: Gao Feng The original codes depend on that the function parameters are evaluated from left to right. But the parameter's evaluation order is not defined in C standard actually. When flow_keys_have_l4() is invoked before ___skb_get_hash(skb, , hashrnd) with some compilers