[PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-15 Thread Rahul Lakkireddy
Register callback to panic_notifier_list. Invoke dump collect routine to append dump to vmcore. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 5 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 93 +

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-16 Thread David Miller
From: Rahul Lakkireddy Date: Thu, 15 Feb 2018 19:24:42 +0530 > Register callback to panic_notifier_list. Invoke dump collect routine > to append dump to vmcore. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar There is absolutely no precedence for a networking driver dumpin

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-19 Thread Rahul Lakkireddy
On Saturday, February 02/17/18, 2018 at 02:11:01 +0530, David Miller wrote: > From: Rahul Lakkireddy > Date: Thu, 15 Feb 2018 19:24:42 +0530 > > > Register callback to panic_notifier_list. Invoke dump collect routine > > to append dump to vmcore. > > > > Signed-off-by: Rahul Lakkireddy > > Sig

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-19 Thread David Miller
From: Rahul Lakkireddy Date: Mon, 19 Feb 2018 18:04:17 +0530 > Panic notifier seemed to meet our requirement, as we are able to > collect dump during kernel panic and then extract it from vmcore. Who else does this? I do not think the panic notifier was created to serve this purpose.

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-20 Thread Jakub Kicinski
On Mon, 19 Feb 2018 18:04:17 +0530, Rahul Lakkireddy wrote: > Our requirement is to analyze the state of firmware/hardware at the > time of kernel panic. I was wondering about this since you posted the patch and I can't come up with any specific scenario where kernel crash would correlate clearly

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-20 Thread Florian Fainelli
On 02/20/2018 04:43 PM, Jakub Kicinski wrote: > On Mon, 19 Feb 2018 18:04:17 +0530, Rahul Lakkireddy wrote: >> Our requirement is to analyze the state of firmware/hardware at the >> time of kernel panic. > > I was wondering about this since you posted the patch and I can't come > up with any spec

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-20 Thread Jakub Kicinski
On Tue, 20 Feb 2018 16:51:03 -0800, Florian Fainelli wrote: > On 02/20/2018 04:43 PM, Jakub Kicinski wrote: > > On Mon, 19 Feb 2018 18:04:17 +0530, Rahul Lakkireddy wrote: > >> Our requirement is to analyze the state of firmware/hardware at the > >> time of kernel panic. > > > > I was wonderi

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-21 Thread Rahul Lakkireddy
On Tuesday, February 02/20/18, 2018 at 17:04:20 -0800, Jakub Kicinski wrote: > On Tue, 20 Feb 2018 16:51:03 -0800, Florian Fainelli wrote: > > On 02/20/2018 04:43 PM, Jakub Kicinski wrote: > > > On Mon, 19 Feb 2018 18:04:17 +0530, Rahul Lakkireddy wrote: > > >> Our requirement is to analyze the s