[PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-11 Thread Vladimir Oltean
Currently the bridge untags VLANs from its VLAN group in __allowed_ingress() only when VLAN filtering is enabled. When installing a pvid in egress-tagged mode, DSA switches have a problem: ip link add dev br0 type bridge vlan_filtering 0 ip link set swp0 master br0 bridge vlan del dev swp0 vid 1

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-11 Thread Nikolay Aleksandrov
On Sat, 2020-09-12 at 02:16 +0300, Vladimir Oltean wrote: > Currently the bridge untags VLANs from its VLAN group in > __allowed_ingress() only when VLAN filtering is enabled. > > When installing a pvid in egress-tagged mode, DSA switches have a > problem: > > ip link add dev br0 type bridge vlan

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-12 Thread Vladimir Oltean
On Sat, Sep 12, 2020 at 06:56:12AM +, Nikolay Aleksandrov wrote: > Could you point me to a thread where these problems were discussed and why > they couldn't be resolved within DSA in detail ? See my discussion with Florian in this thread: http://patchwork.ozlabs.org/project/netdev/patch/20200

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-12 Thread Nikolay Aleksandrov
On Sat, 2020-09-12 at 10:23 +0300, Vladimir Oltean wrote: > On Sat, Sep 12, 2020 at 06:56:12AM +, Nikolay Aleksandrov wrote: > > Could you point me to a thread where these problems were discussed and why > > they couldn't be resolved within DSA in detail ? > > See my discussion with Florian in

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-12 Thread Vladimir Oltean
On Sat, Sep 12, 2020 at 07:37:42AM +, Nikolay Aleksandrov wrote: > On Sat, 2020-09-12 at 10:23 +0300, Vladimir Oltean wrote: > > On Sat, Sep 12, 2020 at 06:56:12AM +, Nikolay Aleksandrov wrote: > > > Could you point me to a thread where these problems were discussed and why > > > they could

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-12 Thread Florian Fainelli
On 9/11/2020 11:56 PM, Nikolay Aleksandrov wrote: On Sat, 2020-09-12 at 02:16 +0300, Vladimir Oltean wrote: Currently the bridge untags VLANs from its VLAN group in __allowed_ingress() only when VLAN filtering is enabled. When installing a pvid in egress-tagged mode, DSA switches have a prob

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-14 Thread Nikolay Aleksandrov
On Sat, 2020-09-12 at 12:38 -0700, Florian Fainelli wrote: > > On 9/11/2020 11:56 PM, Nikolay Aleksandrov wrote: > > On Sat, 2020-09-12 at 02:16 +0300, Vladimir Oltean wrote: > > > Currently the bridge untags VLANs from its VLAN group in > > > __allowed_ingress() only when VLAN filtering is enable

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-14 Thread Florian Fainelli
On 9/14/2020 12:51 AM, Nikolay Aleksandrov wrote: On Sat, 2020-09-12 at 12:38 -0700, Florian Fainelli wrote: On 9/11/2020 11:56 PM, Nikolay Aleksandrov wrote: On Sat, 2020-09-12 at 02:16 +0300, Vladimir Oltean wrote: Currently the bridge untags VLANs from its VLAN group in __allowed_ingres

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-21 Thread Florian Fainelli
On 9/14/20 1:11 PM, Florian Fainelli wrote: >> Less important, but still: >>   - it is in the fast path for everyone >>   - it can already be fixed by a tc action/8021q device > > Sure, but the point is that it should be fixed in a way that is > transparent to the user, as much as possible. > >>

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-21 Thread Vladimir Oltean
On Mon, Sep 21, 2020 at 12:44:43PM -0700, Florian Fainelli wrote: > Vladimir, let me know if you have a patch for DSA and I can give it a > try quickly. Thanks! Let me clean it up a little and send it, I need to export a wrapper over br_get_pvid() for external use, called under rcu_read_lock().

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-21 Thread Vladimir Oltean
On Mon, Sep 21, 2020 at 10:56:07PM +0300, Vladimir Oltean wrote: > On Mon, Sep 21, 2020 at 12:44:43PM -0700, Florian Fainelli wrote: > > Vladimir, let me know if you have a patch for DSA and I can give it a > > try quickly. Thanks! > > Let me clean it up a little and send it, I need to export a wr