Re: [PATCH net-next] sched: cls: enable verbose logging

2018-05-15 Thread Jakub Kicinski
On Mon, 14 May 2018 22:31:46 -0700, Cong Wang wrote: > On Mon, May 14, 2018 at 1:47 PM, Marcelo Ricardo Leitner wrote: > > On Mon, May 14, 2018 at 01:30:53PM -0700, Cong Wang wrote: > >> On Sun, May 13, 2018 at 1:44 PM, Marcelo Ricardo Leitner wrote: > >> > Currently, when the rule is not to

Re: [PATCH net-next] sched: cls: enable verbose logging

2018-05-14 Thread Cong Wang
On Mon, May 14, 2018 at 1:47 PM, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 01:30:53PM -0700, Cong Wang wrote: >> On Sun, May 13, 2018 at 1:44 PM, Marcelo Ricardo Leitner >> wrote: >> > Currently, when the rule is not to be

Re: [PATCH net-next] sched: cls: enable verbose logging

2018-05-14 Thread Marcelo Ricardo Leitner
On Mon, May 14, 2018 at 01:30:53PM -0700, Cong Wang wrote: > On Sun, May 13, 2018 at 1:44 PM, Marcelo Ricardo Leitner > wrote: > > Currently, when the rule is not to be exclusively executed by the > > hardware, extack is not passed along and offloading failures don't >

Re: [PATCH net-next] sched: cls: enable verbose logging

2018-05-14 Thread David Miller
From: Cong Wang Date: Mon, 14 May 2018 13:30:53 -0700 > I fail to understand why you need a flag here, IOW, why not just pass > extack unconditionally? It will confuse users, so isn't passed up by default.

Re: [PATCH net-next] sched: cls: enable verbose logging

2018-05-14 Thread Cong Wang
On Sun, May 13, 2018 at 1:44 PM, Marcelo Ricardo Leitner wrote: > Currently, when the rule is not to be exclusively executed by the > hardware, extack is not passed along and offloading failures don't > get logged. The idea was that hardware failures are okay because

Re: [PATCH net-next] sched: cls: enable verbose logging

2018-05-14 Thread David Miller
From: Marcelo Ricardo Leitner Date: Sun, 13 May 2018 17:44:27 -0300 > Currently, when the rule is not to be exclusively executed by the > hardware, extack is not passed along and offloading failures don't > get logged. The idea was that hardware failures are okay

[PATCH net-next] sched: cls: enable verbose logging

2018-05-13 Thread Marcelo Ricardo Leitner
Currently, when the rule is not to be exclusively executed by the hardware, extack is not passed along and offloading failures don't get logged. The idea was that hardware failures are okay because the rule will get executed in software then and this way it doesn't confuse unware users. But this