Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Andrew Lunn
On Tue, Sep 04, 2018 at 04:55:26PM -0700, Florian Fainelli wrote: > On 09/04/2018 04:32 PM, Andrew Lunn wrote: > > > > > >> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, > >> + unsigned long *supported, > >> + struct phylin

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Florian Fainelli
On 09/04/2018 04:15 PM, Andrew Lunn wrote: > On Tue, Sep 04, 2018 at 03:11:20PM -0700, Florian Fainelli wrote: >> Add support for the Northstar Plus SerDes which is accessed through a >> special page of the switch. Since this is something that most people >> probably will not want to use, make it a

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Florian Fainelli
On 09/04/2018 04:32 PM, Andrew Lunn wrote: > > >> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, >> + unsigned long *supported, >> + struct phylink_link_state *state) >> +{ >> +u8 lane = b53_serdes_map_lane(dev, port

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Andrew Lunn
> +void b53_serdes_phylink_validate(struct b53_device *dev, int port, > + unsigned long *supported, > + struct phylink_link_state *state) > +{ > + u8 lane = b53_serdes_map_lane(dev, port); > + > + if (lane == B53_INVALID_LANE) > +

Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Andrew Lunn
On Tue, Sep 04, 2018 at 03:11:20PM -0700, Florian Fainelli wrote: > Add support for the Northstar Plus SerDes which is accessed through a > special page of the switch. Since this is something that most people > probably will not want to use, make it a configurable option. > > The SerDes supports b

[PATCH net-next 5/5] net: dsa: b53: Add SerDes support

2018-09-04 Thread Florian Fainelli
Add support for the Northstar Plus SerDes which is accessed through a special page of the switch. Since this is something that most people probably will not want to use, make it a configurable option. The SerDes supports both SGMII and 1000baseX modes, and is internally looking like a seemingly st