Yuval Mintz :
> The Qlogic Everest Driver is the backend module for the 579xx ethernet
> products by Qlogic.
>
> This module serves two main purposes:
> 1. It's responsible to contain all the common code that will be shared
> between the various drivers that would be used with said line of
>
> 500 ko of a basic something is mildly reviewable for mere mortals.
Undertood, obviously. Thanks for the time you've put into this.
> [...]
> > +/* forward */
> > +struct qed_ptt_pool;
> > +struct qed_spq;
> > +struct qed_sb_info;
> > +struct qed_sb_attn_info;
> > +struct qed_cxt_mngr;
> > +struc
Yuval Mintz :
[...]
> > > +struct qed_simd_fp_handler {
> > > + void*token;
> > > + void(*func)(void *);
> > > +};
> > Use union * ?
> The token is a cookie to be used by a func, so union isn't appropriate.
Lets' reformulate: replace 'void * token' by 'union foobar *token'.
void
> Yuval Mintz :
> [...]
> > > > +struct qed_simd_fp_handler {
> > > > + void*token;
> > > > + void(*func)(void *);
> > > > +};
> > > Use union * ?
> > The token is a cookie to be used by a func, so union isn't appropriate.
>
> Lets' reformulate: replace 'void * token' by 'union fo
