Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Cong Wang
On Tue, May 1, 2018 at 12:12 PM, Eric Dumazet wrote: > > I guess that nobody really wants to really review Cake if > it is a file with 2700 lines of code and hundreds of variables/tunables. > > Sure, we have big files in networking land, as a result of thousands of >

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote: > >> Could you comment on specifically what you believe is broken in this, >> please, so I can fix it in the same iteration? >> > > Apart from the various pskb_may_pull() this helper should not

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Eric Dumazet
On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote: > Could you comment on specifically what you believe is broken in this, > please, so I can fix it in the same iteration? > Apart from the various pskb_may_pull() this helper should not change skb layout. Ideally, the skb should be const

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote: > >> *sigh* - can do, I guess. Though I'm not sure what that is going to >> accomplish, exactly? > > > I guess that nobody really wants to really review Cake if > it is a file with 2700 lines of

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Dave Taht
On Tue, May 1, 2018 at 11:53 AM, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 04/30/2018 02:27 PM, Dave Taht wrote: >> >>> I actually have a tc - bpf based ack filter, during the development of >>> cake's ack-thinner, that I should submit one

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread David Miller
From: Eric Dumazet Date: Tue, 1 May 2018 12:12:45 -0700 > It seems you guys spent years/months on work on this stuff, so what > is the big deal about presenting your work in the best possible way > ? +1

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Eric Dumazet
On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote: > *sigh* - can do, I guess. Though I'm not sure what that is going to > accomplish, exactly? I guess that nobody really wants to really review Cake if it is a file with 2700 lines of code and hundreds of variables/tunables. Sure, we have

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 04/30/2018 02:27 PM, Dave Taht wrote: > >> I actually have a tc - bpf based ack filter, during the development of >> cake's ack-thinner, that I should submit one of these days. It >> proved to be of limited use. >> >> Probably the biggest

Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Jonathan Morton
> On 1 May, 2018, at 7:06 pm, Eric Dumazet wrote: > > You have not provided any numbers to show how useful it is to maintain this > code (probably still broken btw, considering it is changing some skb > attributes). A simple calculation shows what the maximum tolerable

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Eric Dumazet
On 04/30/2018 02:27 PM, Dave Taht wrote: > I actually have a tc - bpf based ack filter, during the development of > cake's ack-thinner, that I should submit one of these days. It > proved to be of limited use. > > Probably the biggest mistake we made is by calling this cake feature a > filter.

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-05-01 Thread Toke Høiland-Jørgensen
Cong Wang writes: > On Mon, Apr 30, 2018 at 2:27 PM, Dave Taht wrote: >> On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote: >>> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen >>> wrote:

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-30 Thread Cong Wang
On Mon, Apr 30, 2018 at 2:27 PM, Dave Taht wrote: > On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote: >> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: >>> sch_cake targets the home router use case and is intended to

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-30 Thread Dave Taht
On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote: > On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: >> sch_cake targets the home router use case and is intended to squeeze the >> most bandwidth and latency out of even the slowest ISP links

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-30 Thread Cong Wang
On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: > sch_cake targets the home router use case and is intended to squeeze the > most bandwidth and latency out of even the slowest ISP links and routers, > while presenting an API simple enough that even an ISP can

[PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-29 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth