Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

2017-03-23 Thread Pablo Neira Ayuso
On Thu, Mar 23, 2017 at 02:16:22PM -0700, David Miller wrote: > Can I get a review of these two patches from some GTP experts? I asked Jonas to resend indicating [PATCH net-next] in the subject and some minor comestic change. Apart from patches look good so Jonas, you can add this in your follow

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

2017-03-23 Thread David Miller
Can I get a review of these two patches from some GTP experts? Thanks.

[PATCH v2 1/2] gtp: rename SGSN netlink attribute

2017-03-21 Thread Jonas Bonn
This is a mostly cosmetic rename of the SGSN netlink attribute to the GTP link. The justification for this is that we will be making the module support decapsulation of "downstream" SGSN packets, in which case the netlink parameter actually refers to the upstream GGSN peer. Renaming the parameter

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

2017-03-21 Thread Pablo Neira Ayuso
On Tue, Mar 21, 2017 at 04:10:26PM +0100, Jonas Bonn wrote: > On 03/21/2017 04:07 PM, Pablo Neira Ayuso wrote: > >On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote: > >>diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h > >>index 72a04a0..c51ebb0 100644 > >>--- a/include/uapi

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

2017-03-21 Thread Jonas Bonn
On 03/21/2017 04:07 PM, Pablo Neira Ayuso wrote: On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote: diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h index 72a04a0..c51ebb0 100644 --- a/include/uapi/linux/gtp.h +++ b/include/uapi/linux/gtp.h @@ -19,7 +19,7 @@ enum gtp_att

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

2017-03-21 Thread Pablo Neira Ayuso
On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote: > diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h > index 72a04a0..c51ebb0 100644 > --- a/include/uapi/linux/gtp.h > +++ b/include/uapi/linux/gtp.h > @@ -19,7 +19,7 @@ enum gtp_attrs { > GTPA_LINK, > GTPA_VERSI