Re: [PATCH v3 0/5] netlink extended ACK reporting

2017-04-10 Thread Johannes Berg
Here's a simple iw patch that shows the error message string: --- a/iw.c +++ b/iw.c @@ -62,6 +62,10 @@ static int nl80211_init(struct nl80211_state *state) nl_socket_set_buffer_size(state->nl_sock, 8192, 8192); + /* try to set NETLINK_EXT_ACK to 1 (ignore errors) */ + err

Re: [PATCH v3 0/5] netlink extended ACK reporting

2017-04-10 Thread Johannes Berg
I thought a little bit more about the part of reporting the broken and missing attributes, and I'm not sure I'm entirely happy with that part. For reporting broken attributes, I think the pointer is really the best thing we can do - adding the attribute number in addition to that would seem to be

[PATCH v3 0/5] netlink extended ACK reporting

2017-04-08 Thread Johannes Berg
Changes since v2: * add NUM_NLMSGERR_ATTRS, NLMSGERR_ATTR_MAX * fix cookie length to 20 (sha-1 length) * move struct members for cookie to patch 3 where they should be * another cleanup suggested by David Ahern johannes