Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-10-03 Thread Jiri Pirko
Tue, Oct 03, 2017 at 08:35:54PM CEST, t...@quantonium.net wrote: >On Tue, Oct 3, 2017 at 12:46 AM, Jiri Pirko wrote: >> Fri, Sep 29, 2017 at 07:59:35PM CEST, t...@herbertland.com wrote: >>>On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: From: Tom Herbert Date: Fri, 29 Sep 2017 08

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-10-03 Thread Tom Herbert
On Tue, Oct 3, 2017 at 12:46 AM, Jiri Pirko wrote: > Fri, Sep 29, 2017 at 07:59:35PM CEST, t...@herbertland.com wrote: >>On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: >>> From: Tom Herbert >>> Date: Fri, 29 Sep 2017 08:48:55 -0700 >>> The flow_dissector interface is not a uAPI. >>>

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-10-03 Thread Jiri Pirko
Fri, Sep 29, 2017 at 07:59:35PM CEST, t...@herbertland.com wrote: >On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: >> From: Tom Herbert >> Date: Fri, 29 Sep 2017 08:48:55 -0700 >> >>> The flow_dissector interface is not a uAPI. >> >> That's not true, insofar as cls_flower.c uses the flow_di

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-29 Thread Tom Herbert
On Fri, Sep 29, 2017 at 10:59 AM, Tom Herbert wrote: > On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: >> From: Tom Herbert >> Date: Fri, 29 Sep 2017 08:48:55 -0700 >> >>> The flow_dissector interface is not a uAPI. >> >> That's not true, insofar as cls_flower.c uses the flow_dissector >>

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-29 Thread Tom Herbert
On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: > From: Tom Herbert > Date: Fri, 29 Sep 2017 08:48:55 -0700 > >> The flow_dissector interface is not a uAPI. > > That's not true, insofar as cls_flower.c uses the flow_dissector > therefore if you change the flow_dissector in certain ways then

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-29 Thread David Miller
From: Tom Herbert Date: Fri, 29 Sep 2017 08:48:55 -0700 > The flow_dissector interface is not a uAPI. That's not true, insofar as cls_flower.c uses the flow_dissector therefore if you change the flow_dissector in certain ways then cls_flower.c might have it's behavior changed and that is in fact

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-29 Thread Tom Herbert
On Fri, Sep 29, 2017 at 12:58 AM, Hannes Frederic Sowa wrote: > Tom Herbert writes: > >> This patch set adds a new offload type to perform flow dissection for >> specific protocols (either by EtherType or by IP protocol). This is >> primary useful to crack open UDP encapsulations (like VXLAN, GUE

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-29 Thread Hannes Frederic Sowa
Tom Herbert writes: > This patch set adds a new offload type to perform flow dissection for > specific protocols (either by EtherType or by IP protocol). This is > primary useful to crack open UDP encapsulations (like VXLAN, GUE) for > the purposes of parsing the encapsulated packet. > > Items in

[PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-28 Thread Tom Herbert
This patch set adds a new offload type to perform flow dissection for specific protocols (either by EtherType or by IP protocol). This is primary useful to crack open UDP encapsulations (like VXLAN, GUE) for the purposes of parsing the encapsulated packet. Items in this patch set: - Create new pro