Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-13 Thread Jassi Brar
On Wed, Dec 13, 2017 at 2:18 AM, Andrew Lunn wrote: >> > +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv) >> > +{ >> > + struct phy_device *phydev = priv->ndev->phydev; >> > + u32 value = 0; >> > + >> > + value = phydev->duplex ?

Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-13 Thread Jassi Brar
On Tue, Dec 12, 2017 at 10:54 PM, Ard Biesheuvel wrote: > On 12 December 2017 at 17:15, wrote: >> + >> +static int netsec_netdev_load_microcode(struct netsec_priv *priv) >> +{ >> + int err; >> + >> + err =

Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-12 Thread Andrew Lunn
> > +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv) > > +{ > > + struct phy_device *phydev = priv->ndev->phydev; > > + u32 value = 0; > > + > > + value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON : > > +

Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-12 Thread Andrew Lunn
> > +static int netsec_register_mdio(struct netsec_priv *priv, u32 phy_addr) > > +{ > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = devm_mdiobus_alloc(priv->dev); > > + if (!bus) > > + return -ENOMEM; > > + > > + snprintf(bus->id,

Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-12 Thread Ard Biesheuvel
Hi Jassi, On 12 December 2017 at 17:15, wrote: > From: Jassi Brar > > This driver adds support for Socionext "netsec" IP Gigabit > Ethernet + PHY IP used in the Synquacer SC2A11 SoC. > > Signed-off-by: Ard Biesheuvel

[PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

2017-12-12 Thread jassisinghbrar
From: Jassi Brar This driver adds support for Socionext "netsec" IP Gigabit Ethernet + PHY IP used in the Synquacer SC2A11 SoC. Signed-off-by: Ard Biesheuvel Signed-off-by: Jassi Brar ---