Re: [Patch net] act_mirred: fix a race condition on mirred_list

2015-10-05 Thread David Miller
From: Cong Wang Date: Thu, 1 Oct 2015 11:37:42 -0700 > After commit 1ce87720d456 ("net: sched: make cls_u32 lockless") > we began to release tc actions in a RCU callback. However, > mirred action relies on RTNL lock to protect the global > mirred_list, therefore we could have a race condition >

Re: [Patch net] act_mirred: fix a race condition on mirred_list

2015-10-05 Thread Jamal Hadi Salim
Never mind. Mirred is speacial because it points to other netdevs. So: Acked-by: Jamal Hadi Salim Thanks Cong. cheers, jamal On 10/05/15 07:58, Jamal Hadi Salim wrote: Hi Cong, I am wondering if making the bindcount or refcount atomic would help? How does this bug get created? i.e the RTNL

Re: [Patch net] act_mirred: fix a race condition on mirred_list

2015-10-05 Thread Jamal Hadi Salim
Hi Cong, I am wondering if making the bindcount or refcount atomic would help? How does this bug get created? i.e the RTNL is still around. Why is this specific to mirred only? cheers, jamal On 10/01/15 14:37, Cong Wang wrote: After commit 1ce87720d456 ("net: sched: make cls_u32 lockless") we

[Patch net] act_mirred: fix a race condition on mirred_list

2015-10-01 Thread Cong Wang
After commit 1ce87720d456 ("net: sched: make cls_u32 lockless") we began to release tc actions in a RCU callback. However, mirred action relies on RTNL lock to protect the global mirred_list, therefore we could have a race condition between RCU callback and netdevice event, which caused a list corr