Re: [Patch net-next] ipv4: get rid of ip_ra_lock

2017-04-28 Thread Cong Wang
On Thu, Apr 27, 2017 at 4:54 PM, Eric Dumazet wrote: > On Thu, 2017-04-27 at 16:46 -0700, Cong Wang wrote: >> On Thu, Apr 27, 2017 at 5:46 AM, Eric Dumazet wrote: >> > On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote: >> >> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") >>

Re: [Patch net-next] ipv4: get rid of ip_ra_lock

2017-04-27 Thread Eric Dumazet
On Thu, 2017-04-27 at 16:46 -0700, Cong Wang wrote: > On Thu, Apr 27, 2017 at 5:46 AM, Eric Dumazet wrote: > > On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote: > >> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") > >> we always take RTNL lock for ip_ra_control() which is the

Re: [Patch net-next] ipv4: get rid of ip_ra_lock

2017-04-27 Thread Cong Wang
On Thu, Apr 27, 2017 at 5:46 AM, Eric Dumazet wrote: > On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote: >> After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") >> we always take RTNL lock for ip_ra_control() which is the only place >> we update the list ip_ra_chain, so the ip_ra_

Re: [Patch net-next] ipv4: get rid of ip_ra_lock

2017-04-27 Thread Eric Dumazet
On Wed, 2017-04-26 at 13:55 -0700, Cong Wang wrote: > After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") > we always take RTNL lock for ip_ra_control() which is the only place > we update the list ip_ra_chain, so the ip_ra_lock is no longer needed, > we just need to disable BH ther

[Patch net-next] ipv4: get rid of ip_ra_lock

2017-04-26 Thread Cong Wang
After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") we always take RTNL lock for ip_ra_control() which is the only place we update the list ip_ra_chain, so the ip_ra_lock is no longer needed, we just need to disable BH there. Signed-off-by: Cong Wang --- net/ipv4/ip_sockglue.c |