[RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jiri Benc
PRISM2_PARAM_ADM_STATUS is not used anywhere in kernel nor in userspace. It just passes a value to the driver, so it's safe to remove it. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> Index: dscape/net/d80211/hostapd_ioctl.h === --- d

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 04:44:27PM +0100, Jiri Benc wrote: > PRISM2_PARAM_ADM_STATUS is not used anywhere in kernel nor in userspace. > It just passes a value to the driver, so it's safe to remove it. This is used to implement radio on/off without having to change other parts of the configuration

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jiri Benc
On Mon, 6 Mar 2006 10:39:10 -0800, Jouni Malinen wrote: > This is used to implement radio on/off without having to change other > parts of the configuration (e.g., set interfaces down). I would rather > not remove it unless there is an alternative way of doing this. The problem with this flag is t

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 07:58:03PM +0100, Jiri Benc wrote: > The problem with this flag is that it is set from > ieee80211_init_client() function, which is removed in next patch and it > isn't clear when it should be set to 1. By trying to figure this out, I > realized that it is completely unused

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jiri Benc
On Mon, 6 Mar 2006 11:00:11 -0800, Jouni Malinen wrote: > I agree completely with renaming it. I did not implement that part and > haven't really ever liked the name.. ;-) Both of the proposed > alternatives sound acceptable. Ok. > Radio was enabled for station modes automatically to make it easi

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
Jouni Malinen wrote : > > On Mon, Mar 06, 2006 at 04:44:27PM +0100, Jiri Benc wrote: > > > PRISM2_PARAM_ADM_STATUS is not used anywhere in kernel nor in userspace. > > It just passes a value to the driver, so it's safe to remove it. > > This is used to implement radio on/off without having to ch

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: > Jouni Malinen wrote : > > This is used to implement radio on/off without having to change other > > parts of the configuration (e.g., set interfaces down). > The airo driver use 'txpower' for that. txpower has a 'off' > optio

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
On Mon, Mar 06, 2006 at 03:23:04PM -0800, Jouni Malinen wrote: > On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: > > Jouni Malinen wrote : > > > This is used to implement radio on/off without having to change other > > > parts of the configuration (e.g., set interfaces down). > >

RE: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-07 Thread Simon Barber
Jouni Malinen Sent: Monday, March 06, 2006 4:23 PM To: Jean Tourrilhes Cc: netdev@vger.kernel.org; Jiri Benc Subject: Re: [RFC/PATCH 7/13] d80211: remove adm_status On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: > Jouni Malinen wrote : > > This is used to implement radio

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-08 Thread Jean Tourrilhes
On Tue, Mar 07, 2006 at 07:11:27PM -0800, Simon Barber wrote: > Overloading configuration parameters with extra meanings like this makes > it harder to configure the system - I think it's useful to keep an > on/off function separate from the power setting. > > Simon The main issue I have