Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-05 Thread Stephen Hemminger
I hope soon to add suspend/resume to the network device class and remove driver specific suspend/resume from lots of devices. The class suspend routine would just be: pci_save_state dev-stop resume is pci_restore_state dev-open for many devices that is all they

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-05 Thread Rafael J. Wysocki
On Tuesday, 5 June 2007 07:56, Stephen Hemminger wrote: I hope soon to add suspend/resume to the network device class and remove driver specific suspend/resume from lots of devices. The class suspend routine would just be: pci_save_state dev-stop resume is

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Pavel Machek
Hi! From: Rafael J. Wysocki [EMAIL PROTECTED] Add suspend/resume support to the uli526x network driver (tested on x86_64, with 'Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40'). Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] Looks ok to me. +#ifdef

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Rafael J. Wysocki
Hi, On Monday, 4 June 2007 13:11, Pavel Machek wrote: Hi! From: Rafael J. Wysocki [EMAIL PROTECTED] Add suspend/resume support to the uli526x network driver (tested on x86_64, with 'Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40'). Signed-off-by: Rafael

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Nigel Cunningham
Hi. On Mon, 2007-06-04 at 15:49 +0200, Rafael J. Wysocki wrote: On Monday, 4 June 2007 13:11, Pavel Machek wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] Add suspend/resume support to the uli526x network driver (tested on x86_64, with 'Ethernet controller: ALi Corporation

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Rafael J. Wysocki
Hi, On Monday, 4 June 2007 23:16, Nigel Cunningham wrote: Hi. On Mon, 2007-06-04 at 15:49 +0200, Rafael J. Wysocki wrote: On Monday, 4 June 2007 13:11, Pavel Machek wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] Add suspend/resume support to the uli526x network driver (tested

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Pavel Machek
Hi! +#endif /* CONFIG_PM */ @@ -1689,6 +1775,10 @@ static struct pci_driver uli526x_driver .id_table = uli526x_pci_tbl, .probe = uli526x_init_one, .remove = __devexit_p(uli526x_remove_one), +#ifdef CONFIG_PM +

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Nigel Cunningham
Hi. On Tue, 2007-06-05 at 00:41 +0200, Pavel Machek wrote: Hi! +#endif /* CONFIG_PM */ @@ -1689,6 +1775,10 @@ static struct pci_driver uli526x_driver .id_table = uli526x_pci_tbl, .probe = uli526x_init_one, .remove =

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Valerie Henson
On Sun, Jun 03, 2007 at 12:37:35PM +0200, Rafael J. Wysocki wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] Add suspend/resume support to the uli526x network driver (tested on x86_64, with 'Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40'). Signed-off-by: Rafael

[RFC][PATCH] Add suspend and resume support to uli526x

2007-06-03 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] Add suspend/resume support to the uli526x network driver (tested on x86_64, with 'Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40'). Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] drivers/net/tulip/uli526x.c | 120