Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-23 Thread Andrew Lunn
> +static int lantiq_gphy_config_init(struct phy_device *phydev) > +{ > + int err; > + > + /* Mask all interrupts */ > + err = phy_write(phydev, MII_VR9_11G_IMASK, 0); > + if (err) > + return err; > + > + /* Clear all pending interrupts */ > + phy_read(phydev,

Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-23 Thread Andrew Lunn
> > I doubt the device tree maintainers will accept this. You don't normally put > > register values in device tree. > > Me too ;-) > > I will look into this: > http://lists.openwall.net/netdev/2016/03/23/61 and also try to make > the device tree interface more generic. Please take more notice

RE: [RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-23 Thread Mehrtens, Hauke
..@kresin.me; > Mehrtens, Hauke <hauke.mehrt...@intel.com> > Subject: Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G > > On Sun, May 22, 2016 at 09:33:51PM +0200, Hauke Mehrtens wrote: > > Supports the Lantiq / Intel CHD 11G and 22E PHYs. > > These PHYs are also named PE

Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-22 Thread Andrew Lunn
On Sun, May 22, 2016 at 09:33:51PM +0200, Hauke Mehrtens wrote: > Supports the Lantiq / Intel CHD 11G and 22E PHYs. > These PHYs are also named PEF 7061, PEF 7071, PEF 7072 > > Signed-off-by: John Crispin > Signed-off-by: Hauke Mehrtens > --- > > This is

Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-22 Thread Hauke Mehrtens
On 05/22/2016 10:30 PM, Mathias Kresin wrote: > Hi Hauke, > > find my comments in-line. > > Am 22.05.2016 um 21:33 schrieb Hauke Mehrtens: >> Supports the Lantiq / Intel CHD 11G and 22E PHYs. >> These PHYs are also named PEF 7061, PEF 7071, PEF 7072 >> >> Signed-off-by: John Crispin

Re: [RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-22 Thread Mathias Kresin
Hi Hauke, find my comments in-line. Am 22.05.2016 um 21:33 schrieb Hauke Mehrtens: Supports the Lantiq / Intel CHD 11G and 22E PHYs. These PHYs are also named PEF 7061, PEF 7071, PEF 7072 Signed-off-by: John Crispin Signed-off-by: Hauke Mehrtens --- This

[RFC] NET: PHY: adds driver for Lantiq PHY11G

2016-05-22 Thread Hauke Mehrtens
Supports the Lantiq / Intel CHD 11G and 22E PHYs. These PHYs are also named PEF 7061, PEF 7071, PEF 7072 Signed-off-by: John Crispin Signed-off-by: Hauke Mehrtens --- This is based on a driver from OpenWrt / LEDE. This is send as a RFC because the merge