On 28/09/16 10:12, David Laight wrote:
> If you invert the above and add a goto...
> if (!efx->rx_hash_udp_4tuple)
> goto set_ip;
I don't mind gotos...
>> case SCTP_V4_FLOW:
>> case AH_ESP_V4_FLOW:
>> case IP
From: Edward Cree
> Sent: 27 September 2016 17:36
...
> + case UDP_V4_FLOW:
> + if (efx->rx_hash_udp_4tuple)
> + /* fall through */
> + /* else fall further! */
If you invert the above and add a goto...
> info->data = 0;
> switch (info->flow_type) {
> + case UDP_V4_FLOW:
> + if (efx->rx_hash_udp_4tuple)
> + /* fall through */
> + /* else fall further! */
> case
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef10.c | 6 --
drivers/net/ethernet/sfc/ethtool.c| 14 ++
drivers/net/ethernet/sfc/net_driver.h | 2 ++
3 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net
