Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-19 Thread David Ahern
On 6/17/16 6:21 PM, Stephen Hemminger wrote: I want to have the least user complaints possible. Since the main reason people build new iproute2 utilities is to work with features of newer kernels. It makes sense to keep the requirements the same. Not sure if kernel still builds with gcc-3.2, ha

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Stephen Hemminger
On Sat, 18 Jun 2016 02:02:21 +0200 Phil Sutter wrote: > On Fri, Jun 17, 2016 at 11:57:53AM -0700, Stephen Hemminger wrote: > > It makes sense that if you can build a kernel with old toolchain, that > > iproute2 needs to be buildable as well. > > > > The current kernels are documented to require

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Phil Sutter
Hi, [Replying to multiple mails at once due to laziness.] On Fri, Jun 17, 2016 at 06:09:20PM +0200, Daniel Borkmann wrote: > Hmm, seems like a lot of stuff ... It is. At some point I thought about maybe hack something in cocci instead, but that would probably have taken longer given the code div

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread David Ahern
On 6/17/16 2:36 PM, Daniel Borkmann wrote: Once again, you have to ask Nicolas or Julien for their RHEL version, not me ... please have a look at 8f80d450c3cb. ;) I did, just ran right over the Author ;-) I just pointed to the fact that this would basically undo their changes that they've s

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Daniel Borkmann
On 06/17/2016 10:15 PM, David Ahern wrote: On 6/17/16 12:57 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:58:14 + Nicolas Dichtel wrote: Le 17/06/2016 18:46, Daniel Borkmann a écrit : On 06/17/2016 06:34 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:09:20 + Daniel Borkman

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread David Ahern
On 6/17/16 12:57 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:58:14 + Nicolas Dichtel wrote: Le 17/06/2016 18:46, Daniel Borkmann a écrit : On 06/17/2016 06:34 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:09:20 + Daniel Borkmann wrote: Please have a look at commit 8f

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Stephen Hemminger
On Fri, 17 Jun 2016 16:58:14 + Nicolas Dichtel wrote: > Le 17/06/2016 18:46, Daniel Borkmann a écrit : > > On 06/17/2016 06:34 PM, Stephen Hemminger wrote: > >> On Fri, 17 Jun 2016 16:09:20 + > >> Daniel Borkmann wrote: > >> > >>> Please have a look at commit 8f80d450c3cb ("tc: fix compi

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Nicolas Dichtel
Le 17/06/2016 18:46, Daniel Borkmann a écrit : > On 06/17/2016 06:34 PM, Stephen Hemminger wrote: >> On Fri, 17 Jun 2016 16:09:20 + >> Daniel Borkmann wrote: >> >>> Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc >>> (< 4.6)") ... >>> >>> Your changes effectively r

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Daniel Borkmann
On 06/17/2016 06:34 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:09:20 + Daniel Borkmann wrote: Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") ... Your changes effectively revert them again. Here, and some other parts of the bpf frontend co

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Stephen Hemminger
On Fri, 17 Jun 2016 16:09:20 + Daniel Borkmann wrote: > Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc > (< 4.6)") ... > > Your changes effectively revert them again. Here, and some other parts of the > bpf frontend > code bits. GCC 4.6 is 3 years old. So pe

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Daniel Borkmann
On 06/17/2016 05:56 PM, Phil Sutter wrote: This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. Calls to memset for struct rtattr pointer fields for parse_rtattr*() were just dropped since they are not needed. The changes here allowed the co

[iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-17 Thread Phil Sutter
This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. Calls to memset for struct rtattr pointer fields for parse_rtattr*() were just dropped since they are not needed. The changes here allowed the compiler to discover some unused variables, so