Re: [net-next PATCH] net: sched: document attach_default_qdiscs

2015-09-14 Thread Cong Wang
On Mon, Sep 14, 2015 at 3:42 PM, Phil Sutter wrote: > On Mon, Sep 14, 2015 at 03:07:42PM -0700, Cong Wang wrote: >> Maybe update default_qdisc description in Documentation/sysctl/net.txt? > > I don't think this is the right place for source code documentation. The > intended audience are users, an

Re: [net-next PATCH] net: sched: document attach_default_qdiscs

2015-09-14 Thread Phil Sutter
On Mon, Sep 14, 2015 at 03:07:42PM -0700, Cong Wang wrote: > On Mon, Sep 14, 2015 at 8:31 AM, Phil Sutter wrote: > > The process of selecting an interface's default qdisc is not really > > intuitive, at least because there are three different cases to consider. > > It is a static function, not an

Re: [net-next PATCH] net: sched: document attach_default_qdiscs

2015-09-14 Thread Cong Wang
On Mon, Sep 14, 2015 at 8:31 AM, Phil Sutter wrote: > The process of selecting an interface's default qdisc is not really > intuitive, at least because there are three different cases to consider. It is a static function, not an API, so I don't think it is the right place to document. Maybe upda

[net-next PATCH] net: sched: document attach_default_qdiscs

2015-09-14 Thread Phil Sutter
The process of selecting an interface's default qdisc is not really intuitive, at least because there are three different cases to consider. Signed-off-by: Phil Sutter --- net/sched/sch_generic.c | 12 1 file changed, 12 insertions(+) diff --git a/net/sched/sch_generic.c b/net/sche