Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-22 Thread Jamal Hadi Salim
On 16-05-20 01:16 AM, Cong Wang wrote: One nit: It is better if you can swap 'stm' with 'dtm', it looks odd to put destination on the right side. Will make the change for when net-next opens up. cheers, jamal

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-19 Thread Cong Wang
On Thu, May 19, 2016 at 9:38 AM, Cong Wang wrote: > On Thu, May 19, 2016 at 5:15 AM, Jamal Hadi Salim wrote: >> On 16-05-19 07:54 AM, Jamal Hadi Salim wrote: >>> >>> On 16-05-18 01:17 PM, Cong Wang wrote: >> >> I think it is the time to add a wrapper for these tm.XX = jiffies_to_clock_t

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-19 Thread Cong Wang
On Thu, May 19, 2016 at 5:15 AM, Jamal Hadi Salim wrote: > On 16-05-19 07:54 AM, Jamal Hadi Salim wrote: >> >> On 16-05-18 01:17 PM, Cong Wang wrote: > > >>> I think it is the time to add a wrapper for these tm.XX = >>> jiffies_to_clock_t(XXX). >>> >> >> Agreed. Will send a patch. >> Actually I wi

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-19 Thread Jamal Hadi Salim
On 16-05-19 07:54 AM, Jamal Hadi Salim wrote: On 16-05-18 01:17 PM, Cong Wang wrote: I think it is the time to add a wrapper for these tm.XX = jiffies_to_clock_t(XXX). Agreed. Will send a patch. Actually I will resend the firstuse as well without RFC tag and the wrapper one as separate patc

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-19 Thread Jamal Hadi Salim
On 16-05-18 01:17 PM, Cong Wang wrote: On Tue, May 17, 2016 at 4:38 PM, Jamal Hadi Salim wrote: diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c index 014f9a6..f581e01 100644 --- a/net/sched/act_bpf.c +++ b/net/sched/act_bpf.c @@ -156,6 +156,7 @@ static int tcf_bpf_dump(struct sk_buff *sk

Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-18 Thread Cong Wang
On Tue, May 17, 2016 at 4:38 PM, Jamal Hadi Salim wrote: > diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c > index 014f9a6..f581e01 100644 > --- a/net/sched/act_bpf.c > +++ b/net/sched/act_bpf.c > @@ -156,6 +156,7 @@ static int tcf_bpf_dump(struct sk_buff *skb, struct > tc_action *act, > >

[net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Useful to know when the action was first used for accounting (and debugging) Signed-off-by: Jamal Hadi Salim --- include/net/act_api.h| 2 ++ include/uapi/linux/pkt_cls.h | 1 + net/sched/act_api.c | 1 + net/sched/act_bpf.c | 1 + net/sched/act