Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-22 Thread Roopa Prabhu
On Mon, Jun 20, 2016 at 5:28 AM, Jamal Hadi Salim wrote: > On 16-06-19 11:14 PM, Roopa Prabhu wrote: >> >> On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli >> wrote: > > > >> >> I have also mentioned this before, the default api must provide >>

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-20 Thread Jiri Pirko
Mon, Jun 20, 2016 at 02:28:31PM CEST, j...@mojatatu.com wrote: >On 16-06-19 11:14 PM, Roopa Prabhu wrote: >>On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli >>wrote: > > >> >>I have also mentioned this before, the default api must provide >>accumulated (hw and sw)

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-20 Thread Jamal Hadi Salim
On 16-06-19 11:14 PM, Roopa Prabhu wrote: On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli wrote: I have also mentioned this before, the default api must provide accumulated (hw and sw) stats..., because this is the api that the user queries on an interface. Sorry

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Roopa Prabhu
On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli wrote: > On 06/17/2016 08:42 AM, Jiri Pirko wrote: >> Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote: >>> On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: On 16-06-17 10:05 AM, Jiri Pirko wrote: >

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Roopa Prabhu
On Fri, Jun 17, 2016 at 7:54 AM, Jamal Hadi Salim wrote: > On 16-06-17 10:05 AM, Jiri Pirko wrote: >> >> Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: >>> >>> On 6/17/16 2:24 AM, Jiri Pirko wrote: > >> >> That is problematic. Existing apps

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Roopa Prabhu
On Fri, Jun 17, 2016 at 7:05 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: >>On 6/17/16 2:24 AM, Jiri Pirko wrote: >>> >>>The problem we try to handle is different, it's about offloaded >>>forwarded packets which are not seen by

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Jiri Pirko
Sat, Jun 18, 2016 at 03:58:56PM CEST, j...@mojatatu.com wrote: >On 16-06-18 04:00 AM, Jiri Pirko wrote: >>Fri, Jun 17, 2016 at 07:12:22PM CEST, f.faine...@gmail.com wrote: > Yep. And I believe that for offloaded forwarding, this tools should see hw counters, as they show what is going on

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-18 Thread Jamal Hadi Salim
On 16-06-18 04:00 AM, Jiri Pirko wrote: Fri, Jun 17, 2016 at 07:12:22PM CEST, f.faine...@gmail.com wrote: Yep. And I believe that for offloaded forwarding, this tools should see hw counters, as they show what is going on in real. If your NIC is offloading packets today, these tools

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-18 Thread Jiri Pirko
Fri, Jun 17, 2016 at 07:12:22PM CEST, f.faine...@gmail.com wrote: >On 06/17/2016 08:42 AM, Jiri Pirko wrote: >> Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote: >>> On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: On 16-06-17 10:05 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread Florian Fainelli
On 06/17/2016 08:42 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote: >> On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: >>> On 16-06-17 10:05 AM, Jiri Pirko wrote: Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: > On 6/17/16

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread Jiri Pirko
Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote: >On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: >>On 16-06-17 10:05 AM, Jiri Pirko wrote: >>>Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: On 6/17/16 2:24 AM, Jiri Pirko wrote: > >> >>> >>>That is

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread David Ahern
On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: On 16-06-17 10:05 AM, Jiri Pirko wrote: Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: On 6/17/16 2:24 AM, Jiri Pirko wrote: That is problematic. Existing apps depend on rtnetlink stats. But if we don't count offloaded

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread Jiri Pirko
Fri, Jun 17, 2016 at 04:54:34PM CEST, j...@mojatatu.com wrote: >On 16-06-17 10:05 AM, Jiri Pirko wrote: >>Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: >>>On 6/17/16 2:24 AM, Jiri Pirko wrote: > >> >>That is problematic. Existing apps depend on rtnetlink stats. But if

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread Jamal Hadi Salim
On 16-06-17 10:05 AM, Jiri Pirko wrote: Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: On 6/17/16 2:24 AM, Jiri Pirko wrote: That is problematic. Existing apps depend on rtnetlink stats. But if we don't count offloaded forwarded packets, the apps don't see anything.

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread Jiri Pirko
Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: >On 6/17/16 2:24 AM, Jiri Pirko wrote: >> >>The problem we try to handle is different, it's about offloaded >>forwarded packets which are not seen by kernel. Let me try to draw it :) >> >>port1 port2

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread David Ahern
On 6/17/16 2:24 AM, Jiri Pirko wrote: The problem we try to handle is different, it's about offloaded forwarded packets which are not seen by kernel. Let me try to draw it :) port1 port2 (HW stats are counted here) \ / \

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-17 Thread Jiri Pirko
Fri, Jun 17, 2016 at 02:26:32AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 16 Jun 2016 10:37:13 +0200 > >> Until now we had stats functions return SW statistics. However, it makes >> a lot of sense to return HW stats as default. The existing apps count with

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-16 Thread David Miller
From: Jiri Pirko Date: Thu, 16 Jun 2016 10:37:13 +0200 > Until now we had stats functions return SW statistics. However, it makes > a lot of sense to return HW stats as default. The existing apps count with > having the defaults stats complete, but that is not true now as the

[patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-16 Thread Jiri Pirko
From: Jiri Pirko Nogah says: Until now we had stats functions return SW statistics. However, it makes a lot of sense to return HW stats as default. The existing apps count with having the defaults stats complete, but that is not true now as the offloaded forward traffic is