Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread David Miller
From: Eric Dumazet Date: Wed, 2 May 2018 20:25:13 -0700 > When adding rb-tree for TCP retransmit queue, we inadvertently broke > TCP autocorking. > > tcp_should_autocork() should really check if the rtx queue is not empty. > > Tested: ... > Fixes: 75c119afe14f ("tcp:

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Soheil Hassas Yeganeh
On Wed, May 2, 2018 at 11:25 PM, Eric Dumazet wrote: > Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue") > Signed-off-by: Eric Dumazet > Reported-by: Michael Wenig > Tested-by: Michael Wenig

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Neal Cardwell
On Wed, May 2, 2018 at 11:25 PM Eric Dumazet wrote: > When adding rb-tree for TCP retransmit queue, we inadvertently broke > TCP autocorking. > tcp_should_autocork() should really check if the rtx queue is not empty. ... > Fixes: 75c119afe14f ("tcp: implement rb-tree

RE: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Michael Wenig
Thank you, Eric, for fixing this! Michael -Original Message- From: Eric Dumazet [mailto:eduma...@google.com] Sent: Wednesday, May 2, 2018 8:25 PM To: David S . Miller Cc: netdev ; Eric Dumazet ; Michael Wenig

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Eric Dumazet
On Thu, May 3, 2018 at 4:06 AM Tariq Toukan wrote: > On 03/05/2018 6:25 AM, Eric Dumazet wrote: > > When adding rb-tree for TCP retransmit queue, we inadvertently broke > > TCP autocorking. > > > > tcp_should_autocork() should really check if the rtx queue is not empty. >

Re: [PATCH net] tcp: restore autocorking

2018-05-03 Thread Tariq Toukan
On 03/05/2018 6:25 AM, Eric Dumazet wrote: When adding rb-tree for TCP retransmit queue, we inadvertently broke TCP autocorking. tcp_should_autocork() should really check if the rtx queue is not empty. Hi Eric, We are glad to see that the issue that Tal investigated and reported [1] is